All of lore.kernel.org
 help / color / mirror / Atom feed
From: khilman@baylibre.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: da850: Add basic DTS for the L138/C6748 Dev Kit
Date: Thu, 04 Aug 2016 12:15:05 -0700	[thread overview]
Message-ID: <m2popopcqu.fsf@baylibre.com> (raw)
In-Reply-To: <20160804144332.4841-1-kbeldan@baylibre.com> (Karl Beldan's message of "Thu, 4 Aug 2016 14:43:32 +0000")

+ Sekhar

Hi Karl,

Karl Beldan <kbeldan@baylibre.com> writes:

> The LCDK is the successor to the late Hawkboard and has the same machine
> number.

Machine number is only relevant for legacy (non-DT) boot and this is DT
boot, so the machine number bit really relevant for this changelog.

BTW, have you tried legacy boot on LCDK with board-omapl138-hawk.c?  I
assume it mostly works?

> Among the differences are the flash (16bits vs 8bits) and some pins
> (MMC, LEDs, buttons, some external connectors), however the main
> components remain the same (eth. PHY, Audio Codec, Video decoder and
> DAC) except for the main PMIC, different and hard-wired on the LCDK (the
> LDOs and DCDCs are always ON).
> A DT-only boot with this addition gives functional uart, reboot via
> watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC
> although davinci_mmc doesn't call yet the mmc core OF facilities).
>
> Signed-off-by: Karl Beldan <kbeldan@baylibre.com>

Tested with v4.7 on my LCDK board.

Tested-by: Kevin Hilman <khilman@baylibre.com>

Note that I also needed CONFIG_RTC_DRV_OMAP=m enabled in
davinci_all_defconfig for the RTC driver. Could you add a patch for that
to this series as well?

Also, plese Cc the co-maintainer Sekhar Nori (now Cc'd) on all future
davinci patches.

> ---
>  Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
>  arch/arm/boot/dts/Makefile                        |  1 +
>  arch/arm/boot/dts/omapl138-lcdk.dts               | 71 +++++++++++++++++++++++

I think this should be called da850-lcdk.dts.

The OMAP prefix in the DT directory is just going to cause confusion,
and the other DTs using this same SoC are already called da850.

Sekhar do you have any opinion here?

[...]

> +/ {
> +	model = "DA850/AM1808/OMAP-L138 LCDK";
> +	compatible = "ti,omapl138-lcdk", "ti,da850";
> +
> +	aliases {
> +		serial2 = &serial2;
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS2,115200n8 earlycon";

earlycon is kind of a debug option, so probably should be left out of
the default DT.

> +		stdout-path = "serial2:115200n8";
> +	};

Kevin

WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Karl Beldan <kbeldan@baylibre.com>, Sekhar Nori <nsekhar@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, karl.beldan+oss@gmail.com,
	Russell King <linux@armlinux.org.uk>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: da850: Add basic DTS for the L138/C6748 Dev Kit
Date: Thu, 04 Aug 2016 12:15:05 -0700	[thread overview]
Message-ID: <m2popopcqu.fsf@baylibre.com> (raw)
In-Reply-To: <20160804144332.4841-1-kbeldan@baylibre.com> (Karl Beldan's message of "Thu, 4 Aug 2016 14:43:32 +0000")

+ Sekhar

Hi Karl,

Karl Beldan <kbeldan@baylibre.com> writes:

> The LCDK is the successor to the late Hawkboard and has the same machine
> number.

Machine number is only relevant for legacy (non-DT) boot and this is DT
boot, so the machine number bit really relevant for this changelog.

BTW, have you tried legacy boot on LCDK with board-omapl138-hawk.c?  I
assume it mostly works?

> Among the differences are the flash (16bits vs 8bits) and some pins
> (MMC, LEDs, buttons, some external connectors), however the main
> components remain the same (eth. PHY, Audio Codec, Video decoder and
> DAC) except for the main PMIC, different and hard-wired on the LCDK (the
> LDOs and DCDCs are always ON).
> A DT-only boot with this addition gives functional uart, reboot via
> watchdog, rtc, ethernet and MMC (I added the CD gpio for the MMC
> although davinci_mmc doesn't call yet the mmc core OF facilities).
>
> Signed-off-by: Karl Beldan <kbeldan@baylibre.com>

Tested with v4.7 on my LCDK board.

Tested-by: Kevin Hilman <khilman@baylibre.com>

Note that I also needed CONFIG_RTC_DRV_OMAP=m enabled in
davinci_all_defconfig for the RTC driver. Could you add a patch for that
to this series as well?

Also, plese Cc the co-maintainer Sekhar Nori (now Cc'd) on all future
davinci patches.

> ---
>  Documentation/devicetree/bindings/arm/davinci.txt |  4 ++
>  arch/arm/boot/dts/Makefile                        |  1 +
>  arch/arm/boot/dts/omapl138-lcdk.dts               | 71 +++++++++++++++++++++++

I think this should be called da850-lcdk.dts.

The OMAP prefix in the DT directory is just going to cause confusion,
and the other DTs using this same SoC are already called da850.

Sekhar do you have any opinion here?

[...]

> +/ {
> +	model = "DA850/AM1808/OMAP-L138 LCDK";
> +	compatible = "ti,omapl138-lcdk", "ti,da850";
> +
> +	aliases {
> +		serial2 = &serial2;
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS2,115200n8 earlycon";

earlycon is kind of a debug option, so probably should be left out of
the default DT.

> +		stdout-path = "serial2:115200n8";
> +	};

Kevin

  parent reply	other threads:[~2016-08-04 19:15 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04 14:43 [PATCH] ARM: dts: da850: Add basic DTS for the L138/C6748 Dev Kit Karl Beldan
2016-08-04 14:43 ` Karl Beldan
2016-08-04 18:29 ` Rob Herring
2016-08-04 18:29   ` Rob Herring
2016-08-04 21:03   ` Karl Beldan
2016-08-04 21:03     ` Karl Beldan
2016-08-04 21:13     ` Rob Herring
2016-08-04 21:13       ` Rob Herring
2016-08-04 23:43       ` Karl Beldan
2016-08-04 23:43         ` Karl Beldan
2016-10-13  7:14         ` Karl Beldan
2016-10-13  7:14           ` Karl Beldan
2016-08-04 19:15 ` Kevin Hilman [this message]
2016-08-04 19:15   ` Kevin Hilman
2016-08-04 20:58   ` Karl Beldan
2016-08-04 20:58     ` Karl Beldan
     [not found]   ` <20160804200522.GB15878@gobelin>
2016-08-05  0:25     ` Kevin Hilman
2016-08-05  0:25       ` Kevin Hilman
2016-08-05 14:00   ` Sekhar Nori
2016-08-05 14:00     ` Sekhar Nori
2016-08-05 14:12 ` [PATCH v2 0/3] Support for the L138/C6748 Dev Kit (LCDK) Karl Beldan
2016-08-05 14:12   ` Karl Beldan
2016-08-05 14:12   ` [PATCH v2 1/3] ARM: dts: da850: Add basic DTS for the L138/C6748 Dev Kit Karl Beldan
2016-08-05 14:12     ` Karl Beldan
2016-08-10 18:35     ` Rob Herring
2016-08-10 18:35       ` Rob Herring
2016-08-05 14:12   ` [PATCH v2 2/3] ARM: davinci_all_defconfig: enable RTC driver as module Karl Beldan
2016-08-05 14:12     ` Karl Beldan
2016-08-05 14:12   ` [PATCH v2 3/3] ARM: davinci_all_defconfig: enable SMSC ethernet PHY Karl Beldan
2016-08-05 14:12     ` Karl Beldan
2016-08-05 14:14 ` [PATCH] ARM: dts: da850: Add basic DTS for the L138/C6748 Dev Kit Sekhar Nori
2016-08-05 14:14   ` Sekhar Nori
2016-08-05 14:45   ` Karl Beldan
2016-08-05 14:45     ` Karl Beldan
2016-08-05 14:52     ` Sekhar Nori
2016-08-05 14:52       ` Sekhar Nori
2016-08-05 14:59 ` [PATCH v3 0/3] Support for the LCDK Karl Beldan
2016-08-05 14:59   ` Karl Beldan
2016-08-05 14:59   ` [PATCH v3 1/3] ARM: dts: da850: Add basic DTS " Karl Beldan
2016-08-05 14:59     ` Karl Beldan
2016-08-05 14:59   ` [PATCH v3 2/3] ARM: davinci_all_defconfig: enable RTC driver as module Karl Beldan
2016-08-05 14:59     ` Karl Beldan
2016-08-05 14:59   ` [PATCH v3 3/3] ARM: davinci_all_defconfig: enable SMSC ethernet PHY Karl Beldan
2016-08-05 14:59     ` Karl Beldan
2016-08-05 20:29 ` [PATCH v4 0/3] Support for the LCDK Karl Beldan
2016-08-05 20:29   ` Karl Beldan
2016-08-05 20:29   ` [PATCH v4 1/3] ARM: dts: da850: Add basic DTS " Karl Beldan
2016-08-05 20:29     ` Karl Beldan
2016-08-05 20:29   ` [PATCH v4 2/3] ARM: davinci_all_defconfig: enable RTC driver as module Karl Beldan
2016-08-05 20:29     ` Karl Beldan
2016-08-05 23:45     ` Kevin Hilman
2016-08-05 23:45       ` Kevin Hilman
2016-08-05 20:29   ` [PATCH v4 3/3] ARM: davinci_all_defconfig: enable SMSC ethernet PHY Karl Beldan
2016-08-05 20:29     ` Karl Beldan
2016-08-05 23:46     ` Kevin Hilman
2016-08-05 23:46       ` Kevin Hilman
2016-08-09 11:59   ` [PATCH v4 0/3] Support for the LCDK Sekhar Nori
2016-08-09 11:59     ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2popopcqu.fsf@baylibre.com \
    --to=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.