From: Peter Xu <peterx@redhat.com>
To: David Kiarie <davidkiarie4@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
rkrcmar@redhat.com, Jan Kiszka <jan.kiszka@web.de>,
Valentine Sinitsyn <valentine.sinitsyn@gmail.com>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU
Date: Tue, 9 Aug 2016 20:21:00 +0800 [thread overview]
Message-ID: <20160809122100.GA4201@pxdev.xzpeter.org> (raw)
In-Reply-To: <CABdVeABrGUmkGgDYMEvVLPR-6wfRipha57Y4iDzLrqY50v-SbQ@mail.gmail.com>
On Tue, Aug 09, 2016 at 03:07:43PM +0300, David Kiarie wrote:
> On Tue, Aug 9, 2016 at 8:44 AM, Peter Xu <peterx@redhat.com> wrote:
>
> > On Tue, Aug 02, 2016 at 11:39:06AM +0300, David Kiarie wrote:
> >
> > [...]
> >
> >
> Hi Peter.
>
> Most of your comments are valid thought some are subjective :-). I'm
> covering most if not all of them on next version (should coming shortly).
Hi, David,
I think for most subjective comments, I was using "Nit:" as prefix.
Most of the other comments should not? ;)
For endian issue, I am not sure whether that's important, since I
don't know whether there will be anyone run x86_64 on e.g. big endian
machines with a AMD IOMMU... For the other comments besides "nit" and
"endianess" issues, I would like to hear your opinion if you disagree
on any of them (so I can learn as well if I made any mistake). :)
Thanks,
-- peterx
next prev parent reply other threads:[~2016-08-09 12:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 8:39 [Qemu-devel] [V15 0/4] AMD IOMMU David Kiarie
2016-08-02 8:39 ` [Qemu-devel] [V15 1/4] hw/pci: Prepare for " David Kiarie
2016-08-08 9:01 ` Peter Xu
2016-08-08 9:25 ` David Kiarie
2016-08-02 8:39 ` [Qemu-devel] [V15 2/4] hw/i386/trace-events: Add AMD IOMMU trace events David Kiarie
2016-08-02 8:39 ` [Qemu-devel] [V15 3/4] hw/i386: Introduce AMD IOMMU David Kiarie
2016-08-09 5:44 ` Peter Xu
2016-08-09 12:07 ` David Kiarie
2016-08-09 12:21 ` Peter Xu [this message]
2016-08-09 12:52 ` David Kiarie
2016-08-09 13:01 ` Valentine Sinitsyn
2016-08-09 13:17 ` David Kiarie
2016-08-10 2:08 ` Peter Xu
2016-08-10 6:30 ` David Kiarie
2016-08-09 17:46 ` David Kiarie
2016-08-10 1:49 ` Peter Xu
2016-08-11 8:23 ` Valentine Sinitsyn
2016-08-11 8:32 ` David Kiarie
2016-08-11 8:35 ` Valentine Sinitsyn
2016-08-12 19:10 ` Valentine Sinitsyn
2016-08-12 19:40 ` David Kiarie
2016-08-12 19:41 ` Valentine Sinitsyn
2016-08-02 8:39 ` [Qemu-devel] [V15 4/4] hw/i386: AMD IOMMU IVRS table David Kiarie
2016-08-02 13:32 ` Igor Mammedov
-- strict thread matches above, loose matches on Subject: below --
2016-08-09 20:27 [Qemu-devel] [V15 0/4] AMD IOMMU David Kiarie
2016-08-09 20:27 ` [Qemu-devel] [V15 3/4] hw/i386: Introduce " David Kiarie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809122100.GA4201@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=davidkiarie4@gmail.com \
--cc=ehabkost@redhat.com \
--cc=jan.kiszka@web.de \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
--cc=valentine.sinitsyn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.