All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v15 07/13] arm64: factor work_pending state machine to C
Date: Wed, 17 Aug 2016 09:05:31 +0100	[thread overview]
Message-ID: <20160817080531.GA5601@arm.com> (raw)
In-Reply-To: <1471382376-5443-8-git-send-email-cmetcalf@mellanox.com>

Hi Chris,

On Tue, Aug 16, 2016 at 05:19:30PM -0400, Chris Metcalf wrote:
> Currently ret_fast_syscall, work_pending, and ret_to_user form an ad-hoc
> state machine that can be difficult to reason about due to duplicated
> code and a large number of branch targets.
> 
> This patch factors the common logic out into the existing
> do_notify_resume function, converting the code to C in the process,
> making the code more legible.
> 
> This patch tries to closely mirror the existing behaviour while using
> the usual C control flow primitives. As local_irq_{disable,enable} may
> be instrumented, we balance exception entry (where we will almost most
> likely enable IRQs) with a call to trace_hardirqs_on just before the
> return to userspace.
> 
> Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
> ---
>  arch/arm64/kernel/entry.S  | 12 ++++--------
>  arch/arm64/kernel/signal.c | 36 ++++++++++++++++++++++++++----------
>  2 files changed, 30 insertions(+), 18 deletions(-)

I plan to queue this one in the arm64 tree for 4.9. Should hit -next
sometime next week.

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Chris Metcalf <cmetcalf@mellanox.com>
Cc: Gilad Ben Yossef <giladb@mellanox.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>, Tejun Heo <tj@kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Christoph Lameter <cl@linux.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Andy Lutomirski <luto@amacapital.net>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v15 07/13] arm64: factor work_pending state machine to C
Date: Wed, 17 Aug 2016 09:05:31 +0100	[thread overview]
Message-ID: <20160817080531.GA5601@arm.com> (raw)
In-Reply-To: <1471382376-5443-8-git-send-email-cmetcalf@mellanox.com>

Hi Chris,

On Tue, Aug 16, 2016 at 05:19:30PM -0400, Chris Metcalf wrote:
> Currently ret_fast_syscall, work_pending, and ret_to_user form an ad-hoc
> state machine that can be difficult to reason about due to duplicated
> code and a large number of branch targets.
> 
> This patch factors the common logic out into the existing
> do_notify_resume function, converting the code to C in the process,
> making the code more legible.
> 
> This patch tries to closely mirror the existing behaviour while using
> the usual C control flow primitives. As local_irq_{disable,enable} may
> be instrumented, we balance exception entry (where we will almost most
> likely enable IRQs) with a call to trace_hardirqs_on just before the
> return to userspace.
> 
> Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
> ---
>  arch/arm64/kernel/entry.S  | 12 ++++--------
>  arch/arm64/kernel/signal.c | 36 ++++++++++++++++++++++++++----------
>  2 files changed, 30 insertions(+), 18 deletions(-)

I plan to queue this one in the arm64 tree for 4.9. Should hit -next
sometime next week.

Will

  reply	other threads:[~2016-08-17  8:05 UTC|newest]

Thread overview: 125+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-16 21:19 [PATCH v15 00/13] support "task_isolation" mode Chris Metcalf
2016-08-16 21:19 ` [PATCH v15 01/13] vmstat: add quiet_vmstat_sync function Chris Metcalf
2016-08-16 21:19 ` [PATCH v15 02/13] vmstat: add vmstat_idle function Chris Metcalf
2016-08-16 21:19   ` Chris Metcalf
2016-08-16 21:19 ` [PATCH v15 03/13] lru_add_drain_all: factor out lru_add_drain_needed Chris Metcalf
2016-08-16 21:19   ` Chris Metcalf
2016-08-16 21:19 ` [PATCH v15 04/13] task_isolation: add initial support Chris Metcalf
2016-08-16 21:19   ` Chris Metcalf
2016-08-29 16:33   ` Peter Zijlstra
2016-08-29 16:33     ` Peter Zijlstra
2016-08-29 16:40     ` Chris Metcalf
2016-08-29 16:40       ` Chris Metcalf
2016-08-29 16:48       ` Peter Zijlstra
2016-08-29 16:48         ` Peter Zijlstra
2016-08-29 16:53         ` Chris Metcalf
2016-08-29 16:53           ` Chris Metcalf
2016-08-30  7:59           ` Peter Zijlstra
2016-08-30  7:59             ` Peter Zijlstra
2016-08-30  7:58       ` Peter Zijlstra
2016-08-30  7:58         ` Peter Zijlstra
     [not found]         ` <20160830075854.GZ10153-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2016-08-30 15:32           ` Chris Metcalf
2016-08-30 15:32             ` Chris Metcalf
2016-08-30 15:32             ` Chris Metcalf
2016-08-30 16:30             ` Andy Lutomirski
2016-08-30 16:30               ` Andy Lutomirski
2016-08-30 16:30               ` Andy Lutomirski
2016-08-30 17:02               ` Chris Metcalf
2016-08-30 17:02                 ` Chris Metcalf
2016-08-30 18:43                 ` Andy Lutomirski
2016-08-30 18:43                   ` Andy Lutomirski
2016-08-30 19:37                   ` Chris Metcalf
2016-08-30 19:37                     ` Chris Metcalf
2016-08-30 19:50                     ` Andy Lutomirski
2016-08-30 19:50                       ` Andy Lutomirski
2016-08-30 19:50                       ` Andy Lutomirski
2016-09-02 14:04                       ` Chris Metcalf
2016-09-02 14:04                         ` Chris Metcalf
     [not found]                         ` <3f84f736-ed7f-adff-d5f0-4f7db664208f-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-09-02 17:28                           ` Andy Lutomirski
2016-09-02 17:28                             ` Andy Lutomirski
2016-09-02 17:28                             ` Andy Lutomirski
2016-09-09 17:40                             ` Chris Metcalf
2016-09-09 17:40                               ` Chris Metcalf
2016-09-12 17:41                               ` Andy Lutomirski
2016-09-12 17:41                                 ` Andy Lutomirski
2016-09-12 19:25                                 ` Chris Metcalf
2016-09-12 19:25                                   ` Chris Metcalf
2016-09-27 14:22                             ` Frederic Weisbecker
2016-09-27 14:22                               ` Frederic Weisbecker
2016-09-27 14:39                               ` Peter Zijlstra
2016-09-27 14:39                                 ` Peter Zijlstra
2016-09-27 14:51                                 ` Frederic Weisbecker
2016-09-27 14:51                                   ` Frederic Weisbecker
2016-09-27 14:48                               ` Paul E. McKenney
2016-09-27 14:48                                 ` Paul E. McKenney
2016-09-30 16:59                   ` Chris Metcalf
2016-09-30 16:59                     ` Chris Metcalf
2016-09-01 10:06             ` Peter Zijlstra
2016-09-01 10:06               ` Peter Zijlstra
2016-09-02 14:03               ` Chris Metcalf
2016-09-02 14:03                 ` Chris Metcalf
2016-09-02 16:40                 ` Peter Zijlstra
2016-09-02 16:40                   ` Peter Zijlstra
2017-02-02 16:13   ` Eugene Syromiatnikov
2017-02-02 18:12     ` Chris Metcalf
2016-08-16 21:19 ` [PATCH v15 05/13] task_isolation: track asynchronous interrupts Chris Metcalf
2016-08-16 21:19 ` [PATCH v15 06/13] arch/x86: enable task isolation functionality Chris Metcalf
2016-08-30 21:46   ` Andy Lutomirski
2016-08-16 21:19 ` [PATCH v15 07/13] arm64: factor work_pending state machine to C Chris Metcalf
2016-08-16 21:19   ` Chris Metcalf
2016-08-17  8:05   ` Will Deacon [this message]
2016-08-17  8:05     ` Will Deacon
2016-08-16 21:19 ` [PATCH v15 08/13] arch/arm64: enable task isolation functionality Chris Metcalf
2016-08-16 21:19   ` Chris Metcalf
2016-08-26 16:25   ` Catalin Marinas
2016-08-26 16:25     ` Catalin Marinas
2016-08-16 21:19 ` [PATCH v15 09/13] arch/tile: " Chris Metcalf
2016-08-16 21:19 ` [PATCH v15 10/13] arm, tile: turn off timer tick for oneshot_stopped state Chris Metcalf
2016-08-16 21:19 ` [PATCH v15 11/13] task_isolation: support CONFIG_TASK_ISOLATION_ALL Chris Metcalf
2016-08-16 21:19 ` [PATCH v15 12/13] task_isolation: add user-settable notification signal Chris Metcalf
2016-08-16 21:19 ` [PATCH v15 13/13] task_isolation self test Chris Metcalf
     [not found] ` <1471382376-5443-1-git-send-email-cmetcalf-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-08-17 19:37   ` [PATCH] Fix /proc/stat freezes (was [PATCH v15] "task_isolation" mode) Christoph Lameter
2016-08-17 19:37     ` Christoph Lameter
2016-08-20  1:42     ` Chris Metcalf
2016-08-20  1:42       ` Chris Metcalf
2016-09-28 13:16     ` Frederic Weisbecker
2016-08-29 16:27 ` Ping: [PATCH v15 00/13] support "task_isolation" mode Chris Metcalf
2016-08-29 16:27   ` Chris Metcalf
2016-09-07 21:11   ` Francis Giraldeau
     [not found]     ` <057a958c-4491-b449-ae59-7d331afc872d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-07 21:39       ` Francis Giraldeau
2016-09-07 21:39         ` Francis Giraldeau
2016-09-08 16:21       ` Francis Giraldeau
2016-09-08 16:21         ` Francis Giraldeau
2016-09-12 16:01     ` Chris Metcalf
2016-09-12 16:01       ` Chris Metcalf
2016-09-12 16:14       ` Peter Zijlstra
2016-09-12 21:15         ` Rafael J. Wysocki
2016-09-13  0:05           ` Rafael J. Wysocki
2016-09-13 16:00             ` Francis Giraldeau
2016-09-13  0:20       ` Francis Giraldeau
     [not found]         ` <3e93004f-e1c5-f606-33fb-7cb44b99eb0a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-09-13 16:12           ` Chris Metcalf
2016-09-13 16:12             ` Chris Metcalf
2016-09-27 14:49           ` Frederic Weisbecker
2016-09-27 14:49             ` Frederic Weisbecker
2016-09-27 14:35   ` Frederic Weisbecker
2016-09-30 17:07     ` Chris Metcalf
2016-09-30 17:07       ` Chris Metcalf
2016-11-05  4:04 ` task isolation discussion at Linux Plumbers Chris Metcalf
2016-11-05 16:05   ` Christoph Lameter
2016-11-07 16:55   ` Thomas Gleixner
2016-11-07 18:36     ` Thomas Gleixner
2016-11-07 19:12       ` Rik van Riel
2016-11-07 19:16         ` Will Deacon
2016-11-07 19:18           ` Rik van Riel
2016-11-11 20:54     ` Luiz Capitulino
2016-11-09  1:40   ` Paul E. McKenney
2016-11-09 11:14     ` Andy Lutomirski
2016-11-09 17:38       ` Paul E. McKenney
2016-11-09 18:57         ` Will Deacon
2016-11-09 19:11           ` Paul E. McKenney
2016-11-10  1:44         ` Andy Lutomirski
2016-11-10  4:52           ` Paul E. McKenney
2016-11-10  5:10             ` Paul E. McKenney
2016-11-11 17:00             ` Andy Lutomirski
2016-11-09 11:07   ` Frederic Weisbecker
2016-12-19 14:37   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160817080531.GA5601@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.