From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
sboyd@codeaurora.org, mturquette@baylibre.com,
sebastian.hesselbarth@gmail.com, andrew@lunn.ch,
jason@lakedaemon.net, gregory.clement@free-electrons.com,
nadavh@marvell.com, alior@marvell.com, tn@semihalf.com,
jaz@semihalf.com
Subject: Re: [PATCH 2/2] clk: mvebu: dynamically allocate resources in Armada CP110 system controller
Date: Tue, 30 Aug 2016 16:15:32 +0200 [thread overview]
Message-ID: <20160830161532.0770bdff@free-electrons.com> (raw)
In-Reply-To: <1471933609-8456-3-git-send-email-mw@semihalf.com>
Hello,
On Tue, 23 Aug 2016 08:26:49 +0200, Marcin Wojtas wrote:
> Original commit, which added support for Armada CP110 system controller
> used global variables for storing all clock information. It worked
> fine for Armada 7k SoC, with single CP110 block. After dual-CP110 Armada 8k
> was introduced, the data got overwritten and corrupted.
>
> This patch fixes the issue by allocating resources dynamically in the
> driver probe and storing it as platform drvdata.
>
> Fixes: d3da3eaef7f4 ("clk: mvebu: new driver for Armada CP110 system ...")
Adding:
CC: <stable@vger.kernel.org>
here would be useful.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Other than that:
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
(on Armada 8K hardware)
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thanks a lot for fixing the crap that I initially wrote :-/
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: mvebu: dynamically allocate resources in Armada CP110 system controller
Date: Tue, 30 Aug 2016 16:15:32 +0200 [thread overview]
Message-ID: <20160830161532.0770bdff@free-electrons.com> (raw)
In-Reply-To: <1471933609-8456-3-git-send-email-mw@semihalf.com>
Hello,
On Tue, 23 Aug 2016 08:26:49 +0200, Marcin Wojtas wrote:
> Original commit, which added support for Armada CP110 system controller
> used global variables for storing all clock information. It worked
> fine for Armada 7k SoC, with single CP110 block. After dual-CP110 Armada 8k
> was introduced, the data got overwritten and corrupted.
>
> This patch fixes the issue by allocating resources dynamically in the
> driver probe and storing it as platform drvdata.
>
> Fixes: d3da3eaef7f4 ("clk: mvebu: new driver for Armada CP110 system ...")
Adding:
CC: <stable@vger.kernel.org>
here would be useful.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Other than that:
Tested-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
(on Armada 8K hardware)
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Thanks a lot for fixing the crap that I initially wrote :-/
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-08-30 14:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 6:26 [PATCH 0/2] Armada 7k/8k CP110 system controller fixes Marcin Wojtas
2016-08-23 6:26 ` Marcin Wojtas
2016-08-23 6:26 ` [PATCH 1/2] clk: mvebu: set flags in CP110 gate clock Marcin Wojtas
2016-08-23 6:26 ` Marcin Wojtas
2016-08-23 14:16 ` Andrew Lunn
2016-08-23 14:16 ` Andrew Lunn
2016-08-24 8:28 ` Marcin Wojtas
2016-08-24 8:28 ` Marcin Wojtas
2016-08-25 0:13 ` Stephen Boyd
2016-08-25 0:13 ` Stephen Boyd
2016-08-30 13:10 ` Thomas Petazzoni
2016-08-30 13:10 ` Thomas Petazzoni
2016-08-30 13:34 ` Marcin Wojtas
2016-08-30 13:34 ` Marcin Wojtas
2016-08-23 6:26 ` [PATCH 2/2] clk: mvebu: dynamically allocate resources in Armada CP110 system controller Marcin Wojtas
2016-08-23 6:26 ` Marcin Wojtas
2016-08-25 0:16 ` Stephen Boyd
2016-08-25 0:16 ` Stephen Boyd
2016-08-30 15:31 ` Marcin Wojtas
2016-08-30 15:31 ` Marcin Wojtas
2016-08-30 18:43 ` Stephen Boyd
2016-08-30 18:43 ` Stephen Boyd
2016-08-30 14:15 ` Thomas Petazzoni [this message]
2016-08-30 14:15 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830161532.0770bdff@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=sboyd@codeaurora.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tn@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.