From: Stephen Boyd <sboyd@codeaurora.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-kernel@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-clk@vger.kernel.org,
"Michael Turquette" <mturquette@baylibre.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Jason Cooper" <jason@lakedaemon.net>,
"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
"Gregory Clément" <gregory.clement@free-electrons.com>,
nadavh@marvell.com, "Lior Amsalem" <alior@marvell.com>,
"Tomasz Nowicki" <tn@semihalf.com>,
"Grzegorz Jaszczyk" <jaz@semihalf.com>
Subject: Re: [PATCH 2/2] clk: mvebu: dynamically allocate resources in Armada CP110 system controller
Date: Tue, 30 Aug 2016 11:43:09 -0700 [thread overview]
Message-ID: <20160830184309.GB12510@codeaurora.org> (raw)
In-Reply-To: <CAPv3WKdVX1p3qmUufXE_cd=A0fuS8Eg9ELT0AYnXV6Z=cgJg-w@mail.gmail.com>
On 08/30, Marcin Wojtas wrote:
> 2016-08-25 2:16 GMT+02:00 Stephen Boyd <sboyd@codeaurora.org>:
> > On 08/23, Marcin Wojtas wrote:
> >> @@ -335,10 +343,12 @@ static int cp110_syscon_clk_probe(struct platform_device *pdev)
> >> cp110_clks[CP110_MAX_CORE_CLOCKS + i] = clk;
> >> }
> >>
> >> - ret = of_clk_add_provider(np, cp110_of_clk_get, &cp110_clk_data);
> >> + ret = of_clk_add_provider(np, cp110_of_clk_get, cp110_clk_data);
> >
> > It would be nice if this could be converted to
> > of_clk_add_hw_provider().
>
> Will try it. Shouldn't such change be placed in separate commit?
Yes, of course.
>
> >
> >> if (ret)
> >> goto fail_clk_add;
> >>
> >> + platform_set_drvdata(pdev, cp110_clks);
> >> +
> >> return 0;
> >>
> >> fail_clk_add:
> >> @@ -365,6 +375,7 @@ fail0:
> >>
> >> static int cp110_syscon_clk_remove(struct platform_device *pdev)
> >> {
> >> + struct clk **cp110_clks = platform_get_drvdata(pdev);
> >
> > Is this variable unused now?
>
> No, why? Just below there is a loop using it. Before it was taken from
> global variable, which I got rid of.
>
Ok. I was just looking at the patch context.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] clk: mvebu: dynamically allocate resources in Armada CP110 system controller
Date: Tue, 30 Aug 2016 11:43:09 -0700 [thread overview]
Message-ID: <20160830184309.GB12510@codeaurora.org> (raw)
In-Reply-To: <CAPv3WKdVX1p3qmUufXE_cd=A0fuS8Eg9ELT0AYnXV6Z=cgJg-w@mail.gmail.com>
On 08/30, Marcin Wojtas wrote:
> 2016-08-25 2:16 GMT+02:00 Stephen Boyd <sboyd@codeaurora.org>:
> > On 08/23, Marcin Wojtas wrote:
> >> @@ -335,10 +343,12 @@ static int cp110_syscon_clk_probe(struct platform_device *pdev)
> >> cp110_clks[CP110_MAX_CORE_CLOCKS + i] = clk;
> >> }
> >>
> >> - ret = of_clk_add_provider(np, cp110_of_clk_get, &cp110_clk_data);
> >> + ret = of_clk_add_provider(np, cp110_of_clk_get, cp110_clk_data);
> >
> > It would be nice if this could be converted to
> > of_clk_add_hw_provider().
>
> Will try it. Shouldn't such change be placed in separate commit?
Yes, of course.
>
> >
> >> if (ret)
> >> goto fail_clk_add;
> >>
> >> + platform_set_drvdata(pdev, cp110_clks);
> >> +
> >> return 0;
> >>
> >> fail_clk_add:
> >> @@ -365,6 +375,7 @@ fail0:
> >>
> >> static int cp110_syscon_clk_remove(struct platform_device *pdev)
> >> {
> >> + struct clk **cp110_clks = platform_get_drvdata(pdev);
> >
> > Is this variable unused now?
>
> No, why? Just below there is a loop using it. Before it was taken from
> global variable, which I got rid of.
>
Ok. I was just looking at the patch context.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-08-30 18:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 6:26 [PATCH 0/2] Armada 7k/8k CP110 system controller fixes Marcin Wojtas
2016-08-23 6:26 ` Marcin Wojtas
2016-08-23 6:26 ` [PATCH 1/2] clk: mvebu: set flags in CP110 gate clock Marcin Wojtas
2016-08-23 6:26 ` Marcin Wojtas
2016-08-23 14:16 ` Andrew Lunn
2016-08-23 14:16 ` Andrew Lunn
2016-08-24 8:28 ` Marcin Wojtas
2016-08-24 8:28 ` Marcin Wojtas
2016-08-25 0:13 ` Stephen Boyd
2016-08-25 0:13 ` Stephen Boyd
2016-08-30 13:10 ` Thomas Petazzoni
2016-08-30 13:10 ` Thomas Petazzoni
2016-08-30 13:34 ` Marcin Wojtas
2016-08-30 13:34 ` Marcin Wojtas
2016-08-23 6:26 ` [PATCH 2/2] clk: mvebu: dynamically allocate resources in Armada CP110 system controller Marcin Wojtas
2016-08-23 6:26 ` Marcin Wojtas
2016-08-25 0:16 ` Stephen Boyd
2016-08-25 0:16 ` Stephen Boyd
2016-08-30 15:31 ` Marcin Wojtas
2016-08-30 15:31 ` Marcin Wojtas
2016-08-30 18:43 ` Stephen Boyd [this message]
2016-08-30 18:43 ` Stephen Boyd
2016-08-30 14:15 ` Thomas Petazzoni
2016-08-30 14:15 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830184309.GB12510@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tn@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.