From: Vinod Koul <vinod.koul@intel.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org,
cov@codeaurora.org, jcm@redhat.com, agross@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Dan Williams <dan.j.williams@intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Dave Jiang <dave.jiang@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status
Date: Wed, 31 Aug 2016 09:51:31 +0530 [thread overview]
Message-ID: <20160831042131.GP9355@localhost> (raw)
In-Reply-To: <de65e834-03bf-49bc-422b-141c1c4d6100@codeaurora.org>
On Tue, Aug 30, 2016 at 01:51:02PM -0400, Sinan Kaya wrote:
> On 8/30/2016 1:37 PM, Sinan Kaya wrote:
> > On 8/30/2016 1:04 PM, Vinod Koul wrote:
> >> On Tue, Aug 23, 2016 at 12:48:11AM -0400, Sinan Kaya wrote:
> >>
> >>> spin_lock_init(&lldev->lock);
> >>> - tasklet_init(&lldev->rst_task, hidma_ll_abort, (unsigned long)lldev);
> >>
> >> ??
> >>
> >> This is not described in changlog? If you are not using in anywhere else,
> >> then rst_task variable should be removed too..
> >>
> >
> > Sure, I can add more description. I thought I did mention that we are no longer
> > resetting the hardware in ISR.
> >
> > I can certainly mention that rst_task variable is removed and can get rid of it.
> > It is no longer in use.
> >
>
> It looks like I mentioned this in the cover letter only not in the commit message.
> I'll pull the description into the commit message too.
Sounds good to me, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status
Date: Wed, 31 Aug 2016 09:51:31 +0530 [thread overview]
Message-ID: <20160831042131.GP9355@localhost> (raw)
In-Reply-To: <de65e834-03bf-49bc-422b-141c1c4d6100@codeaurora.org>
On Tue, Aug 30, 2016 at 01:51:02PM -0400, Sinan Kaya wrote:
> On 8/30/2016 1:37 PM, Sinan Kaya wrote:
> > On 8/30/2016 1:04 PM, Vinod Koul wrote:
> >> On Tue, Aug 23, 2016 at 12:48:11AM -0400, Sinan Kaya wrote:
> >>
> >>> spin_lock_init(&lldev->lock);
> >>> - tasklet_init(&lldev->rst_task, hidma_ll_abort, (unsigned long)lldev);
> >>
> >> ??
> >>
> >> This is not described in changlog? If you are not using in anywhere else,
> >> then rst_task variable should be removed too..
> >>
> >
> > Sure, I can add more description. I thought I did mention that we are no longer
> > resetting the hardware in ISR.
> >
> > I can certainly mention that rst_task variable is removed and can get rid of it.
> > It is no longer in use.
> >
>
> It looks like I mentioned this in the cover letter only not in the commit message.
> I'll pull the description into the commit message too.
Sounds good to me, thanks
--
~Vinod
next prev parent reply other threads:[~2016-08-31 4:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 4:48 [PATCH V3 0/3] dmaengine: qcom_hidma: add error reporting Sinan Kaya
2016-08-23 4:48 ` Sinan Kaya
2016-08-23 4:48 ` [PATCH V3 1/3] dmaengine: qcom_hidma: release the descriptor before the callback Sinan Kaya
2016-08-23 4:48 ` Sinan Kaya
2016-08-23 4:48 ` [PATCH V3 2/3] dmaengine: qcom_hidma: report transfer errors with new interface Sinan Kaya
2016-08-23 4:48 ` Sinan Kaya
2016-08-23 4:48 ` [PATCH V3 3/3] dmaengine: qcom_hidma: add error reporting for tx_status Sinan Kaya
2016-08-23 4:48 ` Sinan Kaya
2016-08-30 17:04 ` Vinod Koul
2016-08-30 17:04 ` Vinod Koul
2016-08-30 17:37 ` Sinan Kaya
2016-08-30 17:37 ` Sinan Kaya
2016-08-30 17:51 ` Sinan Kaya
2016-08-30 17:51 ` Sinan Kaya
2016-08-31 4:21 ` Vinod Koul [this message]
2016-08-31 4:21 ` Vinod Koul
2016-08-29 15:30 ` [PATCH V3 0/3] dmaengine: qcom_hidma: add error reporting Sinan Kaya
2016-08-29 15:30 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831042131.GP9355@localhost \
--to=vinod.koul@intel.com \
--cc=agross@codeaurora.org \
--cc=andy.shevchenko@gmail.com \
--cc=cov@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.