From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <keith.busch@intel.com>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@fb.com, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 4/7] blk-mq: allow the driver to pass in an affinity mask
Date: Thu, 1 Sep 2016 10:46:24 +0200 [thread overview]
Message-ID: <20160901084624.GC4115@lst.de> (raw)
In-Reply-To: <20160831163852.GB5598@localhost.localdomain>
On Wed, Aug 31, 2016 at 12:38:53PM -0400, Keith Busch wrote:
> This can't be right. We have a single affinity mask for the entire
> set, but what I think we want is an one affinity mask for each
> nr_io_queues. The irq_create_affinity_mask should then create an array
> of cpumasks based on nr_vecs..
Nah, this is Thomas' creating abuse of the cpumask type. Every bit set
in the affinity_mask means this is a cpu we allocate a vector / queue to.
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 4/7] blk-mq: allow the driver to pass in an affinity mask
Date: Thu, 1 Sep 2016 10:46:24 +0200 [thread overview]
Message-ID: <20160901084624.GC4115@lst.de> (raw)
In-Reply-To: <20160831163852.GB5598@localhost.localdomain>
On Wed, Aug 31, 2016@12:38:53PM -0400, Keith Busch wrote:
> This can't be right. We have a single affinity mask for the entire
> set, but what I think we want is an one affinity mask for each
> nr_io_queues. The irq_create_affinity_mask should then create an array
> of cpumasks based on nr_vecs..
Nah, this is Thomas' creating abuse of the cpumask type. Every bit set
in the affinity_mask means this is a cpu we allocate a vector / queue to.
next prev parent reply other threads:[~2016-09-01 8:46 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 10:53 blk-mq: allow passing in an external queue mapping V2 Christoph Hellwig
2016-08-29 10:53 ` Christoph Hellwig
2016-08-29 10:53 ` [PATCH 1/7] blk-mq: don't redistribute hardware queues on a CPU hotplug event Christoph Hellwig
2016-08-29 10:53 ` Christoph Hellwig
2016-08-29 10:53 ` [PATCH 2/7] blk-mq: only allocate a single mq_map per tag_set Christoph Hellwig
2016-08-29 10:53 ` Christoph Hellwig
2016-08-29 10:53 ` [PATCH 3/7] blk-mq: remove ->map_queue Christoph Hellwig
2016-08-29 10:53 ` Christoph Hellwig
2016-08-29 10:53 ` [PATCH 4/7] blk-mq: allow the driver to pass in an affinity mask Christoph Hellwig
2016-08-29 10:53 ` Christoph Hellwig
2016-08-31 16:38 ` Keith Busch
2016-08-31 16:38 ` Keith Busch
2016-09-01 8:46 ` Christoph Hellwig [this message]
2016-09-01 8:46 ` Christoph Hellwig
2016-09-01 14:24 ` Keith Busch
2016-09-01 14:24 ` Keith Busch
2016-09-01 23:30 ` Keith Busch
2016-09-01 23:30 ` Keith Busch
2016-09-05 19:48 ` Christoph Hellwig
2016-09-05 19:48 ` Christoph Hellwig
2016-09-06 14:39 ` Keith Busch
2016-09-06 14:39 ` Keith Busch
2016-09-06 16:50 ` Christoph Hellwig
2016-09-06 16:50 ` Christoph Hellwig
2016-09-06 17:30 ` Keith Busch
2016-09-06 17:30 ` Keith Busch
2016-09-07 15:38 ` Thomas Gleixner
2016-09-07 15:38 ` Thomas Gleixner
2016-08-29 10:53 ` [PATCH 5/7] nvme: switch to use pci_alloc_irq_vectors Christoph Hellwig
2016-08-29 10:53 ` Christoph Hellwig
2016-08-29 10:53 ` [PATCH 6/7] nvme: remove the post_scan callout Christoph Hellwig
2016-08-29 10:53 ` Christoph Hellwig
2016-08-29 10:53 ` [PATCH 7/7] blk-mq: get rid of the cpumask in struct blk_mq_tags Christoph Hellwig
2016-08-29 10:53 ` Christoph Hellwig
2016-08-30 23:28 ` blk-mq: allow passing in an external queue mapping V2 Keith Busch
2016-08-30 23:28 ` Keith Busch
2016-09-01 8:45 ` Christoph Hellwig
2016-09-01 8:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160901084624.GC4115@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.