From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Sascha Hauer <kernel@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/9] mtd: nand: Create a NAND reset function
Date: Fri, 9 Sep 2016 14:26:35 +0200 [thread overview]
Message-ID: <20160909142635.23a8c865@bbrezillon> (raw)
In-Reply-To: <CAOMZO5DfSU5rhf45Vcs7Sit=v2FdQtm=nhdfstZdYwizP6C-=w@mail.gmail.com>
On Fri, 9 Sep 2016 09:15:52 -0300
Fabio Estevam <festevam@gmail.com> wrote:
> Hi Sascha,
>
> On Fri, Sep 9, 2016 at 9:05 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> > /**
> > + * nand_reset - Reset and initialize a NAND device
> > + * @chip: The NAND chip
> > + *
> > + * Returns 0 for success or negative error code otherwise
> > + */
> > +int nand_reset(struct nand_chip *chip)
> > +{
> > + chip->cmdfunc(&chip->mtd, NAND_CMD_RESET, -1, -1);
> > +
> > + return 0;
>
> It always return 0 here, so the comment and code do not match.
Not sure this is a big problem, because the function is updated in
patch 6 and after that it can return an error.
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/9] mtd: nand: Create a NAND reset function
Date: Fri, 9 Sep 2016 14:26:35 +0200 [thread overview]
Message-ID: <20160909142635.23a8c865@bbrezillon> (raw)
In-Reply-To: <CAOMZO5DfSU5rhf45Vcs7Sit=v2FdQtm=nhdfstZdYwizP6C-=w@mail.gmail.com>
On Fri, 9 Sep 2016 09:15:52 -0300
Fabio Estevam <festevam@gmail.com> wrote:
> Hi Sascha,
>
> On Fri, Sep 9, 2016 at 9:05 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> > /**
> > + * nand_reset - Reset and initialize a NAND device
> > + * @chip: The NAND chip
> > + *
> > + * Returns 0 for success or negative error code otherwise
> > + */
> > +int nand_reset(struct nand_chip *chip)
> > +{
> > + chip->cmdfunc(&chip->mtd, NAND_CMD_RESET, -1, -1);
> > +
> > + return 0;
>
> It always return 0 here, so the comment and code do not match.
Not sure this is a big problem, because the function is updated in
patch 6 and after that it can return an error.
next prev parent reply other threads:[~2016-09-09 12:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 12:05 [PATCH v4] mtd: nand: automate NAND timings selection Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 1/9] mtd: nand: Create a NAND reset function Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:15 ` Fabio Estevam
2016-09-09 12:15 ` Fabio Estevam
2016-09-09 12:26 ` Boris Brezillon [this message]
2016-09-09 12:26 ` Boris Brezillon
2016-09-09 19:24 ` Uwe Kleine-König
2016-09-09 19:24 ` Uwe Kleine-König
2016-09-09 12:05 ` [PATCH 2/9] mtd: nand: Introduce nand_data_interface Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 3/9] mtd: nand: convert ONFI mode into data interface Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 4/9] mtd: nand: Add function to convert ONFI mode to data_interface Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:35 ` Boris Brezillon
2016-09-09 12:35 ` Boris Brezillon
2016-09-12 6:35 ` Sascha Hauer
2016-09-12 6:35 ` Sascha Hauer
2016-09-12 18:18 ` Boris Brezillon
2016-09-12 18:18 ` Boris Brezillon
2016-09-09 12:05 ` [PATCH 5/9] mtd: nand: Expose data interface for ONFI mode 0 Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 6/9] mtd: nand: automate NAND timings selection Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 7/9] mtd: nand: sunxi: switch from manual to automated timing config Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 8/9] mtd: nand: mxc: implement onfi get/set features Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 9/9] mtd: nand: mxc: Add timing setup for v2 controllers Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2016-09-15 8:32 [PATCH v4] mtd: nand: automate NAND timings selection Sascha Hauer
2016-09-15 8:32 ` [PATCH 1/9] mtd: nand: Create a NAND reset function Sascha Hauer
2016-09-15 8:32 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909142635.23a8c865@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.