From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH 4/9] mtd: nand: Add function to convert ONFI mode to data_interface
Date: Fri, 9 Sep 2016 14:35:22 +0200 [thread overview]
Message-ID: <20160909143522.6a3b6975@bbrezillon> (raw)
In-Reply-To: <1473422712-12359-5-git-send-email-s.hauer@pengutronix.de>
On Fri, 9 Sep 2016 14:05:07 +0200
Sascha Hauer <s.hauer@pengutronix.de> wrote:
> onfi_init_data_interface() initializes a data interface with
> values from a given ONFI mode.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/mtd/nand/nand_timings.c | 16 ++++++++++++++++
> include/linux/mtd/nand.h | 2 ++
> 2 files changed, 18 insertions(+)
>
> diff --git a/drivers/mtd/nand/nand_timings.c b/drivers/mtd/nand/nand_timings.c
> index 9af2ebc..ece4ff2 100644
> --- a/drivers/mtd/nand/nand_timings.c
> +++ b/drivers/mtd/nand/nand_timings.c
> @@ -269,3 +269,19 @@ const struct nand_sdr_timings *onfi_async_timing_mode_to_sdr_timings(int mode)
> return &onfi_sdr_timings[mode].timings.sdr;
> }
> EXPORT_SYMBOL(onfi_async_timing_mode_to_sdr_timings);
> +
> +/**
> + * onfi_init_data_interface - [NAND Interface] Initialize a data interface from
> + * given ONFI mode
> + * @iface: The data interface to be initialized
> + * @mode: The ONFI timing mode
> + */
> +int onfi_init_data_interface(struct nand_data_interface *iface, int mode)
Can we choose a more future proof prototype (like the one I suggested)
for this function. Passing the nand_chip will later allow to extract
extended timings (tR, tPROG, tCCS, ...) from the param page, and
passing the interface type makes it compatible with DDR mode.
> +{
> + if (mode < 0 || mode >= ARRAY_SIZE(onfi_sdr_timings))
> + return -EINVAL;
> +
> + *iface = onfi_sdr_timings[mode];
> +
> + return 0;
> +}
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index f305bed..0044fac 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
> @@ -1104,6 +1104,8 @@ static inline int onfi_get_sync_timing_mode(struct nand_chip *chip)
> return le16_to_cpu(chip->onfi_params.src_sync_timing_mode);
> }
>
> +int onfi_init_data_interface(struct nand_data_interface *iface, int onfi_mode);
> +
> /*
> * Check if it is a SLC nand.
> * The !nand_is_slc() can be used to check the MLC/TLC nand chips.
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/9] mtd: nand: Add function to convert ONFI mode to data_interface
Date: Fri, 9 Sep 2016 14:35:22 +0200 [thread overview]
Message-ID: <20160909143522.6a3b6975@bbrezillon> (raw)
In-Reply-To: <1473422712-12359-5-git-send-email-s.hauer@pengutronix.de>
On Fri, 9 Sep 2016 14:05:07 +0200
Sascha Hauer <s.hauer@pengutronix.de> wrote:
> onfi_init_data_interface() initializes a data interface with
> values from a given ONFI mode.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/mtd/nand/nand_timings.c | 16 ++++++++++++++++
> include/linux/mtd/nand.h | 2 ++
> 2 files changed, 18 insertions(+)
>
> diff --git a/drivers/mtd/nand/nand_timings.c b/drivers/mtd/nand/nand_timings.c
> index 9af2ebc..ece4ff2 100644
> --- a/drivers/mtd/nand/nand_timings.c
> +++ b/drivers/mtd/nand/nand_timings.c
> @@ -269,3 +269,19 @@ const struct nand_sdr_timings *onfi_async_timing_mode_to_sdr_timings(int mode)
> return &onfi_sdr_timings[mode].timings.sdr;
> }
> EXPORT_SYMBOL(onfi_async_timing_mode_to_sdr_timings);
> +
> +/**
> + * onfi_init_data_interface - [NAND Interface] Initialize a data interface from
> + * given ONFI mode
> + * @iface: The data interface to be initialized
> + * @mode: The ONFI timing mode
> + */
> +int onfi_init_data_interface(struct nand_data_interface *iface, int mode)
Can we choose a more future proof prototype (like the one I suggested)
for this function. Passing the nand_chip will later allow to extract
extended timings (tR, tPROG, tCCS, ...) from the param page, and
passing the interface type makes it compatible with DDR mode.
> +{
> + if (mode < 0 || mode >= ARRAY_SIZE(onfi_sdr_timings))
> + return -EINVAL;
> +
> + *iface = onfi_sdr_timings[mode];
> +
> + return 0;
> +}
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index f305bed..0044fac 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
> @@ -1104,6 +1104,8 @@ static inline int onfi_get_sync_timing_mode(struct nand_chip *chip)
> return le16_to_cpu(chip->onfi_params.src_sync_timing_mode);
> }
>
> +int onfi_init_data_interface(struct nand_data_interface *iface, int onfi_mode);
> +
> /*
> * Check if it is a SLC nand.
> * The !nand_is_slc() can be used to check the MLC/TLC nand chips.
next prev parent reply other threads:[~2016-09-09 12:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 12:05 [PATCH v4] mtd: nand: automate NAND timings selection Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 1/9] mtd: nand: Create a NAND reset function Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:15 ` Fabio Estevam
2016-09-09 12:15 ` Fabio Estevam
2016-09-09 12:26 ` Boris Brezillon
2016-09-09 12:26 ` Boris Brezillon
2016-09-09 19:24 ` Uwe Kleine-König
2016-09-09 19:24 ` Uwe Kleine-König
2016-09-09 12:05 ` [PATCH 2/9] mtd: nand: Introduce nand_data_interface Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 3/9] mtd: nand: convert ONFI mode into data interface Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 4/9] mtd: nand: Add function to convert ONFI mode to data_interface Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:35 ` Boris Brezillon [this message]
2016-09-09 12:35 ` Boris Brezillon
2016-09-12 6:35 ` Sascha Hauer
2016-09-12 6:35 ` Sascha Hauer
2016-09-12 18:18 ` Boris Brezillon
2016-09-12 18:18 ` Boris Brezillon
2016-09-09 12:05 ` [PATCH 5/9] mtd: nand: Expose data interface for ONFI mode 0 Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 6/9] mtd: nand: automate NAND timings selection Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 7/9] mtd: nand: sunxi: switch from manual to automated timing config Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 8/9] mtd: nand: mxc: implement onfi get/set features Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
2016-09-09 12:05 ` [PATCH 9/9] mtd: nand: mxc: Add timing setup for v2 controllers Sascha Hauer
2016-09-09 12:05 ` Sascha Hauer
-- strict thread matches above, loose matches on Subject: below --
2016-09-15 8:32 [PATCH v4] mtd: nand: automate NAND timings selection Sascha Hauer
2016-09-15 8:32 ` [PATCH 4/9] mtd: nand: Add function to convert ONFI mode to data_interface Sascha Hauer
2016-09-15 8:32 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909143522.6a3b6975@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.