All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	punit.agrawal-5wv7dgnIgG8@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v6 00/20] Generic DT bindings for PCI IOMMUs and ARM SMMU
Date: Fri, 9 Sep 2016 18:37:36 +0100	[thread overview]
Message-ID: <20160909173736.GF11418@arm.com> (raw)
In-Reply-To: <cover.1473173789.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>

Hi Robin,

On Tue, Sep 06, 2016 at 04:33:33PM +0100, Robin Murphy wrote:
> Here's v6 to address last week's comments. For the sake of honesty I've
> left Lorenzo's tested-by off everything I've changed since, and Eric's
> reviewed-by off patch 19 having non-trivially reworked the guts of it.
> 
> Patch 20 is new, but as it's currently a solution waiting for a problem
> as far as we're aware, oughtn't to get in the way; hopefully the rest is
> in good shape for 4.9 now.
> 
> Branch here, based on Will's iommu/devel queue:
> 
> git://linux-arm.org/linux-rm iommu/generic-v6

I'm pretty happy with this (modulo the binding docs update etc we
discussed off list), however I'm seeing an allmodconfig build failure
with this applied. Error below.

Please can you take a look and send a fixup patch?

Cheers,

Will

--->8

In file included from drivers/gpu/drm/exynos/exynos_drm_drv.c:33:0:
drivers/gpu/drm/exynos/exynos_drm_iommu.h: In function ‘__exynos_iommu_create_mapping’:
drivers/gpu/drm/exynos/exynos_drm_iommu.h:69:8: error: too few arguments to function ‘iommu_dma_init_domain’
  ret = iommu_dma_init_domain(domain, start, size);
        ^
In file included from drivers/gpu/drm/exynos/exynos_drm_iommu.h:53:0,
                 from drivers/gpu/drm/exynos/exynos_drm_drv.c:33:
./include/linux/dma-iommu.h:33:5: note: declared here
 int iommu_dma_init_domain(struct iommu_domain *domain, dma_addr_t base,
     ^
make[4]: *** [drivers/gpu/drm/exynos/exynos_drm_drv.o] Error 1
make[3]: *** [drivers/gpu/drm/exynos] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [drivers/gpu/drm] Error 2
make[1]: *** [drivers/gpu] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 00/20] Generic DT bindings for PCI IOMMUs and ARM SMMU
Date: Fri, 9 Sep 2016 18:37:36 +0100	[thread overview]
Message-ID: <20160909173736.GF11418@arm.com> (raw)
In-Reply-To: <cover.1473173789.git.robin.murphy@arm.com>

Hi Robin,

On Tue, Sep 06, 2016 at 04:33:33PM +0100, Robin Murphy wrote:
> Here's v6 to address last week's comments. For the sake of honesty I've
> left Lorenzo's tested-by off everything I've changed since, and Eric's
> reviewed-by off patch 19 having non-trivially reworked the guts of it.
> 
> Patch 20 is new, but as it's currently a solution waiting for a problem
> as far as we're aware, oughtn't to get in the way; hopefully the rest is
> in good shape for 4.9 now.
> 
> Branch here, based on Will's iommu/devel queue:
> 
> git://linux-arm.org/linux-rm iommu/generic-v6

I'm pretty happy with this (modulo the binding docs update etc we
discussed off list), however I'm seeing an allmodconfig build failure
with this applied. Error below.

Please can you take a look and send a fixup patch?

Cheers,

Will

--->8

In file included from drivers/gpu/drm/exynos/exynos_drm_drv.c:33:0:
drivers/gpu/drm/exynos/exynos_drm_iommu.h: In function ?__exynos_iommu_create_mapping?:
drivers/gpu/drm/exynos/exynos_drm_iommu.h:69:8: error: too few arguments to function ?iommu_dma_init_domain?
  ret = iommu_dma_init_domain(domain, start, size);
        ^
In file included from drivers/gpu/drm/exynos/exynos_drm_iommu.h:53:0,
                 from drivers/gpu/drm/exynos/exynos_drm_drv.c:33:
./include/linux/dma-iommu.h:33:5: note: declared here
 int iommu_dma_init_domain(struct iommu_domain *domain, dma_addr_t base,
     ^
make[4]: *** [drivers/gpu/drm/exynos/exynos_drm_drv.o] Error 1
make[3]: *** [drivers/gpu/drm/exynos] Error 2
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [drivers/gpu/drm] Error 2
make[1]: *** [drivers/gpu] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2

  parent reply	other threads:[~2016-09-09 17:37 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06 15:33 [PATCH v6 00/20] Generic DT bindings for PCI IOMMUs and ARM SMMU Robin Murphy
2016-09-06 15:33 ` Robin Murphy
     [not found] ` <cover.1473173789.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2016-09-06 15:33   ` [PATCH v6 01/20] Docs: dt: add PCI IOMMU map bindings Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 02/20] of/irq: Break out msi-map lookup (again) Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 03/20] iommu/of: Handle iommu-map property for PCI Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 04/20] iommu/of: Introduce iommu_fwspec Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 05/20] iommu/arm-smmu: Implement of_xlate() for SMMUv3 Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 06/20] iommu/arm-smmu: Support non-PCI devices with SMMUv3 Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 07/20] iommu/arm-smmu: Set PRIVCFG in stage 1 STEs Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 08/20] iommu/arm-smmu: Handle stream IDs more dynamically Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 09/20] iommu/arm-smmu: Consolidate stream map entry state Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 10/20] iommu/arm-smmu: Keep track of S2CR state Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 11/20] iommu/arm-smmu: Refactor mmu-masters handling Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 12/20] iommu/arm-smmu: Streamline SMMU data lookups Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 13/20] iommu/arm-smmu: Add a stream map entry iterator Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 14/20] iommu/arm-smmu: Intelligent SMR allocation Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 15/20] iommu/arm-smmu: Convert to iommu_fwspec Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 16/20] Docs: dt: document ARM SMMU generic binding usage Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 17/20] iommu/arm-smmu: Wire up generic configuration support Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 18/20] iommu/arm-smmu: Set domain geometry Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33   ` [PATCH v6 19/20] iommu/dma: Add support for mapping MSIs Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-06 15:33     ` Robin Murphy
     [not found]     ` <2da5fca62886afd46cd2a5f7da1da872ee4a833d.1473173789.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2016-09-07  9:55       ` [PATCH v6.1] " Robin Murphy
2016-09-07  9:55         ` Robin Murphy
2016-09-07  9:55         ` Robin Murphy
     [not found]         ` <33fb440d91a5fe8c3e7dc8a5e12d83a5253911dd.1473242018.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2016-09-09 14:38           ` Thomas Gleixner
2016-09-09 14:38             ` Thomas Gleixner
2016-09-09 14:38             ` Thomas Gleixner
2016-09-09 14:42           ` Marc Zyngier
2016-09-09 14:42             ` Marc Zyngier
2016-09-09 14:42             ` Marc Zyngier
2016-09-06 15:33   ` [PATCH v6 20/20] iommu/dma: Avoid PCI host bridge windows Robin Murphy
2016-09-06 15:33     ` Robin Murphy
2016-09-09 17:37   ` Will Deacon [this message]
2016-09-09 17:37     ` [PATCH v6 00/20] Generic DT bindings for PCI IOMMUs and ARM SMMU Will Deacon
2016-09-09 18:17   ` [PATCH 21/20] drm/exynos: Fix iommu_dma_init_domain prototype change Robin Murphy
2016-09-09 18:17     ` Robin Murphy
     [not found]     ` <47cdafe035630f29aa1e8ff121c5a5306a2f1eb2.1473444220.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2016-09-12  9:18       ` Will Deacon
2016-09-12  9:18         ` Will Deacon
2016-09-09 18:17   ` [PATCH 22/20] iommu/arm-smmu: Fall back to global bypass Robin Murphy
2016-09-09 18:17     ` Robin Murphy
     [not found]     ` <9c467662ca0fb562cff6d5c9443d77eacb257060.1473443407.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2016-09-12  9:12       ` Will Deacon
2016-09-12  9:12         ` Will Deacon
2016-09-09 18:17   ` [PATCH 4.5/20] Docs: dt: document ARM SMMUv3 generic binding usage Robin Murphy
2016-09-09 18:17     ` Robin Murphy
     [not found]     ` <6067fc2b12b3bc681687753eedd941c8244c22fa.1473443407.git.robin.murphy-5wv7dgnIgG8@public.gmane.org>
2016-09-12  9:16       ` Will Deacon
2016-09-12  9:16         ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160909173736.GF11418@arm.com \
    --to=will.deacon-5wv7dgnigg8@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=punit.agrawal-5wv7dgnIgG8@public.gmane.org \
    --cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
    --cc=thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.