* [Qemu-devel] [PATCH] virtio-gpu-pci: tag as not hotpluggable
@ 2016-09-08 7:17 Gerd Hoffmann
2016-09-08 9:08 ` Marc-André Lureau
2016-09-09 18:16 ` Michael S. Tsirkin
0 siblings, 2 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2016-09-08 7:17 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, Michael S. Tsirkin
We can't hotplug display adapters in qemu, tag virtio-gpu-pci
accordingly (virtio-vga already has this).
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/virtio-gpu-pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/virtio-gpu-pci.c b/hw/display/virtio-gpu-pci.c
index 34a724c..ef92c4a 100644
--- a/hw/display/virtio-gpu-pci.c
+++ b/hw/display/virtio-gpu-pci.c
@@ -48,6 +48,7 @@ static void virtio_gpu_pci_class_init(ObjectClass *klass, void *data)
set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
dc->props = virtio_gpu_pci_properties;
+ dc->hotpluggable = false;
k->realize = virtio_gpu_pci_realize;
pcidev_k->class_id = PCI_CLASS_DISPLAY_OTHER;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-gpu-pci: tag as not hotpluggable
2016-09-08 7:17 [Qemu-devel] [PATCH] virtio-gpu-pci: tag as not hotpluggable Gerd Hoffmann
@ 2016-09-08 9:08 ` Marc-André Lureau
2016-09-09 18:16 ` Michael S. Tsirkin
1 sibling, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2016-09-08 9:08 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel; +Cc: Michael S. Tsirkin
On Thu, Sep 8, 2016 at 11:29 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
> We can't hotplug display adapters in qemu, tag virtio-gpu-pci
> accordingly (virtio-vga already has this).
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
> hw/display/virtio-gpu-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/display/virtio-gpu-pci.c b/hw/display/virtio-gpu-pci.c
> index 34a724c..ef92c4a 100644
> --- a/hw/display/virtio-gpu-pci.c
> +++ b/hw/display/virtio-gpu-pci.c
> @@ -48,6 +48,7 @@ static void virtio_gpu_pci_class_init(ObjectClass
> *klass, void *data)
>
> set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
> dc->props = virtio_gpu_pci_properties;
> + dc->hotpluggable = false;
> k->realize = virtio_gpu_pci_realize;
> pcidev_k->class_id = PCI_CLASS_DISPLAY_OTHER;
> }
> --
> 1.8.3.1
>
>
> --
Marc-André Lureau
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-gpu-pci: tag as not hotpluggable
2016-09-08 7:17 [Qemu-devel] [PATCH] virtio-gpu-pci: tag as not hotpluggable Gerd Hoffmann
2016-09-08 9:08 ` Marc-André Lureau
@ 2016-09-09 18:16 ` Michael S. Tsirkin
2016-09-12 7:45 ` Gerd Hoffmann
1 sibling, 1 reply; 4+ messages in thread
From: Michael S. Tsirkin @ 2016-09-09 18:16 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
On Thu, Sep 08, 2016 at 09:17:17AM +0200, Gerd Hoffmann wrote:
> We can't hotplug display adapters in qemu, tag virtio-gpu-pci
> accordingly (virtio-vga already has this).
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
I assume you merged this?
> ---
> hw/display/virtio-gpu-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/display/virtio-gpu-pci.c b/hw/display/virtio-gpu-pci.c
> index 34a724c..ef92c4a 100644
> --- a/hw/display/virtio-gpu-pci.c
> +++ b/hw/display/virtio-gpu-pci.c
> @@ -48,6 +48,7 @@ static void virtio_gpu_pci_class_init(ObjectClass *klass, void *data)
>
> set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
> dc->props = virtio_gpu_pci_properties;
> + dc->hotpluggable = false;
> k->realize = virtio_gpu_pci_realize;
> pcidev_k->class_id = PCI_CLASS_DISPLAY_OTHER;
> }
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-gpu-pci: tag as not hotpluggable
2016-09-09 18:16 ` Michael S. Tsirkin
@ 2016-09-12 7:45 ` Gerd Hoffmann
0 siblings, 0 replies; 4+ messages in thread
From: Gerd Hoffmann @ 2016-09-12 7:45 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel
On Fr, 2016-09-09 at 21:16 +0300, Michael S. Tsirkin wrote:
> On Thu, Sep 08, 2016 at 09:17:17AM +0200, Gerd Hoffmann wrote:
> > We can't hotplug display adapters in qemu, tag virtio-gpu-pci
> > accordingly (virtio-vga already has this).
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
>
> I assume you merged this?
s/merged/will merged/ -> Yes.
cheers,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-12 7:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-08 7:17 [Qemu-devel] [PATCH] virtio-gpu-pci: tag as not hotpluggable Gerd Hoffmann
2016-09-08 9:08 ` Marc-André Lureau
2016-09-09 18:16 ` Michael S. Tsirkin
2016-09-12 7:45 ` Gerd Hoffmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.