From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: linux-nvdimm@lists.01.org, mawilcox@microsoft.com,
hughd@google.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, akpm@linux-foundation.org,
kirill.shutemov@linux.intel.com
Subject: Re: [PATCH 1/2] shmem: fix tmpfs to handle the huge= option properly
Date: Mon, 12 Sep 2016 12:59:00 +0300 [thread overview]
Message-ID: <20160912095900.GA23346@node.shutemov.name> (raw)
In-Reply-To: <1473459863-11287-2-git-send-email-toshi.kani@hpe.com>
On Fri, Sep 09, 2016 at 04:24:22PM -0600, Toshi Kani wrote:
> shmem_get_unmapped_area() checks SHMEM_SB(sb)->huge incorrectly,
> which leads to a reversed effect of "huge=" mount option.
>
> Fix the check in shmem_get_unmapped_area().
>
> Note, the default value of SHMEM_SB(sb)->huge remains as
> SHMEM_HUGE_NEVER. User will need to specify "huge=" option to
> enable huge page mappings.
>
> Reported-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Hugh Dickins <hughd@google.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: akpm@linux-foundation.org, dan.j.williams@intel.com,
mawilcox@microsoft.com, hughd@google.com,
kirill.shutemov@linux.intel.com, linux-nvdimm@lists.01.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] shmem: fix tmpfs to handle the huge= option properly
Date: Mon, 12 Sep 2016 12:59:00 +0300 [thread overview]
Message-ID: <20160912095900.GA23346@node.shutemov.name> (raw)
In-Reply-To: <1473459863-11287-2-git-send-email-toshi.kani@hpe.com>
On Fri, Sep 09, 2016 at 04:24:22PM -0600, Toshi Kani wrote:
> shmem_get_unmapped_area() checks SHMEM_SB(sb)->huge incorrectly,
> which leads to a reversed effect of "huge=" mount option.
>
> Fix the check in shmem_get_unmapped_area().
>
> Note, the default value of SHMEM_SB(sb)->huge remains as
> SHMEM_HUGE_NEVER. User will need to specify "huge=" option to
> enable huge page mappings.
>
> Reported-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Hugh Dickins <hughd@google.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: akpm@linux-foundation.org, dan.j.williams@intel.com,
mawilcox@microsoft.com, hughd@google.com,
kirill.shutemov@linux.intel.com, linux-nvdimm@ml01.01.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] shmem: fix tmpfs to handle the huge= option properly
Date: Mon, 12 Sep 2016 12:59:00 +0300 [thread overview]
Message-ID: <20160912095900.GA23346@node.shutemov.name> (raw)
In-Reply-To: <1473459863-11287-2-git-send-email-toshi.kani@hpe.com>
On Fri, Sep 09, 2016 at 04:24:22PM -0600, Toshi Kani wrote:
> shmem_get_unmapped_area() checks SHMEM_SB(sb)->huge incorrectly,
> which leads to a reversed effect of "huge=" mount option.
>
> Fix the check in shmem_get_unmapped_area().
>
> Note, the default value of SHMEM_SB(sb)->huge remains as
> SHMEM_HUGE_NEVER. User will need to specify "huge=" option to
> enable huge page mappings.
>
> Reported-by: Hillf Danton <hillf.zj@alibaba-inc.com>
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Hugh Dickins <hughd@google.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
--
Kirill A. Shutemov
next prev parent reply other threads:[~2016-09-12 9:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 22:24 [PATCH 0/2] refactor shmem_get_unmapped_area() Toshi Kani
2016-09-09 22:24 ` Toshi Kani
2016-09-09 22:24 ` Toshi Kani
2016-09-09 22:24 ` [PATCH 1/2] shmem: fix tmpfs to handle the huge= option properly Toshi Kani
2016-09-09 22:24 ` Toshi Kani
2016-09-09 22:24 ` Toshi Kani
2016-09-12 9:59 ` Kirill A. Shutemov [this message]
2016-09-12 9:59 ` Kirill A. Shutemov
2016-09-12 9:59 ` Kirill A. Shutemov
2016-09-22 10:58 ` Aneesh Kumar K.V
2016-09-22 10:58 ` Aneesh Kumar K.V
2016-09-22 10:58 ` Aneesh Kumar K.V
2016-09-23 2:33 ` Hugh Dickins
2016-09-23 2:33 ` Hugh Dickins
2016-09-23 2:33 ` Hugh Dickins
2016-09-09 22:24 ` [PATCH 2/2] shmem: call __thp_get_unmapped_area to alloc a pmd-aligned addr Toshi Kani
2016-09-09 22:24 ` Toshi Kani
2016-09-09 22:24 ` Toshi Kani
2016-09-12 10:02 ` Kirill A. Shutemov
2016-09-12 10:02 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160912095900.GA23346@node.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mawilcox@microsoft.com \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.