From: David Gibson <david@gibson.dropbear.id.au>
To: Thomas Huth <thuth@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/5] spapr_vscsi: convert to trace framework instead of DPRINTF
Date: Thu, 15 Sep 2016 10:09:59 +1000 [thread overview]
Message-ID: <20160915000959.GA15077@voom.fritz.box> (raw)
In-Reply-To: <71be7db9-c6b4-5f1a-f99e-2f4a9e8986ad@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]
On Wed, Sep 14, 2016 at 09:56:47PM +0200, Thomas Huth wrote:
> On 14.09.2016 20:48, Laurent Vivier wrote:
> > Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> > ---
> > hw/scsi/spapr_vscsi.c | 89 +++++++++++++++++++++------------------------------
> > hw/scsi/trace-events | 27 ++++++++++++++++
> > 2 files changed, 63 insertions(+), 53 deletions(-)
> >
> > diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
> > index 8fbd50f..29fef90 100644
> > --- a/hw/scsi/spapr_vscsi.c
> > +++ b/hw/scsi/spapr_vscsi.c
>
> While you're at it: There is a stray fprintf statement at the beginning
> of vscsi_process_tsk_mgmt() which is rather a debug statement than
> really something that should be printed always ... could you please turn
> that into a trace event, too?
That would be a good idea, but I'd prefer to see it as a follow up patch.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-09-15 0:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 18:48 [Qemu-devel] [PATCH 0/5] spapr: convert SPAPR devices to trace framework Laurent Vivier
2016-09-14 18:48 ` [Qemu-devel] [PATCH 1/5] spapr_drc: convert to trace framework instead of DPRINTF Laurent Vivier
2016-09-14 19:04 ` Eric Blake
2016-09-14 18:48 ` [Qemu-devel] [PATCH 2/5] spapr_rtas: " Laurent Vivier
2016-09-14 19:11 ` Eric Blake
2016-09-14 18:48 ` [Qemu-devel] [PATCH 3/5] spapr_vio: " Laurent Vivier
2016-09-14 19:48 ` Eric Blake
2016-09-14 18:48 ` [Qemu-devel] [PATCH 4/5] spapr_llan: " Laurent Vivier
2016-09-14 20:07 ` Eric Blake
2016-09-14 18:48 ` [Qemu-devel] [PATCH 5/5] spapr_vscsi: " Laurent Vivier
2016-09-14 19:56 ` Thomas Huth
2016-09-15 0:09 ` David Gibson [this message]
2016-09-14 20:09 ` Eric Blake
2016-09-15 0:10 ` David Gibson
2016-09-15 7:37 ` Laurent Vivier
2016-09-15 0:09 ` [Qemu-devel] [PATCH 0/5] spapr: convert SPAPR devices to trace framework David Gibson
2016-09-16 3:04 ` David Gibson
2016-09-16 10:24 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915000959.GA15077@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.