From: Eric Blake <eblake@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>, david@gibson.dropbear.id.au
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/5] spapr_rtas: convert to trace framework instead of DPRINTF
Date: Wed, 14 Sep 2016 14:11:41 -0500 [thread overview]
Message-ID: <80ae56d7-c57d-6afa-bdb2-cf2dd43cedfd@redhat.com> (raw)
In-Reply-To: <1473878907-10477-3-git-send-email-lvivier@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On 09/14/2016 01:48 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> hw/ppc/spapr_rtas.c | 30 ++++++++----------------------
> hw/ppc/trace-events | 9 +++++++++
> 2 files changed, 17 insertions(+), 22 deletions(-)
>
> +++ b/hw/ppc/trace-events
> @@ -57,6 +57,15 @@ spapr_drc_realize_child(uint32_t index, char *childname) "drc: 0x%"PRIx32", chil
> spapr_drc_realize_complete(uint32_t index) "drc: 0x%"PRIx32
> spapr_drc_unrealize(uint32_t index) "drc: 0x%"PRIx32
>
> +# hw/ppc/spapr_rtas.c
> +
> +spapr_rtas_set_indicator_invalid(uint32_t index) "sensor index: 0x%"PRIx32
Same comment about extra newline as on 1/5 (and probably for the whole
series); otherwise:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-09-14 19:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 18:48 [Qemu-devel] [PATCH 0/5] spapr: convert SPAPR devices to trace framework Laurent Vivier
2016-09-14 18:48 ` [Qemu-devel] [PATCH 1/5] spapr_drc: convert to trace framework instead of DPRINTF Laurent Vivier
2016-09-14 19:04 ` Eric Blake
2016-09-14 18:48 ` [Qemu-devel] [PATCH 2/5] spapr_rtas: " Laurent Vivier
2016-09-14 19:11 ` Eric Blake [this message]
2016-09-14 18:48 ` [Qemu-devel] [PATCH 3/5] spapr_vio: " Laurent Vivier
2016-09-14 19:48 ` Eric Blake
2016-09-14 18:48 ` [Qemu-devel] [PATCH 4/5] spapr_llan: " Laurent Vivier
2016-09-14 20:07 ` Eric Blake
2016-09-14 18:48 ` [Qemu-devel] [PATCH 5/5] spapr_vscsi: " Laurent Vivier
2016-09-14 19:56 ` Thomas Huth
2016-09-15 0:09 ` David Gibson
2016-09-14 20:09 ` Eric Blake
2016-09-15 0:10 ` David Gibson
2016-09-15 7:37 ` Laurent Vivier
2016-09-15 0:09 ` [Qemu-devel] [PATCH 0/5] spapr: convert SPAPR devices to trace framework David Gibson
2016-09-16 3:04 ` David Gibson
2016-09-16 10:24 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ae56d7-c57d-6afa-bdb2-cf2dd43cedfd@redhat.com \
--to=eblake@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.