All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] x86/lapic: remove unwanted debugging messages
Date: Thu, 15 Sep 2016 16:07:17 +0100	[thread overview]
Message-ID: <20160915150716.GC2083@work-vm> (raw)
In-Reply-To: <1473949287-31122-1-git-send-email-pbonzini@redhat.com>

* Paolo Bonzini (pbonzini@redhat.com) wrote:
> /me hides in the corner...
> 
> Cc: Dave Gilbert <dgilbert@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/i386/kvm/apic.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c
> index 5d140b9..feb0002 100644
> --- a/hw/i386/kvm/apic.c
> +++ b/hw/i386/kvm/apic.c
> @@ -141,7 +141,6 @@ static void kvm_apic_put(void *data)
>  
>  static void kvm_apic_post_load(APICCommonState *s)
>  {
> -    fprintf(stderr, "%s: Yeh\n", __func__);
>      run_on_cpu(CPU(s->cpu), kvm_apic_put, s);
>  }

Hmm, I think you picked up the debug version we exchanged
privately rather than the one I actually posted which
I'd excised the debug from:
   https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02658.html

I think the only other change was that the one I posted I'd
reformatted kvm_put_apic_state so it wasn't 81 characters long.

Dave

>  
> -- 
> 1.8.3.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

  reply	other threads:[~2016-09-15 15:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 14:21 [Qemu-devel] [PATCH] x86/lapic: remove unwanted debugging messages Paolo Bonzini
2016-09-15 15:07 ` Dr. David Alan Gilbert [this message]
2016-09-15 15:40   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160915150716.GC2083@work-vm \
    --to=dgilbert@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.