* [Qemu-devel] [PATCH] x86/lapic: remove unwanted debugging messages
@ 2016-09-15 14:21 Paolo Bonzini
2016-09-15 15:07 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2016-09-15 14:21 UTC (permalink / raw)
To: qemu-devel; +Cc: Dave Gilbert
/me hides in the corner...
Cc: Dave Gilbert <dgilbert@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/i386/kvm/apic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c
index 5d140b9..feb0002 100644
--- a/hw/i386/kvm/apic.c
+++ b/hw/i386/kvm/apic.c
@@ -141,7 +141,6 @@ static void kvm_apic_put(void *data)
static void kvm_apic_post_load(APICCommonState *s)
{
- fprintf(stderr, "%s: Yeh\n", __func__);
run_on_cpu(CPU(s->cpu), kvm_apic_put, s);
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] x86/lapic: remove unwanted debugging messages
2016-09-15 14:21 [Qemu-devel] [PATCH] x86/lapic: remove unwanted debugging messages Paolo Bonzini
@ 2016-09-15 15:07 ` Dr. David Alan Gilbert
2016-09-15 15:40 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2016-09-15 15:07 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
* Paolo Bonzini (pbonzini@redhat.com) wrote:
> /me hides in the corner...
>
> Cc: Dave Gilbert <dgilbert@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> hw/i386/kvm/apic.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c
> index 5d140b9..feb0002 100644
> --- a/hw/i386/kvm/apic.c
> +++ b/hw/i386/kvm/apic.c
> @@ -141,7 +141,6 @@ static void kvm_apic_put(void *data)
>
> static void kvm_apic_post_load(APICCommonState *s)
> {
> - fprintf(stderr, "%s: Yeh\n", __func__);
> run_on_cpu(CPU(s->cpu), kvm_apic_put, s);
> }
Hmm, I think you picked up the debug version we exchanged
privately rather than the one I actually posted which
I'd excised the debug from:
https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02658.html
I think the only other change was that the one I posted I'd
reformatted kvm_put_apic_state so it wasn't 81 characters long.
Dave
>
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] x86/lapic: remove unwanted debugging messages
2016-09-15 15:07 ` Dr. David Alan Gilbert
@ 2016-09-15 15:40 ` Paolo Bonzini
0 siblings, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2016-09-15 15:40 UTC (permalink / raw)
To: Dr. David Alan Gilbert; +Cc: qemu-devel
On 15/09/2016 17:07, Dr. David Alan Gilbert wrote:
> * Paolo Bonzini (pbonzini@redhat.com) wrote:
>> /me hides in the corner...
>>
>> Cc: Dave Gilbert <dgilbert@redhat.com>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> hw/i386/kvm/apic.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/hw/i386/kvm/apic.c b/hw/i386/kvm/apic.c
>> index 5d140b9..feb0002 100644
>> --- a/hw/i386/kvm/apic.c
>> +++ b/hw/i386/kvm/apic.c
>> @@ -141,7 +141,6 @@ static void kvm_apic_put(void *data)
>>
>> static void kvm_apic_post_load(APICCommonState *s)
>> {
>> - fprintf(stderr, "%s: Yeh\n", __func__);
>> run_on_cpu(CPU(s->cpu), kvm_apic_put, s);
>> }
>
> Hmm, I think you picked up the debug version we exchanged
> privately rather than the one I actually posted which
> I'd excised the debug from:
> https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg02658.html
>
> I think the only other change was that the one I posted I'd
> reformatted kvm_put_apic_state so it wasn't 81 characters long.
Yes, I did. It's me who hides in the corner, not you. :)
Paolo
>
> Dave
>
>>
>> --
>> 1.8.3.1
>>
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-15 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-15 14:21 [Qemu-devel] [PATCH] x86/lapic: remove unwanted debugging messages Paolo Bonzini
2016-09-15 15:07 ` Dr. David Alan Gilbert
2016-09-15 15:40 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.