[PATCH v2] staging: olpc_dcon: Prefer using the BIT macro

[PATCH v2] staging: olpc_dcon: Prefer using the BIT macro

[Anchal Jain]

This patch fix the CHECK
CHECK: Prefer using the BIT macro
detected by checkpatch.pl

Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
	changes in v2:
		-modify commit message
 
 drivers/staging/olpc_dcon/olpc_dcon.h | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h
index 215e7ec..23a48a1 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.h
+++ b/drivers/staging/olpc_dcon/olpc_dcon.h
@@ -9,18 +9,18 @@
 #define DCON_REG_ID		 0
 #define DCON_REG_MODE		 1
 
-#define MODE_PASSTHRU	(1<<0)
-#define MODE_SLEEP	(1<<1)
-#define MODE_SLEEP_AUTO	(1<<2)
-#define MODE_BL_ENABLE	(1<<3)
-#define MODE_BLANK	(1<<4)
-#define MODE_CSWIZZLE	(1<<5)
-#define MODE_COL_AA	(1<<6)
-#define MODE_MONO_LUMA	(1<<7)
-#define MODE_SCAN_INT	(1<<8)
-#define MODE_CLOCKDIV	(1<<9)
-#define MODE_DEBUG	(1<<14)
-#define MODE_SELFTEST	(1<<15)
+#define MODE_PASSTHRU	bit(0)
+#define MODE_SLEEP	bit(1)
+#define MODE_SLEEP_AUTO	bit(2)
+#define MODE_BL_ENABLE	bit(3)
+#define MODE_BLANK	bit(4)
+#define MODE_CSWIZZLE	bit(5)
+#define MODE_COL_AA	bit(6)
+#define MODE_MONO_LUMA	bit(7)
+#define MODE_SCAN_INT	bit(8)
+#define MODE_CLOCKDIV	bit(9)
+#define MODE_DEBUG	bit(14)
+#define MODE_SELFTEST	bit(15)
 
 #define DCON_REG_HRES		0x2
 #define DCON_REG_HTOTAL		0x3
@@ -35,11 +35,11 @@
 #define DCON_REG_MEM_OPT_B	0x42
 
 /* Load Delay Locked Loop (DLL) settings for clock delay */
-#define MEM_DLL_CLOCK_DELAY	(1<<0)
+#define MEM_DLL_CLOCK_DELAY	bit(0)
 /* Memory controller power down function */
-#define MEM_POWER_DOWN		(1<<8)
+#define MEM_POWER_DOWN		bit(8)
 /* Memory controller software reset */
-#define MEM_SOFT_RESET		(1<<0)
+#define MEM_SOFT_RESET		bit(0)
 
 /* Status values */
 
-- 
1.9.1

Re: [PATCH v2] staging: olpc_dcon: Prefer using the BIT macro

[Greg KH]

On Thu, Sep 15, 2016 at 09:18:46PM +0530, Anchal Jain wrote:
> This patch fix the CHECK
> CHECK: Prefer using the BIT macro
> detected by checkpatch.pl
> 
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
> 	changes in v2:
> 		-modify commit message

You're previous commit message was a bit better :)

And again, did you build test this?  Just looking at it, I do not think
it will...

thanks,

greg k-h

Re: [PATCH v2] staging: olpc_dcon: Prefer using the BIT macro

[Anchal Jain]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

>You're previous commit message was a bit better :)
>
>And again, did you build test this?  Just looking at it, I do not think
>it will...
>
>thanks,


I can't understand what should I need to change in commit message


thanks,

On Thu, Sep 15, 2016 at 10:55 PM, Greg KH <gregkh@linuxfoundation.org>
wrote:

> On Thu, Sep 15, 2016 at 09:18:46PM +0530, Anchal Jain wrote:
> > This patch fix the CHECK
> > CHECK: Prefer using the BIT macro
> > detected by checkpatch.pl
> >
> > Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> > ---
> >       changes in v2:
> >               -modify commit message
>
> You're previous commit message was a bit better :)
>
> And again, did you build test this?  Just looking at it, I do not think
> it will...
>
> thanks,
>
> greg k-h
>

[-- Attachment #2: Type: text/html, Size: 1457 bytes --]

Re: [PATCH v2] staging: olpc_dcon: Prefer using the BIT macro

[Greg KH]

On Thu, Sep 15, 2016 at 11:21:33PM +0530, Anchal Jain wrote:
> 
> >You're previous commit message was a bit better :)
> >
> >And again, did you build test this?� Just looking at it, I do not think
> >it will...
> >
> >thanks,
> 
> 
> I can't understand what should I need to change in commit message

Again did you test build this patch?  I'm not going to be able to accept
any patches from you until you show that you are doing this, sorry.

thanks,

greg k-h