* [PATCH] Staging: fbtft: Use !x instead of x == NULL.
@ 2016-09-16 9:02 Sandhya Bankar
2016-09-17 21:27 ` Greg KH
2016-09-17 21:28 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Sandhya Bankar @ 2016-09-16 9:02 UTC (permalink / raw)
To: outreachy-kernel; +Cc: thomas.petazzoni, noralf, gregkh
Use !x instead of x == NULL.
This issue was found by checkpatch.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/fbtft/fbtft_device.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c
index 924abd3..e921183 100755
--- a/drivers/staging/fbtft/fbtft_device.c
+++ b/drivers/staging/fbtft/fbtft_device.c
@@ -1401,7 +1401,7 @@ static int __init fbtft_device_init(void)
long val;
int ret = 0;
- if (name == NULL) {
+ if (!name) {
#ifdef MODULE
pr_err("missing module parameter: 'name'\n");
return -EINVAL;
@@ -1418,14 +1418,14 @@ static int __init fbtft_device_init(void)
/* parse module parameter: gpios */
while ((p_gpio = strsep(&gpios, ","))) {
- if (strchr(p_gpio, ':') == NULL) {
+ if (!strchr(p_gpio, ':')) {
pr_err("error: missing ':' in gpios parameter: %s\n",
p_gpio);
return -EINVAL;
}
p_num = p_gpio;
p_name = strsep(&p_num, ":");
- if (p_name == NULL || p_num == NULL) {
+ if (!p_name || !p_num) {
pr_err("something bad happened parsing gpios parameter: %s\n",
p_gpio);
return -EINVAL;
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Staging: fbtft: Use !x instead of x == NULL.
2016-09-16 9:02 [PATCH] Staging: fbtft: Use !x instead of x == NULL Sandhya Bankar
@ 2016-09-17 21:27 ` Greg KH
2016-09-17 21:28 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-09-17 21:27 UTC (permalink / raw)
To: Sandhya Bankar; +Cc: outreachy-kernel, thomas.petazzoni, noralf
On Fri, Sep 16, 2016 at 02:32:32PM +0530, Sandhya Bankar wrote:
> Use !x instead of x == NULL.
> This issue was found by checkpatch.
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> drivers/staging/fbtft/fbtft_device.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c
> index 924abd3..e921183 100755
How did this file get to be 0755 permissions? What are you using to
edit this? It is a virtual machine somehow?
Please be more careful in the future...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: fbtft: Use !x instead of x == NULL.
2016-09-16 9:02 [PATCH] Staging: fbtft: Use !x instead of x == NULL Sandhya Bankar
2016-09-17 21:27 ` Greg KH
@ 2016-09-17 21:28 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2016-09-17 21:28 UTC (permalink / raw)
To: Sandhya Bankar; +Cc: outreachy-kernel, thomas.petazzoni, noralf
On Fri, Sep 16, 2016 at 02:32:32PM +0530, Sandhya Bankar wrote:
> Use !x instead of x == NULL.
> This issue was found by checkpatch.
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
> ---
> drivers/staging/fbtft/fbtft_device.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fbtft_device.c b/drivers/staging/fbtft/fbtft_device.c
> index 924abd3..e921183 100755
Oh, please fix up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-17 21:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-16 9:02 [PATCH] Staging: fbtft: Use !x instead of x == NULL Sandhya Bankar
2016-09-17 21:27 ` Greg KH
2016-09-17 21:28 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.