From: Peter Chen <hzpeterchen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Vaibhav Hiremath
<vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: "Ulf Hansson"
<ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Peter Chen" <peter.chen-3arQi8VN3Tc@public.gmane.org>,
"Greg Kroah-Hartman"
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
"Alan Stern"
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
"Mark Brown" <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Sebastian Reichel" <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Shawn Guo" <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Dmitry Eremin-Solenikov"
<dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
dwmw3-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Krzysztof Kozłowski"
<k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
"Linux USB List"
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
oscar-Bdbr4918Nnnk1uMJSBkQmQ@public.gmane.org,
"Paweł Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"Arnd Bergmann" <arnd-r2nGTMty4D4@public.gmane.org>,
"linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"Fabio Estevam"
<festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v6 0/8] power: add power sequence library
Date: Mon, 19 Sep 2016 15:46:37 +0800 [thread overview]
Message-ID: <20160919074637.GA10289@b29397-desktop> (raw)
In-Reply-To: <ecbc3c0d-4ce7-758d-7f7d-4b3f3003c1ac-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Mon, Sep 19, 2016 at 01:09:10PM +0530, Vaibhav Hiremath wrote:
>
>
> On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote:
> >[...]
> >
> >>>>>We had an agreement that keep mmc's pwrseq framework unchanging.
> >>>>>Unless Ulf and rob both agree to change.
> >>>>Why 2 separate approach for same problem ?
> >>>>And I see this as possible duplication of code/functionality :)
> >>>How the new kernel compatibles old dts? If we do not need to
> >>>consider this problem, the mmc can try to use power sequence library
> >>>too in future.
> >>
> >>I think we should attempt to get both MMC and USB power seq
> >>come on one agreement, so that it can be reused.
> >That would be nice. Although, to do that you would have to allow some
> >DT bindings to be deprecated in the new generic power seq bindings, as
> >otherwise you would break existing DTBs.
> >
> >I guess that is what Rob was objecting to!?
>
> yeah, thats right.
>
> So lets adopt similar implementation for USB as well instead of
> library, but keeping MMC untouched as of now.
>
> What I am trying to propose here is,
>
> Lets have power-sequence framework (similar to V1 of this series),
> with,
>
> pwrseq: Core framework for power sequence.
> pwrseq_generic/simple: for all generic control, like reset and clock
> pwrseq_emmc: probably duplication of existing code - the idea
> here is, all future code should be using this new
> binding, so that we can deprecate the
> drivers/mmc/core/pwrseq
> pwrseq_arche: The usecase which I am dealing with today, which is more
> complex in nature.
>
> Then the respective drivers can add their drivers (if needed) based on
> complexity.
>
> comments ??
The key point here is DT maintainer (Rob) doesn't agree with adding new node
for power sequence at dts.
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: hzpeterchen@gmail.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 0/8] power: add power sequence library
Date: Mon, 19 Sep 2016 15:46:37 +0800 [thread overview]
Message-ID: <20160919074637.GA10289@b29397-desktop> (raw)
In-Reply-To: <ecbc3c0d-4ce7-758d-7f7d-4b3f3003c1ac@linaro.org>
On Mon, Sep 19, 2016 at 01:09:10PM +0530, Vaibhav Hiremath wrote:
>
>
> On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote:
> >[...]
> >
> >>>>>We had an agreement that keep mmc's pwrseq framework unchanging.
> >>>>>Unless Ulf and rob both agree to change.
> >>>>Why 2 separate approach for same problem ?
> >>>>And I see this as possible duplication of code/functionality :)
> >>>How the new kernel compatibles old dts? If we do not need to
> >>>consider this problem, the mmc can try to use power sequence library
> >>>too in future.
> >>
> >>I think we should attempt to get both MMC and USB power seq
> >>come on one agreement, so that it can be reused.
> >That would be nice. Although, to do that you would have to allow some
> >DT bindings to be deprecated in the new generic power seq bindings, as
> >otherwise you would break existing DTBs.
> >
> >I guess that is what Rob was objecting to!?
>
> yeah, thats right.
>
> So lets adopt similar implementation for USB as well instead of
> library, but keeping MMC untouched as of now.
>
> What I am trying to propose here is,
>
> Lets have power-sequence framework (similar to V1 of this series),
> with,
>
> pwrseq: Core framework for power sequence.
> pwrseq_generic/simple: for all generic control, like reset and clock
> pwrseq_emmc: probably duplication of existing code - the idea
> here is, all future code should be using this new
> binding, so that we can deprecate the
> drivers/mmc/core/pwrseq
> pwrseq_arche: The usecase which I am dealing with today, which is more
> complex in nature.
>
> Then the respective drivers can add their drivers (if needed) based on
> complexity.
>
> comments ??
The key point here is DT maintainer (Rob) doesn't agree with adding new node
for power sequence at dts.
--
Best Regards,
Peter Chen
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <hzpeterchen@gmail.com>
To: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Cc: "Ulf Hansson" <ulf.hansson@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Peter Chen" <peter.chen@nxp.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Mark Brown" <broonie@kernel.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Dmitry Eremin-Solenikov" <dbaryshkov@gmail.com>,
dwmw3@infradead.org, "Mark Rutland" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Krzysztof Kozłowski" <k.kozlowski@samsung.com>,
"Linux USB List" <linux-usb@vger.kernel.org>,
oscar@naiandei.net, "Paweł Moll" <pawel.moll@arm.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Fabio Estevam" <festevam@gmail.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Stephen Boyd" <stephen.boyd@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
troy.kisky@boundarydevices.com, stillcompiling@gmail.com,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
mka@chromium.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 0/8] power: add power sequence library
Date: Mon, 19 Sep 2016 15:46:37 +0800 [thread overview]
Message-ID: <20160919074637.GA10289@b29397-desktop> (raw)
In-Reply-To: <ecbc3c0d-4ce7-758d-7f7d-4b3f3003c1ac@linaro.org>
On Mon, Sep 19, 2016 at 01:09:10PM +0530, Vaibhav Hiremath wrote:
>
>
> On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote:
> >[...]
> >
> >>>>>We had an agreement that keep mmc's pwrseq framework unchanging.
> >>>>>Unless Ulf and rob both agree to change.
> >>>>Why 2 separate approach for same problem ?
> >>>>And I see this as possible duplication of code/functionality :)
> >>>How the new kernel compatibles old dts? If we do not need to
> >>>consider this problem, the mmc can try to use power sequence library
> >>>too in future.
> >>
> >>I think we should attempt to get both MMC and USB power seq
> >>come on one agreement, so that it can be reused.
> >That would be nice. Although, to do that you would have to allow some
> >DT bindings to be deprecated in the new generic power seq bindings, as
> >otherwise you would break existing DTBs.
> >
> >I guess that is what Rob was objecting to!?
>
> yeah, thats right.
>
> So lets adopt similar implementation for USB as well instead of
> library, but keeping MMC untouched as of now.
>
> What I am trying to propose here is,
>
> Lets have power-sequence framework (similar to V1 of this series),
> with,
>
> pwrseq: Core framework for power sequence.
> pwrseq_generic/simple: for all generic control, like reset and clock
> pwrseq_emmc: probably duplication of existing code - the idea
> here is, all future code should be using this new
> binding, so that we can deprecate the
> drivers/mmc/core/pwrseq
> pwrseq_arche: The usecase which I am dealing with today, which is more
> complex in nature.
>
> Then the respective drivers can add their drivers (if needed) based on
> complexity.
>
> comments ??
The key point here is DT maintainer (Rob) doesn't agree with adding new node
for power sequence at dts.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-09-19 7:46 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 9:13 [PATCH v6 0/8] power: add power sequence library Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-15 9:13 ` [PATCH v6 1/8] binding-doc: power: pwrseq-generic: add binding doc for generic " Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-15 9:13 ` Peter Chen
[not found] ` <1471252398-957-2-git-send-email-peter.chen-3arQi8VN3Tc@public.gmane.org>
2016-09-01 8:03 ` Vaibhav Hiremath
2016-09-01 8:03 ` Vaibhav Hiremath
2016-09-01 8:03 ` Vaibhav Hiremath
[not found] ` <6832cc55-831a-1188-4878-bbbf0b3c3be8-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-09-02 1:00 ` Peter Chen
2016-09-02 1:00 ` Peter Chen
2016-09-02 1:00 ` Peter Chen
2016-09-06 6:04 ` Vaibhav Hiremath
2016-09-06 6:04 ` Vaibhav Hiremath
2016-09-06 6:04 ` Vaibhav Hiremath
2016-08-15 9:13 ` [PATCH v6 2/8] power: add " Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-22 6:51 ` Peter Chen
2016-08-22 6:51 ` Peter Chen
2016-08-22 6:51 ` Peter Chen
2016-08-22 10:23 ` Sebastian Reichel
2016-08-22 10:23 ` Sebastian Reichel
2016-08-23 1:25 ` Peter Chen
2016-08-23 1:25 ` Peter Chen
2016-08-23 1:25 ` Peter Chen
2016-09-01 8:02 ` Vaibhav Hiremath
2016-09-01 8:02 ` Vaibhav Hiremath
2016-09-02 1:29 ` Peter Chen
2016-09-02 1:29 ` Peter Chen
2016-08-15 9:13 ` [PATCH v6 4/8] usb: core: add power sequence handling for USB devices Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-22 6:53 ` Peter Chen
2016-08-22 6:53 ` Peter Chen
2016-08-22 16:09 ` Alan Stern
2016-08-22 16:09 ` Alan Stern
2016-08-22 16:09 ` Alan Stern
2016-08-23 3:10 ` Peter Chen
2016-08-23 3:10 ` Peter Chen
2016-08-23 15:37 ` Alan Stern
2016-08-23 15:37 ` Alan Stern
2016-08-23 15:37 ` Alan Stern
2016-09-01 8:02 ` Vaibhav Hiremath
2016-09-01 8:02 ` Vaibhav Hiremath
2016-09-02 1:30 ` Peter Chen
2016-09-02 1:30 ` Peter Chen
2016-08-15 9:13 ` [PATCH v6 5/8] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-15 9:13 ` [PATCH v6 6/8] ARM: dts: imx6qdl: Enable usb node children with <reg> Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-15 9:13 ` Peter Chen
[not found] ` <1471252398-957-1-git-send-email-peter.chen-3arQi8VN3Tc@public.gmane.org>
2016-08-15 9:13 ` [PATCH v6 3/8] binding-doc: usb: usb-device: add optional properties for power sequence Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-15 9:13 ` [PATCH v6 7/8] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-15 9:13 ` [PATCH v6 8/8] ARM: dts: imx6q-evi: Fix onboard hub reset line Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-15 9:13 ` Peter Chen
2016-08-23 10:32 ` [PATCH v6 0/8] power: add power sequence library Vaibhav Hiremath
2016-08-23 10:32 ` Vaibhav Hiremath
2016-08-23 10:32 ` Vaibhav Hiremath
[not found] ` <b1848eb2-9298-9089-ee4d-5356998c6c08-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-08-24 8:53 ` Peter Chen
2016-08-24 8:53 ` Peter Chen
2016-08-24 8:53 ` Peter Chen
2016-08-29 11:10 ` Peter Chen
2016-08-29 11:10 ` Peter Chen
2016-08-31 8:16 ` Vaibhav Hiremath
2016-08-31 8:16 ` Vaibhav Hiremath
[not found] ` <3a45793f-18d9-0688-d2ab-ef79432c473c-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-08-31 9:52 ` Peter Chen
2016-08-31 9:52 ` Peter Chen
2016-08-31 9:52 ` Peter Chen
2016-08-31 16:58 ` Vaibhav Hiremath
2016-08-31 16:58 ` Vaibhav Hiremath
2016-08-31 16:58 ` Vaibhav Hiremath
2016-09-02 1:10 ` Peter Chen
2016-09-02 1:10 ` Peter Chen
2016-09-06 10:18 ` Vaibhav Hiremath
2016-09-06 10:18 ` Vaibhav Hiremath
2016-09-06 10:18 ` Vaibhav Hiremath
2016-09-09 8:47 ` Ulf Hansson
2016-09-09 8:47 ` Ulf Hansson
2016-09-09 8:47 ` Ulf Hansson
2016-09-19 7:39 ` Vaibhav Hiremath
2016-09-19 7:39 ` Vaibhav Hiremath
2016-09-19 7:39 ` Vaibhav Hiremath
[not found] ` <ecbc3c0d-4ce7-758d-7f7d-4b3f3003c1ac-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-09-19 7:46 ` Peter Chen [this message]
2016-09-19 7:46 ` Peter Chen
2016-09-19 7:46 ` Peter Chen
2016-09-19 8:17 ` Vaibhav Hiremath
2016-09-19 8:17 ` Vaibhav Hiremath
2016-09-19 8:17 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919074637.GA10289@b29397-desktop \
--to=hzpeterchen-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dwmw3-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=oscar-Bdbr4918Nnnk1uMJSBkQmQ@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=peter.chen-3arQi8VN3Tc@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org \
--cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.