From: Mark Brown <broonie@kernel.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Doug Anderson <dianders@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
Andy Yan <andy.yan@rock-chips.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization
Date: Thu, 22 Sep 2016 17:47:52 +0100 [thread overview]
Message-ID: <20160922164752.GP7994@sirena.org.uk> (raw)
In-Reply-To: <20160922171217.09a6d13f@bbrezillon>
[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]
On Thu, Sep 22, 2016 at 05:12:17PM +0200, Boris Brezillon wrote:
> +Mark
> I realize Mark has been out of the discussion, and what started as a DT
> problem actually turned into a PWM regulator discussion.
> Maybe we should start a new thread.
Probably, you're lucky I even looked at this - the number of irrelevant
patches I get CCed on is such that I'll often delete things that look
irrelevant unread. I'm unsure what the relevance is, it looks like it's
mainly a discussion about pinctrl?
> As I said, the problem you're describing (pins muxed to the PWM device
> when it should actually stay in gpio+input mode) is not new, and the old
> pwm-regulator and pwm-rockchip implementation (before my atomic PWM
> changes) were behaving the same way.
Why would this make any kind of sense?
> What is new though, is the pwm_regulator_init_state() function [1], and
> it seems it's now preventing the probe of a pwm-regulator device if the
> initial PWM state is not described in the voltage-table.
> The question is, what should we do?
> 1/ Force users to put an entry matching this state (which means
> breaking DT compat)
> 2/ Put a valid value in drvdata->state even if it's not reflecting the
> real state
> 3/ Patch regulator core to support an "unknown-selector" return code.
Could someone say what the actual problem was please? That was a very
long e-mail so I might be missing something but the obvious thing seems
to be to force a state since we'll be doing that when we enable anyway.
Or just not have the voltage table and use it as a continuous regulator.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization
Date: Thu, 22 Sep 2016 17:47:52 +0100 [thread overview]
Message-ID: <20160922164752.GP7994@sirena.org.uk> (raw)
In-Reply-To: <20160922171217.09a6d13f@bbrezillon>
On Thu, Sep 22, 2016 at 05:12:17PM +0200, Boris Brezillon wrote:
> +Mark
> I realize Mark has been out of the discussion, and what started as a DT
> problem actually turned into a PWM regulator discussion.
> Maybe we should start a new thread.
Probably, you're lucky I even looked at this - the number of irrelevant
patches I get CCed on is such that I'll often delete things that look
irrelevant unread. I'm unsure what the relevance is, it looks like it's
mainly a discussion about pinctrl?
> As I said, the problem you're describing (pins muxed to the PWM device
> when it should actually stay in gpio+input mode) is not new, and the old
> pwm-regulator and pwm-rockchip implementation (before my atomic PWM
> changes) were behaving the same way.
Why would this make any kind of sense?
> What is new though, is the pwm_regulator_init_state() function [1], and
> it seems it's now preventing the probe of a pwm-regulator device if the
> initial PWM state is not described in the voltage-table.
> The question is, what should we do?
> 1/ Force users to put an entry matching this state (which means
> breaking DT compat)
> 2/ Put a valid value in drvdata->state even if it's not reflecting the
> real state
> 3/ Patch regulator core to support an "unknown-selector" return code.
Could someone say what the actual problem was please? That was a very
long e-mail so I might be missing something but the obvious thing seems
to be to force a state since we'll be doing that when we enable anyway.
Or just not have the voltage table and use it as a continuous regulator.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160922/bd12da6f/attachment.sig>
next prev parent reply other threads:[~2016-09-22 16:47 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 8:43 [PATCH 0/1] fix rk3066a based boards boot issue on linux-4.8 Andy Yan
2016-09-19 8:43 ` Andy Yan
2016-09-19 8:44 ` [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization Andy Yan
2016-09-19 8:44 ` Andy Yan
2016-09-19 9:25 ` Boris Brezillon
2016-09-19 9:25 ` Boris Brezillon
2016-09-19 9:38 ` Andy Yan
2016-09-19 9:38 ` Andy Yan
2016-09-19 9:44 ` Boris Brezillon
2016-09-19 9:44 ` Boris Brezillon
2016-09-19 9:59 ` Andy Yan
2016-09-19 15:15 ` Doug Anderson
2016-09-19 15:15 ` Doug Anderson
2016-09-19 16:15 ` Heiko Stuebner
2016-09-19 16:15 ` Heiko Stuebner
2016-09-19 16:38 ` Doug Anderson
2016-09-19 16:38 ` Doug Anderson
2016-09-19 17:13 ` Boris Brezillon
2016-09-19 17:13 ` Boris Brezillon
2016-09-19 17:22 ` Doug Anderson
2016-09-19 17:22 ` Doug Anderson
2016-09-19 17:48 ` Boris Brezillon
2016-09-19 17:48 ` Boris Brezillon
2016-09-19 17:52 ` Doug Anderson
2016-09-19 17:52 ` Doug Anderson
2016-09-19 18:06 ` Boris Brezillon
2016-09-19 18:06 ` Boris Brezillon
2016-09-19 18:12 ` Doug Anderson
2016-09-19 18:12 ` Doug Anderson
2016-09-19 18:31 ` Boris Brezillon
2016-09-19 18:31 ` Boris Brezillon
2016-09-19 20:43 ` Boris Brezillon
2016-09-19 20:43 ` Boris Brezillon
2016-09-19 21:15 ` Doug Anderson
2016-09-19 21:15 ` Doug Anderson
2016-09-22 15:12 ` Boris Brezillon
2016-09-22 15:12 ` Boris Brezillon
2016-09-22 16:47 ` Mark Brown [this message]
2016-09-22 16:47 ` Mark Brown
[not found] ` <20160922164752.GP7994-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-22 18:13 ` Boris Brezillon
2016-09-22 18:13 ` Boris Brezillon
2016-09-22 18:13 ` Boris Brezillon
2016-09-22 19:26 ` Mark Brown
2016-09-22 19:26 ` Mark Brown
2016-09-19 17:25 ` Heiko Stuebner
2016-09-19 17:25 ` Heiko Stuebner
2016-09-19 9:21 ` [PATCH 0/1] fix rk3066a based boards boot issue on linux-4.8 Boris Brezillon
2016-09-19 9:21 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922164752.GP7994@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.yan@rock-chips.com \
--cc=boris.brezillon@free-electrons.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.