From: Mark Brown <broonie@kernel.org>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Doug Anderson <dianders@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
Andy Yan <andy.yan@rock-chips.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization
Date: Thu, 22 Sep 2016 20:26:02 +0100 [thread overview]
Message-ID: <20160922192602.GV7994@sirena.org.uk> (raw)
In-Reply-To: <20160922201301.0157a292@bbrezillon>
[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]
On Thu, Sep 22, 2016 at 08:13:01PM +0200, Boris Brezillon wrote:
> So, there are 2 different problems here:
> 1/ the board no longer boots because of commit 87248991a1de and a
> missing entry in the voltage table
> 2/ claiming the PWM pins at probe time can cause glitches
> I'm currently trying to solve #1, but most of the discussion in this
> thread was about addressing #2.
Well, if you actually want the entry in the voltage table then adding it
does seem the most sensible fix.
> > That was a very
> > long e-mail so I might be missing something but the obvious thing seems
> > to be to force a state since we'll be doing that when we enable anyway.
> Hm, okay, but which state should we choose? The first entry in the
> voltage-table?
That's why we don't do this currently. Probably the closest one if we
can work out what it was trying to achieve.
> > Or just not have the voltage table and use it as a continuous regulator.
> Yes, but that means patching the DT, which means breaking the DT compat.
It sounds like you want to fix the DT anyway though?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization
Date: Thu, 22 Sep 2016 20:26:02 +0100 [thread overview]
Message-ID: <20160922192602.GV7994@sirena.org.uk> (raw)
In-Reply-To: <20160922201301.0157a292@bbrezillon>
On Thu, Sep 22, 2016 at 08:13:01PM +0200, Boris Brezillon wrote:
> So, there are 2 different problems here:
> 1/ the board no longer boots because of commit 87248991a1de and a
> missing entry in the voltage table
> 2/ claiming the PWM pins at probe time can cause glitches
> I'm currently trying to solve #1, but most of the discussion in this
> thread was about addressing #2.
Well, if you actually want the entry in the voltage table then adding it
does seem the most sensible fix.
> > That was a very
> > long e-mail so I might be missing something but the obvious thing seems
> > to be to force a state since we'll be doing that when we enable anyway.
> Hm, okay, but which state should we choose? The first entry in the
> voltage-table?
That's why we don't do this currently. Probably the closest one if we
can work out what it was trying to achieve.
> > Or just not have the voltage table and use it as a continuous regulator.
> Yes, but that means patching the DT, which means breaking the DT compat.
It sounds like you want to fix the DT anyway though?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160922/adb328ef/attachment.sig>
next prev parent reply other threads:[~2016-09-22 19:26 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 8:43 [PATCH 0/1] fix rk3066a based boards boot issue on linux-4.8 Andy Yan
2016-09-19 8:43 ` Andy Yan
2016-09-19 8:44 ` [PATCH] arm: dts: fix rk3066a based boards vdd_log voltage initialization Andy Yan
2016-09-19 8:44 ` Andy Yan
2016-09-19 9:25 ` Boris Brezillon
2016-09-19 9:25 ` Boris Brezillon
2016-09-19 9:38 ` Andy Yan
2016-09-19 9:38 ` Andy Yan
2016-09-19 9:44 ` Boris Brezillon
2016-09-19 9:44 ` Boris Brezillon
2016-09-19 9:59 ` Andy Yan
2016-09-19 15:15 ` Doug Anderson
2016-09-19 15:15 ` Doug Anderson
2016-09-19 16:15 ` Heiko Stuebner
2016-09-19 16:15 ` Heiko Stuebner
2016-09-19 16:38 ` Doug Anderson
2016-09-19 16:38 ` Doug Anderson
2016-09-19 17:13 ` Boris Brezillon
2016-09-19 17:13 ` Boris Brezillon
2016-09-19 17:22 ` Doug Anderson
2016-09-19 17:22 ` Doug Anderson
2016-09-19 17:48 ` Boris Brezillon
2016-09-19 17:48 ` Boris Brezillon
2016-09-19 17:52 ` Doug Anderson
2016-09-19 17:52 ` Doug Anderson
2016-09-19 18:06 ` Boris Brezillon
2016-09-19 18:06 ` Boris Brezillon
2016-09-19 18:12 ` Doug Anderson
2016-09-19 18:12 ` Doug Anderson
2016-09-19 18:31 ` Boris Brezillon
2016-09-19 18:31 ` Boris Brezillon
2016-09-19 20:43 ` Boris Brezillon
2016-09-19 20:43 ` Boris Brezillon
2016-09-19 21:15 ` Doug Anderson
2016-09-19 21:15 ` Doug Anderson
2016-09-22 15:12 ` Boris Brezillon
2016-09-22 15:12 ` Boris Brezillon
2016-09-22 16:47 ` Mark Brown
2016-09-22 16:47 ` Mark Brown
[not found] ` <20160922164752.GP7994-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-09-22 18:13 ` Boris Brezillon
2016-09-22 18:13 ` Boris Brezillon
2016-09-22 18:13 ` Boris Brezillon
2016-09-22 19:26 ` Mark Brown [this message]
2016-09-22 19:26 ` Mark Brown
2016-09-19 17:25 ` Heiko Stuebner
2016-09-19 17:25 ` Heiko Stuebner
2016-09-19 9:21 ` [PATCH 0/1] fix rk3066a based boards boot issue on linux-4.8 Boris Brezillon
2016-09-19 9:21 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922192602.GV7994@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andy.yan@rock-chips.com \
--cc=boris.brezillon@free-electrons.com \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.