From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Joe Perches <joe@perches.com>,
linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()
Date: Sat, 24 Sep 2016 16:39:12 +0000 [thread overview]
Message-ID: <20160924163912.GA40187@dtor-ws> (raw)
In-Reply-To: <8164eb48-e3fa-fa9d-6351-f14b595a6dc3@users.sourceforge.net>
On Sat, Sep 24, 2016 at 06:32:29PM +0200, SF Markus Elfring wrote:
> >> @@ -57,27 +57,29 @@ static int joydump_connect(struct gameport *gameport, struct gameport_driver *dr
> >>> unsigned long flags;
> >>> unsigned char u;
> >>
> >>> - printk(KERN_INFO "joydump: ,------------------ START ----------------.\n");
> >>> - printk(KERN_INFO "joydump: | Dumping: %30s |\n", gameport->phys);
> >>> - printk(KERN_INFO "joydump: | Speed: %28d kHz |\n", gameport->speed);
> >>> + pr_info(",------------------ START ----------------.\n"
> >>> + "| Dumping: %30s |\n"
> >>> + "| Speed: %28d kHz |\n",
> >>> + gameport->phys,
> >>> + gameport->speed);
> >
> > Not the same output.
>
> Should the desired output be the same when the relevant data are passed by a single function call
> (instead of three as before)?
The desired output should not be broken in conversion, which you did. Do
you know how syslog works and why the transformation is not correct.
I am also curious as to why you are patching joydump? Are you working on
extending it?
Thanks.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Joe Perches <joe@perches.com>,
linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect()
Date: Sat, 24 Sep 2016 09:39:12 -0700 [thread overview]
Message-ID: <20160924163912.GA40187@dtor-ws> (raw)
In-Reply-To: <8164eb48-e3fa-fa9d-6351-f14b595a6dc3@users.sourceforge.net>
On Sat, Sep 24, 2016 at 06:32:29PM +0200, SF Markus Elfring wrote:
> >> @@ -57,27 +57,29 @@ static int joydump_connect(struct gameport *gameport, struct gameport_driver *dr
> >>> unsigned long flags;
> >>> unsigned char u;
> >>
> >>> - printk(KERN_INFO "joydump: ,------------------ START ----------------.\n");
> >>> - printk(KERN_INFO "joydump: | Dumping: %30s |\n", gameport->phys);
> >>> - printk(KERN_INFO "joydump: | Speed: %28d kHz |\n", gameport->speed);
> >>> + pr_info(",------------------ START ----------------.\n"
> >>> + "| Dumping: %30s |\n"
> >>> + "| Speed: %28d kHz |\n",
> >>> + gameport->phys,
> >>> + gameport->speed);
> >
> > Not the same output.
>
> Should the desired output be the same when the relevant data are passed by a single function call
> (instead of three as before)?
The desired output should not be broken in conversion, which you did. Do
you know how syslog works and why the transformation is not correct.
I am also curious as to why you are patching joydump? Are you working on
extending it?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2016-09-24 16:39 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-24 13:45 [PATCH 0/4] Input-gameport: Fine-tuning for joydump_connect() SF Markus Elfring
2016-09-24 13:45 ` SF Markus Elfring
2016-09-24 13:46 ` [PATCH 1/4] Input-gameport: Use kmalloc_array() in joydump_connect() SF Markus Elfring
2016-09-24 13:46 ` SF Markus Elfring
2016-09-24 16:42 ` Dmitry Torokhov
2016-09-24 16:42 ` Dmitry Torokhov
2016-09-24 17:04 ` SF Markus Elfring
2016-09-24 17:04 ` SF Markus Elfring
2016-09-24 13:47 ` [PATCH 2/4] Input-gameport: Delete an error message for a failed memory allocation SF Markus Elfring
2016-09-24 13:47 ` SF Markus Elfring
2016-09-24 13:48 ` [PATCH 3/4] Input-gameport: Add the macro "pr_fmt" for module "joydump" SF Markus Elfring
2016-09-24 13:48 ` SF Markus Elfring
2016-09-24 16:41 ` Dmitry Torokhov
2016-09-24 16:41 ` Dmitry Torokhov
2016-09-24 16:55 ` SF Markus Elfring
2016-09-24 16:55 ` SF Markus Elfring
2016-09-24 17:03 ` Joe Perches
2016-09-24 17:03 ` Joe Perches
2016-09-24 17:45 ` SF Markus Elfring
2016-09-24 17:45 ` SF Markus Elfring
2016-09-24 18:01 ` Joe Perches
2016-09-24 18:01 ` Joe Perches
2016-09-24 18:45 ` SF Markus Elfring
2016-09-24 18:45 ` SF Markus Elfring
2016-09-24 13:50 ` [PATCH 4/4] Input-gameport: Replace some printk() calls by pr_info() in joydump_connect() SF Markus Elfring
2016-09-24 13:50 ` SF Markus Elfring
2016-09-24 16:13 ` Joe Perches
2016-09-24 16:13 ` Joe Perches
2016-09-24 16:32 ` SF Markus Elfring
2016-09-24 16:32 ` SF Markus Elfring
2016-09-24 16:39 ` Dmitry Torokhov [this message]
2016-09-24 16:39 ` Dmitry Torokhov
2016-09-24 17:20 ` SF Markus Elfring
2016-09-24 17:20 ` SF Markus Elfring
2016-09-24 16:47 ` [PATCH 4/4] " Joe Perches
2016-09-24 16:47 ` Joe Perches
2016-09-24 19:50 ` SF Markus Elfring
2016-09-24 19:50 ` SF Markus Elfring
2016-09-24 16:41 ` [PATCH 4/4] " SF Markus Elfring
2016-09-24 16:41 ` SF Markus Elfring
2016-09-25 7:15 ` [PATCH v2 3/3] " SF Markus Elfring
2016-09-25 7:15 ` SF Markus Elfring
2016-09-25 7:31 ` Joe Perches
2016-09-25 7:31 ` Joe Perches
2016-09-25 7:45 ` SF Markus Elfring
2016-09-25 7:45 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160924163912.GA40187@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.