From: peterz@infradead.org (Peter Zijlstra)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC
Date: Wed, 28 Sep 2016 08:56:02 +0200 [thread overview]
Message-ID: <20160928065602.GS2794@worktop> (raw)
In-Reply-To: <d82fe247-2b8c-896d-e6ce-fb82e78f360e@synopsys.com>
On Tue, Sep 27, 2016@09:51:35AM -0700, Vineet Gupta wrote:
> On 09/27/2016 09:37 AM, Kim Phillips wrote:
> > On Tue, 27 Sep 2016 07:53:56 -0700
> > Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
> >
> >> > This doesn't seem to be used anywhere
> > I thought so too, until I got this response for an equivalent patch:
> >
> > https://lkml.org/lkml/2016/8/31/53
>
> So this is some sort of "developer shortcut" to quickly enable 2 options with one
> option. Purpose seems dubious to me ! It would still be possible to enable vmalloc
> backed mmap on x86 by simply enabling that option from Kconfig.
PERF_USE_VMALLOC is not a user selectable option. Also
DEBUG_PERF_USE_VMALLOC clearly indicates its a _DEBUG_ option. Heck,
even the help text says what its for.
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Kim Phillips <kim.phillips@arm.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Petr Mladek <pmladek@suse.com>, Kees Cook <keescook@chromium.org>,
Arnd Bergmann <arnd@arndb.de>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-snps-arc@lists.infradead.org,
Thomas Garnier <thgarnie@google.com>
Subject: Re: [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC
Date: Wed, 28 Sep 2016 08:56:02 +0200 [thread overview]
Message-ID: <20160928065602.GS2794@worktop> (raw)
In-Reply-To: <d82fe247-2b8c-896d-e6ce-fb82e78f360e@synopsys.com>
On Tue, Sep 27, 2016 at 09:51:35AM -0700, Vineet Gupta wrote:
> On 09/27/2016 09:37 AM, Kim Phillips wrote:
> > On Tue, 27 Sep 2016 07:53:56 -0700
> > Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
> >
> >> > This doesn't seem to be used anywhere
> > I thought so too, until I got this response for an equivalent patch:
> >
> > https://lkml.org/lkml/2016/8/31/53
>
> So this is some sort of "developer shortcut" to quickly enable 2 options with one
> option. Purpose seems dubious to me ! It would still be possible to enable vmalloc
> backed mmap on x86 by simply enabling that option from Kconfig.
PERF_USE_VMALLOC is not a user selectable option. Also
DEBUG_PERF_USE_VMALLOC clearly indicates its a _DEBUG_ option. Heck,
even the help text says what its for.
next prev parent reply other threads:[~2016-09-28 6:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 14:53 [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC Vineet Gupta
2016-09-27 14:53 ` Vineet Gupta
2016-09-27 16:37 ` Kim Phillips
2016-09-27 16:37 ` Kim Phillips
2016-09-27 16:51 ` Vineet Gupta
2016-09-27 16:51 ` Vineet Gupta
2016-09-28 6:56 ` Peter Zijlstra [this message]
2016-09-28 6:56 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928065602.GS2794@worktop \
--to=peterz@infradead.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.