* [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC @ 2016-09-27 14:53 ` Vineet Gupta 0 siblings, 0 replies; 8+ messages in thread From: Vineet Gupta @ 2016-09-27 14:53 UTC (permalink / raw) To: linux-snps-arc This doesn't seem to be used anywhere Cc: Andrew Morton <akpm at linux-foundation.org> Cc: Kees Cook <keescook at chromium.org> Cc: Johannes Weiner <hannes at cmpxchg.org> Cc: Tejun Heo <tj at kernel.org> Cc: Arnd Bergmann <arnd at arndb.de> Cc: Petr Mladek <pmladek at suse.com> Cc: Ard Biesheuvel <ard.biesheuvel at linaro.org> Cc: Thomas Garnier <thgarnie at google.com> Cc: Nicolas Pitre <nicolas.pitre at linaro.org> Cc: Peter Zijlstra <peterz at infradead.org> Cc: linux-snps-arc at lists.infradead.org Cc: linux-kernel at vger.kernel.org Signed-off-by: Vineet Gupta <vgupta at synopsys.com> --- init/Kconfig | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/init/Kconfig b/init/Kconfig index cac3f096050d..934a61f6e2cc 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -1707,19 +1707,6 @@ config PERF_EVENTS Say Y if unsure. -config DEBUG_PERF_USE_VMALLOC - default n - bool "Debug: use vmalloc to back perf mmap() buffers" - depends on PERF_EVENTS && DEBUG_KERNEL && !PPC - select PERF_USE_VMALLOC - help - Use vmalloc memory to back perf mmap() buffers. - - Mostly useful for debugging the vmalloc code on platforms - that don't require it. - - Say N if unsure. - endmenu config VM_EVENT_COUNTERS -- 2.7.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC @ 2016-09-27 14:53 ` Vineet Gupta 0 siblings, 0 replies; 8+ messages in thread From: Vineet Gupta @ 2016-09-27 14:53 UTC (permalink / raw) To: peterz Cc: Alexey Brodkin, Vineet Gupta, Andrew Morton, Kees Cook, Johannes Weiner, Tejun Heo, Arnd Bergmann, Petr Mladek, Ard Biesheuvel, Thomas Garnier, Nicolas Pitre, linux-snps-arc, linux-kernel This doesn't seem to be used anywhere Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Kees Cook <keescook@chromium.org> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Tejun Heo <tj@kernel.org> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Petr Mladek <pmladek@suse.com> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Thomas Garnier <thgarnie@google.com> Cc: Nicolas Pitre <nicolas.pitre@linaro.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: linux-snps-arc@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Vineet Gupta <vgupta@synopsys.com> --- init/Kconfig | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/init/Kconfig b/init/Kconfig index cac3f096050d..934a61f6e2cc 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -1707,19 +1707,6 @@ config PERF_EVENTS Say Y if unsure. -config DEBUG_PERF_USE_VMALLOC - default n - bool "Debug: use vmalloc to back perf mmap() buffers" - depends on PERF_EVENTS && DEBUG_KERNEL && !PPC - select PERF_USE_VMALLOC - help - Use vmalloc memory to back perf mmap() buffers. - - Mostly useful for debugging the vmalloc code on platforms - that don't require it. - - Say N if unsure. - endmenu config VM_EVENT_COUNTERS -- 2.7.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC 2016-09-27 14:53 ` Vineet Gupta @ 2016-09-27 16:37 ` Kim Phillips -1 siblings, 0 replies; 8+ messages in thread From: Kim Phillips @ 2016-09-27 16:37 UTC (permalink / raw) To: linux-snps-arc On Tue, 27 Sep 2016 07:53:56 -0700 Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote: > This doesn't seem to be used anywhere I thought so too, until I got this response for an equivalent patch: https://lkml.org/lkml/2016/8/31/53 Kim ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC @ 2016-09-27 16:37 ` Kim Phillips 0 siblings, 0 replies; 8+ messages in thread From: Kim Phillips @ 2016-09-27 16:37 UTC (permalink / raw) To: Vineet Gupta Cc: peterz, Alexey Brodkin, Andrew Morton, Kees Cook, Johannes Weiner, Tejun Heo, Arnd Bergmann, Petr Mladek, Ard Biesheuvel, Thomas Garnier, Nicolas Pitre, linux-snps-arc, linux-kernel On Tue, 27 Sep 2016 07:53:56 -0700 Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote: > This doesn't seem to be used anywhere I thought so too, until I got this response for an equivalent patch: https://lkml.org/lkml/2016/8/31/53 Kim ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC 2016-09-27 16:37 ` Kim Phillips @ 2016-09-27 16:51 ` Vineet Gupta -1 siblings, 0 replies; 8+ messages in thread From: Vineet Gupta @ 2016-09-27 16:51 UTC (permalink / raw) To: linux-snps-arc On 09/27/2016 09:37 AM, Kim Phillips wrote: > On Tue, 27 Sep 2016 07:53:56 -0700 > Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote: > >> > This doesn't seem to be used anywhere > I thought so too, until I got this response for an equivalent patch: > > https://lkml.org/lkml/2016/8/31/53 So this is some sort of "developer shortcut" to quickly enable 2 options with one option. Purpose seems dubious to me ! It would still be possible to enable vmalloc backed mmap on x86 by simply enabling that option from Kconfig. -Vineet ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC @ 2016-09-27 16:51 ` Vineet Gupta 0 siblings, 0 replies; 8+ messages in thread From: Vineet Gupta @ 2016-09-27 16:51 UTC (permalink / raw) To: Kim Phillips Cc: Nicolas Pitre, Petr Mladek, Kees Cook, Arnd Bergmann, Ard Biesheuvel, peterz, Alexey Brodkin, linux-kernel, Johannes Weiner, Tejun Heo, Andrew Morton, linux-snps-arc, Thomas Garnier On 09/27/2016 09:37 AM, Kim Phillips wrote: > On Tue, 27 Sep 2016 07:53:56 -0700 > Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote: > >> > This doesn't seem to be used anywhere > I thought so too, until I got this response for an equivalent patch: > > https://lkml.org/lkml/2016/8/31/53 So this is some sort of "developer shortcut" to quickly enable 2 options with one option. Purpose seems dubious to me ! It would still be possible to enable vmalloc backed mmap on x86 by simply enabling that option from Kconfig. -Vineet ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC 2016-09-27 16:51 ` Vineet Gupta @ 2016-09-28 6:56 ` Peter Zijlstra -1 siblings, 0 replies; 8+ messages in thread From: Peter Zijlstra @ 2016-09-28 6:56 UTC (permalink / raw) To: linux-snps-arc On Tue, Sep 27, 2016@09:51:35AM -0700, Vineet Gupta wrote: > On 09/27/2016 09:37 AM, Kim Phillips wrote: > > On Tue, 27 Sep 2016 07:53:56 -0700 > > Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote: > > > >> > This doesn't seem to be used anywhere > > I thought so too, until I got this response for an equivalent patch: > > > > https://lkml.org/lkml/2016/8/31/53 > > So this is some sort of "developer shortcut" to quickly enable 2 options with one > option. Purpose seems dubious to me ! It would still be possible to enable vmalloc > backed mmap on x86 by simply enabling that option from Kconfig. PERF_USE_VMALLOC is not a user selectable option. Also DEBUG_PERF_USE_VMALLOC clearly indicates its a _DEBUG_ option. Heck, even the help text says what its for. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC @ 2016-09-28 6:56 ` Peter Zijlstra 0 siblings, 0 replies; 8+ messages in thread From: Peter Zijlstra @ 2016-09-28 6:56 UTC (permalink / raw) To: Vineet Gupta Cc: Kim Phillips, Nicolas Pitre, Petr Mladek, Kees Cook, Arnd Bergmann, Ard Biesheuvel, Alexey Brodkin, linux-kernel, Johannes Weiner, Tejun Heo, Andrew Morton, linux-snps-arc, Thomas Garnier On Tue, Sep 27, 2016 at 09:51:35AM -0700, Vineet Gupta wrote: > On 09/27/2016 09:37 AM, Kim Phillips wrote: > > On Tue, 27 Sep 2016 07:53:56 -0700 > > Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote: > > > >> > This doesn't seem to be used anywhere > > I thought so too, until I got this response for an equivalent patch: > > > > https://lkml.org/lkml/2016/8/31/53 > > So this is some sort of "developer shortcut" to quickly enable 2 options with one > option. Purpose seems dubious to me ! It would still be possible to enable vmalloc > backed mmap on x86 by simply enabling that option from Kconfig. PERF_USE_VMALLOC is not a user selectable option. Also DEBUG_PERF_USE_VMALLOC clearly indicates its a _DEBUG_ option. Heck, even the help text says what its for. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-09-28 6:56 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-09-27 14:53 [PATCH] perf: remove orphan DEBUG_PERF_USE_VMALLOC Vineet Gupta 2016-09-27 14:53 ` Vineet Gupta 2016-09-27 16:37 ` Kim Phillips 2016-09-27 16:37 ` Kim Phillips 2016-09-27 16:51 ` Vineet Gupta 2016-09-27 16:51 ` Vineet Gupta 2016-09-28 6:56 ` Peter Zijlstra 2016-09-28 6:56 ` Peter Zijlstra
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.