From: Elizabeth Ferdman <gnudevliz@gmail.com>
To: outreachy-kernel@googlegroups.com
Cc: amsfield22@gmail.com
Subject: Split String Checkpatch Warning
Date: Thu, 29 Sep 2016 15:14:05 -0700 [thread overview]
Message-ID: <20160929221404.GA7406@localhost> (raw)
I'm seeing this checkpatch error:
WARNING: quoted string split across lines
example:
MODULE_AUTHOR("Ralph Metzler, Trent Piepho, Ben Pfaff, "
"Christoph Bartelmus, Andrei Tanas");
Just wondering if this is a good thing to fix, and how do I fix it? I
don't see anything about it in the style guide. If I put the whole
string on one line, it's more than 80 characters. I found one option on
stack overflow that says you can do:
char *my_string = "Line 1 \
Line 2";
So I'd be putting a space and a backslash after the line?
I don't know if that conforms with linux kernel coding style though.
I'm also wondering if anyone knows any good resources on common
checkpatch errors and the proper way to fix them.
Thanks,
Liz
next reply other threads:[~2016-09-29 22:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 22:14 Elizabeth Ferdman [this message]
2016-09-29 23:50 ` Split String Checkpatch Warning Alison Schofield
2016-09-30 0:04 ` Elizabeth Ferdman
2016-09-30 4:52 ` [Outreachy kernel] " Greg KH
2016-09-30 4:56 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160929221404.GA7406@localhost \
--to=gnudevliz@gmail.com \
--cc=amsfield22@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.