Re: [Outreachy kernel] Split String Checkpatch Warning

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Sep 29, 2016 at 03:14:05PM -0700, Elizabeth Ferdman wrote:
> I'm seeing this checkpatch error:
> 
> WARNING: quoted string split across lines
> 
> example:
> MODULE_AUTHOR("Ralph Metzler, Trent Piepho, Ben Pfaff, "
>              "Christoph Bartelmus, Andrei Tanas");
> 
> Just wondering if this is a good thing to fix, and how do I fix it? I
> don't see anything about it in the style guide. If I put the whole
> string on one line, it's more than 80 characters. I found one option on
> stack overflow that says you can do:
> 
> char *my_string = "Line 1 \
>                    Line 2";

As most stackoverflow answers, this one is technically correct, but
totally wrong :)

You would end up with a string that contained "Line 1          Line 2"
in it.  The leading whitespace is not what you want to have before "Line
2".

Just merge the strings, putting them all on one line, so your example
above should look like:
MODULE_AUTHOR("Ralph Metzler, Trent Piepho, Ben Pfaff, Christoph Bartelmus, Andrei Tanas");

Hope this helps,

greg k-h