Re: Split String Checkpatch Warning

[Alison Schofield <amsfield22@gmail.com>]

On Thu, Sep 29, 2016 at 03:14:05PM -0700, Elizabeth Ferdman wrote:
> I'm seeing this checkpatch error:
> 
> WARNING: quoted string split across lines
> 
> example:
> MODULE_AUTHOR("Ralph Metzler, Trent Piepho, Ben Pfaff, "
>              "Christoph Bartelmus, Andrei Tanas");
> 
> Just wondering if this is a good thing to fix, and how do I fix it? I
> don't see anything about it in the style guide. If I put the whole
> string on one line, it's more than 80 characters. I found one option on
> stack overflow that says you can do:
> 
> char *my_string = "Line 1 \
>                    Line 2";
> 
> So I'd be putting a space and a backslash after the line?
> I don't know if that conforms with linux kernel coding style though.
> 
> I'm also wondering if anyone knows any good resources on common
> checkpatch errors and the proper way to fix them. 
> 
> Thanks,
> Liz
Hi Liz,
Best guide may very well be this googlegroup!  It goes back a few years,
so pretty much every checkpatch error has some history in here.  'split
string' not so much, only 11.  Hopefully you can find something in there
that gives you a lead.  Search through the googlegroups web interface.
alisons