From: Arnd Bergmann <arnd@arndb.de>
To: Felix Fietkau <nbd@nbd.name>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] Documentation: dt: net: add mt76 wireless device binding
Date: Fri, 30 Sep 2016 00:41:41 +0200 [thread overview]
Message-ID: <201609300041.41876.arnd@arndb.de> (raw)
In-Reply-To: <e7d435b2-6b59-45af-07eb-b10789d61a9c@nbd.name>
On Thursday 29 September 2016, Felix Fietkau wrote:
> On 2016-09-08 12:54, Kalle Valo wrote:
> > Felix Fietkau <nbd@nbd.name> writes:
> >
> >> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> >> ---
> >> .../bindings/net/wireless/mediatek,mt76.txt | 26 ++++++++++++++++++++++
> >> 1 file changed, 26 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt
> >> new file mode 100644
> >> index 0000000..d51c35f
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt
> >> @@ -0,0 +1,26 @@
> >> +* MediaTek mt76xx devices
> >> +
> >> +This node provides properties for configuring the MediaTek mt76xx wireless
> >> +device. The node is expected to be specified as a child node of the PCI
> >> +controller to which the wireless chip is connected.
> >> +
> >> +Optional properties:
> >> +
> >> +- mac-address: See ethernet.txt in the parent directory
> >> +- local-mac-address: See ethernet.txt in the parent directory
> >> +- mediatek,2ghz: Override the 2.4 GHz band capability from EEPROM
> >> +- mediatek,5ghz: Override the 5 GHz band capability from EEPROM
> >> +- mediatek,mtd-eeprom: Specify a MTD partition + offset containing EEPROM data
> >> +
> >> +&pcie {
> >> + status = "okay";
> >> +
> >> + pcie0 {
> >> + mt76@0,0 {
> >> + reg = <0x0000 0 0 0 0>;
Maybe have an examplep of a real register address other than zero?
> >> + device_type = "pci";
> >> + mediatek,mtd-eeprom = <&factory 0x8000>;
> >> + mediatek,2ghz = <0>;
It's not clear what the possible values for the 2ghz property are,
can you be more verbose in the description? How is <0> different
from no property?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org>
Cc: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 1/3] Documentation: dt: net: add mt76 wireless device binding
Date: Fri, 30 Sep 2016 00:41:41 +0200 [thread overview]
Message-ID: <201609300041.41876.arnd@arndb.de> (raw)
In-Reply-To: <e7d435b2-6b59-45af-07eb-b10789d61a9c-Vt+b4OUoWG0@public.gmane.org>
On Thursday 29 September 2016, Felix Fietkau wrote:
> On 2016-09-08 12:54, Kalle Valo wrote:
> > Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org> writes:
> >
> >> Signed-off-by: Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org>
> >> ---
> >> .../bindings/net/wireless/mediatek,mt76.txt | 26 ++++++++++++++++++++++
> >> 1 file changed, 26 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt
> >> new file mode 100644
> >> index 0000000..d51c35f
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.txt
> >> @@ -0,0 +1,26 @@
> >> +* MediaTek mt76xx devices
> >> +
> >> +This node provides properties for configuring the MediaTek mt76xx wireless
> >> +device. The node is expected to be specified as a child node of the PCI
> >> +controller to which the wireless chip is connected.
> >> +
> >> +Optional properties:
> >> +
> >> +- mac-address: See ethernet.txt in the parent directory
> >> +- local-mac-address: See ethernet.txt in the parent directory
> >> +- mediatek,2ghz: Override the 2.4 GHz band capability from EEPROM
> >> +- mediatek,5ghz: Override the 5 GHz band capability from EEPROM
> >> +- mediatek,mtd-eeprom: Specify a MTD partition + offset containing EEPROM data
> >> +
> >> +&pcie {
> >> + status = "okay";
> >> +
> >> + pcie0 {
> >> + mt76@0,0 {
> >> + reg = <0x0000 0 0 0 0>;
Maybe have an examplep of a real register address other than zero?
> >> + device_type = "pci";
> >> + mediatek,mtd-eeprom = <&factory 0x8000>;
> >> + mediatek,2ghz = <0>;
It's not clear what the possible values for the 2ghz property are,
can you be more verbose in the description? How is <0> different
from no property?
Arnd
next prev parent reply other threads:[~2016-09-29 22:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 9:51 [PATCH v3 0/3] mt76: add new wireless driver for MediaTek MT76x2 PCIe chips Felix Fietkau
2016-09-05 9:51 ` [PATCH v3 1/3] Documentation: dt: net: add mt76 wireless device binding Felix Fietkau
2016-09-08 10:54 ` Kalle Valo
2016-09-08 10:54 ` Kalle Valo
2016-09-29 18:31 ` Felix Fietkau
2016-09-29 18:31 ` Felix Fietkau
2016-09-29 22:41 ` Arnd Bergmann [this message]
2016-09-29 22:41 ` Arnd Bergmann
2016-09-30 8:48 ` Felix Fietkau
2016-09-30 8:48 ` Felix Fietkau
2016-09-30 14:36 ` Arnd Bergmann
2016-09-30 14:36 ` Arnd Bergmann
2016-09-30 14:44 ` Felix Fietkau
2016-09-30 14:44 ` Felix Fietkau
2016-09-30 14:58 ` Arnd Bergmann
2016-09-30 14:58 ` Arnd Bergmann
2016-10-03 13:29 ` Kalle Valo
2016-10-03 13:29 ` Kalle Valo
2016-12-28 10:08 ` Rafał Miłecki
2016-12-28 10:08 ` Rafał Miłecki
2016-12-28 10:43 ` Martin Blumenstingl
2016-12-28 10:43 ` Martin Blumenstingl
2016-12-28 13:28 ` Rafał Miłecki
2016-12-28 13:28 ` Rafał Miłecki
2016-12-28 13:51 ` Rafał Miłecki
2016-12-28 13:51 ` Rafał Miłecki
2016-09-05 9:51 ` [PATCH v3 2/3] mt76: add common code shared between multiple chipsets Felix Fietkau
2016-09-05 9:51 ` [PATCH v3 3/3] mt76: add driver code for MT76x2e Felix Fietkau
2016-09-08 7:52 ` Sergey Ryazanov
2016-09-08 8:25 ` Felix Fietkau
2016-09-08 8:29 ` Sergey Ryazanov
2016-10-04 16:34 ` [v3,3/3] " Kalle Valo
2016-12-07 14:11 ` Felix Fietkau
2016-10-04 16:45 ` Kalle Valo
2016-12-07 14:13 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201609300041.41876.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.