From: Arnd Bergmann <arnd@arndb.de>
To: Felix Fietkau <nbd@nbd.name>
Cc: Kalle Valo <kvalo@codeaurora.org>,
linux-wireless@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] Documentation: dt: net: add mt76 wireless device binding
Date: Fri, 30 Sep 2016 16:36:43 +0200 [thread overview]
Message-ID: <201609301636.43363.arnd@arndb.de> (raw)
In-Reply-To: <3334122f-0d79-f910-a414-5b9cafd9901f@nbd.name>
On Friday 30 September 2016, Felix Fietkau wrote:
> >> >> + pcie0 {
> >> >> + mt76@0,0 {
> >> >> + reg = <0x0000 0 0 0 0>;
> >
> > Maybe have an examplep of a real register address other than zero?
> This is a real example referring to the first device on a PCI bus.
> I copy&pasted this from a .dts file that we use in LEDE.
Ok, I see.
> >> >> + device_type = "pci";
> >> >> + mediatek,mtd-eeprom = <&factory 0x8000>;
> >> >> + mediatek,2ghz = <0>;
> >
> > It's not clear what the possible values for the 2ghz property are,
> > can you be more verbose in the description? How is <0> different
> > from no property?
> 0 means disabled, no property means unchanged (compared to EEPROM).
Maybe have a boolean property instead then to say "mediatek,2ghz-disabled" ?
If zero is the only possible value, there is no need to put a number in there.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org>
Cc: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 1/3] Documentation: dt: net: add mt76 wireless device binding
Date: Fri, 30 Sep 2016 16:36:43 +0200 [thread overview]
Message-ID: <201609301636.43363.arnd@arndb.de> (raw)
In-Reply-To: <3334122f-0d79-f910-a414-5b9cafd9901f-Vt+b4OUoWG0@public.gmane.org>
On Friday 30 September 2016, Felix Fietkau wrote:
> >> >> + pcie0 {
> >> >> + mt76@0,0 {
> >> >> + reg = <0x0000 0 0 0 0>;
> >
> > Maybe have an examplep of a real register address other than zero?
> This is a real example referring to the first device on a PCI bus.
> I copy&pasted this from a .dts file that we use in LEDE.
Ok, I see.
> >> >> + device_type = "pci";
> >> >> + mediatek,mtd-eeprom = <&factory 0x8000>;
> >> >> + mediatek,2ghz = <0>;
> >
> > It's not clear what the possible values for the 2ghz property are,
> > can you be more verbose in the description? How is <0> different
> > from no property?
> 0 means disabled, no property means unchanged (compared to EEPROM).
Maybe have a boolean property instead then to say "mediatek,2ghz-disabled" ?
If zero is the only possible value, there is no need to put a number in there.
Arnd
next prev parent reply other threads:[~2016-09-30 14:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 9:51 [PATCH v3 0/3] mt76: add new wireless driver for MediaTek MT76x2 PCIe chips Felix Fietkau
2016-09-05 9:51 ` [PATCH v3 1/3] Documentation: dt: net: add mt76 wireless device binding Felix Fietkau
2016-09-08 10:54 ` Kalle Valo
2016-09-08 10:54 ` Kalle Valo
2016-09-29 18:31 ` Felix Fietkau
2016-09-29 18:31 ` Felix Fietkau
2016-09-29 22:41 ` Arnd Bergmann
2016-09-29 22:41 ` Arnd Bergmann
2016-09-30 8:48 ` Felix Fietkau
2016-09-30 8:48 ` Felix Fietkau
2016-09-30 14:36 ` Arnd Bergmann [this message]
2016-09-30 14:36 ` Arnd Bergmann
2016-09-30 14:44 ` Felix Fietkau
2016-09-30 14:44 ` Felix Fietkau
2016-09-30 14:58 ` Arnd Bergmann
2016-09-30 14:58 ` Arnd Bergmann
2016-10-03 13:29 ` Kalle Valo
2016-10-03 13:29 ` Kalle Valo
2016-12-28 10:08 ` Rafał Miłecki
2016-12-28 10:08 ` Rafał Miłecki
2016-12-28 10:43 ` Martin Blumenstingl
2016-12-28 10:43 ` Martin Blumenstingl
2016-12-28 13:28 ` Rafał Miłecki
2016-12-28 13:28 ` Rafał Miłecki
2016-12-28 13:51 ` Rafał Miłecki
2016-12-28 13:51 ` Rafał Miłecki
2016-09-05 9:51 ` [PATCH v3 2/3] mt76: add common code shared between multiple chipsets Felix Fietkau
2016-09-05 9:51 ` [PATCH v3 3/3] mt76: add driver code for MT76x2e Felix Fietkau
2016-09-08 7:52 ` Sergey Ryazanov
2016-09-08 8:25 ` Felix Fietkau
2016-09-08 8:29 ` Sergey Ryazanov
2016-10-04 16:34 ` [v3,3/3] " Kalle Valo
2016-12-07 14:11 ` Felix Fietkau
2016-10-04 16:45 ` Kalle Valo
2016-12-07 14:13 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201609301636.43363.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.