* [PATCH 1/2] staging: rtl8188eu: core: rtw_ap: remove boolean comparison
@ 2016-09-30 16:45 Anchal Jain
2016-09-30 17:32 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Anchal Jain @ 2016-09-30 16:45 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel
Boolean tests do not need explicit comparison to true or false.
Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index 79d326a..fbe9941 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -767,7 +767,7 @@ static void start_bss_network(struct adapter *padapter, u8 *pbuf)
update_hw_ht_param(padapter);
}
- if (pmlmepriv->cur_network.join_res != true) { /* setting only at first time */
+ if (pmlmepriv->cur_network.join_res) { /* setting only at first time */
/* WEP Key will be set before this function, do not clear CAM. */
if ((psecuritypriv->dot11PrivacyAlgrthm != _WEP40_) &&
(psecuritypriv->dot11PrivacyAlgrthm != _WEP104_))
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Outreachy kernel] [PATCH 1/2] staging: rtl8188eu: core: rtw_ap: remove boolean comparison
2016-09-30 16:45 [PATCH 1/2] staging: rtl8188eu: core: rtw_ap: remove boolean comparison Anchal Jain
@ 2016-09-30 17:32 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-09-30 17:32 UTC (permalink / raw)
To: Anchal Jain; +Cc: gregkh, outreachy-kernel
On Fri, 30 Sep 2016, Anchal Jain wrote:
> Boolean tests do not need explicit comparison to true or false.
>
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
> index 79d326a..fbe9941 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
> @@ -767,7 +767,7 @@ static void start_bss_network(struct adapter *padapter, u8 *pbuf)
> update_hw_ht_param(padapter);
> }
>
> - if (pmlmepriv->cur_network.join_res != true) { /* setting only at first time */
> + if (pmlmepriv->cur_network.join_res) { /* setting only at first time */
It looks like you have inverted the sense of the test.
julia
> /* WEP Key will be set before this function, do not clear CAM. */
> if ((psecuritypriv->dot11PrivacyAlgrthm != _WEP40_) &&
> (psecuritypriv->dot11PrivacyAlgrthm != _WEP104_))
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160930164424.GA4879%40life-desktop.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-30 17:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-30 16:45 [PATCH 1/2] staging: rtl8188eu: core: rtw_ap: remove boolean comparison Anchal Jain
2016-09-30 17:32 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.