[PATCH 2/2] staging: rtl8188eu: core: rtw_ap: Replace memcmp with ether_addr

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH 2/2] staging: rtl8188eu: core: rtw_ap: Replace memcmp with ether_addr_equal
@ 2016-09-30 16:52 Anchal Jain
  2016-10-02 15:34 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Anchal Jain @ 2016-09-30 16:52 UTC (permalink / raw)
  To: gregkh; +Cc: outreachy-kernel

Replace memcmp() with ether_addr_equal()
issue detect by checkpatch.pl

Signed-off-by: Anchal Jain <anchalj109@gmail.com>
---
 drivers/staging/rtl8188eu/core/rtw_ap.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
index fbe9941..6a3dc5e 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ap.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
@@ -1163,7 +1163,7 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr)
 		paclnode = container_of(plist, struct rtw_wlan_acl_node, list);
 		plist = plist->next;
 
-		if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {
+		if (!ether_addr_equal(paclnode->addr, addr, ETH_ALEN)) {
 			if (paclnode->valid) {
 				added = true;
 				DBG_88E("%s, sta has been added\n", __func__);
@@ -1223,7 +1223,7 @@ int rtw_acl_remove_sta(struct adapter *padapter, u8 *addr)
 		paclnode = container_of(plist, struct rtw_wlan_acl_node, list);
 		plist = plist->next;
 
-		if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {
+		if (!ether_addr_equal(paclnode->addr, addr, ETH_ALEN)) {
 			if (paclnode->valid) {
 				paclnode->valid = false;
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] staging: rtl8188eu: core: rtw_ap: Replace memcmp with ether_addr_equal
  2016-09-30 16:52 [PATCH 2/2] staging: rtl8188eu: core: rtw_ap: Replace memcmp with ether_addr_equal Anchal Jain
@ 2016-10-02 15:34 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-10-02 15:34 UTC (permalink / raw)
  To: Anchal Jain; +Cc: outreachy-kernel

On Fri, Sep 30, 2016 at 10:22:48PM +0530, Anchal Jain wrote:
> Replace memcmp() with ether_addr_equal()
> issue detect by checkpatch.pl
> 
> Signed-off-by: Anchal Jain <anchalj109@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_ap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

You didn't build test this patch, which isn't very nice :(

Please always test your patches by at least building them, otherwise you
will end up with grumpy maintainers...

greg k-h


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-02 15:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-30 16:52 [PATCH 2/2] staging: rtl8188eu: core: rtw_ap: Replace memcmp with ether_addr_equal Anchal Jain
2016-10-02 15:34 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.