From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com
Subject: Re: [PATCH 2/4] regulator: Enable compile testing for Maxim and Samsung PMIC drivers
Date: Tue, 4 Oct 2016 11:30:56 +0200 [thread overview]
Message-ID: <20161004093056.GA8832@kozik-book> (raw)
In-Reply-To: <20161004024055.4kdjvoiig4fwxi54@sirena.org.uk>
On Tue, Oct 04, 2016 at 04:40:55AM +0200, Mark Brown wrote:
> On Sun, Oct 02, 2016 at 10:58:15PM +0200, Krzysztof Kozlowski wrote:
> > Most of Maxim and Samsung PMIC/MUIC regulator drivers can be compile
> > tested to increase build coverage.
>
> All these drivers already just depend on the MFDs which don't have any
> weird architecture dependencies - the main goal with COMPILE_TEST is
> usually to eliminate dependencies which just can't be selected so they
> can be built at all. Given that there's no easy way to select
> everything in a subsystem otherwise does this buy us a lot?
Initially I thought similar - if parent MFD driver can be
compile-tested, then these children do not need that flag...
However the MFD drivers depend on I2C which (currently) cannot be
removed for compile testing. On the other hand, regulator drivers do not
need that dependency so you can compile-test them with I2C=n. That is
the main benefit. If you wish, I can add this information to the commit
msg.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
rtc-linux@googlegroups.com
Subject: [rtc-linux] Re: [PATCH 2/4] regulator: Enable compile testing for Maxim and Samsung PMIC drivers
Date: Tue, 4 Oct 2016 11:30:56 +0200 [thread overview]
Message-ID: <20161004093056.GA8832@kozik-book> (raw)
In-Reply-To: <20161004024055.4kdjvoiig4fwxi54@sirena.org.uk>
On Tue, Oct 04, 2016 at 04:40:55AM +0200, Mark Brown wrote:
> On Sun, Oct 02, 2016 at 10:58:15PM +0200, Krzysztof Kozlowski wrote:
> > Most of Maxim and Samsung PMIC/MUIC regulator drivers can be compile
> > tested to increase build coverage.
>
> All these drivers already just depend on the MFDs which don't have any
> weird architecture dependencies - the main goal with COMPILE_TEST is
> usually to eliminate dependencies which just can't be selected so they
> can be built at all. Given that there's no easy way to select
> everything in a subsystem otherwise does this buy us a lot?
Initially I thought similar - if parent MFD driver can be
compile-tested, then these children do not need that flag...
However the MFD drivers depend on I2C which (currently) cannot be
removed for compile testing. On the other hand, regulator drivers do not
need that dependency so you can compile-test them with I2C=n. That is
the main benefit. If you wish, I can add this information to the commit
msg.
Best regards,
Krzysztof
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2016-10-04 9:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-02 20:58 [PATCH 0/4] clk/mfd/regulator/rtc: Enable compile testing for some Maxim/Samsung drivers Krzysztof Kozlowski
2016-10-02 20:58 ` [rtc-linux] " Krzysztof Kozlowski
2016-10-02 20:58 ` [PATCH 1/4] clk: Enable compile testing for s2mps11 and max77686 Krzysztof Kozlowski
2016-10-02 20:58 ` [rtc-linux] " Krzysztof Kozlowski
2016-11-02 0:33 ` Stephen Boyd
2016-11-02 0:33 ` [rtc-linux] " Stephen Boyd
2016-10-02 20:58 ` [PATCH 2/4] regulator: Enable compile testing for Maxim and Samsung PMIC drivers Krzysztof Kozlowski
2016-10-02 20:58 ` [rtc-linux] " Krzysztof Kozlowski
2016-10-04 2:40 ` Mark Brown
2016-10-04 2:40 ` [rtc-linux] " Mark Brown
2016-10-04 9:30 ` Krzysztof Kozlowski [this message]
2016-10-04 9:30 ` Krzysztof Kozlowski
2016-10-02 20:58 ` [PATCH 3/4] rtc: Enable compile testing for Maxim and Samsung drivers Krzysztof Kozlowski
2016-10-02 20:58 ` [rtc-linux] " Krzysztof Kozlowski
2016-11-04 23:12 ` Alexandre Belloni
2016-11-04 23:12 ` [rtc-linux] " Alexandre Belloni
2016-10-02 20:58 ` [PATCH 4/4] mfd: Enable compile testing for max77620 and max77686 Krzysztof Kozlowski
2016-10-02 20:58 ` [rtc-linux] " Krzysztof Kozlowski
2016-10-26 12:19 ` Lee Jones
2016-10-26 12:19 ` [rtc-linux] " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004093056.GA8832@kozik-book \
--to=krzk@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rtc-linux@googlegroups.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.