* [PATCH 1/7] staging: greybus: Format block comments. @ 2016-10-11 3:11 Elise Lennion 2016-10-12 13:24 ` Greg KH 0 siblings, 1 reply; 10+ messages in thread From: Elise Lennion @ 2016-10-11 3:11 UTC (permalink / raw) To: hvaibhav.linux, johan, elder, gregkh, outreachy-kernel Fix checkpatch warning: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Elise Lennion <elise.lennion@gmail.com> --- drivers/staging/greybus/arche-apb-ctrl.c | 5 +++-- drivers/staging/greybus/arche-platform.c | 3 ++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c index 70323aa..89932ab 100644 --- a/drivers/staging/greybus/arche-apb-ctrl.c +++ b/drivers/staging/greybus/arche-apb-ctrl.c @@ -183,7 +183,7 @@ static int standby_boot_seq(struct platform_device *pdev) * Pasted from WDM spec, * - A falling edge on POWEROFF_L is detected (a) * - WDM enters standby mode, but no output signals are changed - * */ + */ /* TODO: POWEROFF_L is input to WDM module */ apb->state = ARCHE_PLATFORM_STATE_STANDBY; @@ -286,7 +286,8 @@ static ssize_t state_store(struct device *dev, return count; /* First we want to make sure we power off everything - * and then enter FW flashing state */ + * and then enter FW flashing state + */ poweroff_seq(pdev); ret = fw_flashing_seq(pdev); } else { diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c index e36ee98..a850f6b 100644 --- a/drivers/staging/greybus/arche-platform.c +++ b/drivers/staging/greybus/arche-platform.c @@ -455,7 +455,8 @@ retry: goto exit; /* First we want to make sure we power off everything - * and then activate back again */ + * and then activate back again + */ device_for_each_child(arche_pdata->dev, NULL, apb_poweroff); arche_platform_poweroff_seq(arche_pdata); -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/7] staging: greybus: Format block comments. 2016-10-11 3:11 [PATCH 1/7] staging: greybus: Format block comments Elise Lennion @ 2016-10-12 13:24 ` Greg KH 2016-10-12 13:55 ` Elise Lennion 2016-10-12 17:33 ` Elise Lennion 0 siblings, 2 replies; 10+ messages in thread From: Greg KH @ 2016-10-12 13:24 UTC (permalink / raw) To: Elise Lennion; +Cc: hvaibhav.linux, johan, elder, outreachy-kernel On Tue, Oct 11, 2016 at 12:11:05AM -0300, Elise Lennion wrote: > Fix checkpatch warning: > > WARNING: Block comments use a trailing */ on a separate line > > Signed-off-by: Elise Lennion <elise.lennion@gmail.com> > --- > drivers/staging/greybus/arche-apb-ctrl.c | 5 +++-- > drivers/staging/greybus/arche-platform.c | 3 ++- > 2 files changed, 5 insertions(+), 3 deletions(-) Does not apply to my tree :( Can you refresh this whole series and resend it? Keep the acks that were sent for some of the patches, and fix up the subject: lines. thanks, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/7] staging: greybus: Format block comments. 2016-10-12 13:24 ` Greg KH @ 2016-10-12 13:55 ` Elise Lennion 2016-10-12 14:03 ` [Outreachy kernel] " Julia Lawall 2016-10-12 14:40 ` Greg KH 2016-10-12 17:33 ` Elise Lennion 1 sibling, 2 replies; 10+ messages in thread From: Elise Lennion @ 2016-10-12 13:55 UTC (permalink / raw) To: Greg KH; +Cc: hvaibhav.linux, johan, elder, outreachy-kernel On Wed, Oct 12, 2016 at 03:24:01PM +0200, Greg KH wrote: > > Does not apply to my tree :( > > Can you refresh this whole series and resend it? Keep the acks that > were sent for some of the patches, and fix up the subject: lines. > Ok, I'll create new patches containing the changes without ack. This one that doesn't apply, should I just drop it? Your tree is local so I can't see what is different, to adjust the changes, until you push the changes to staging-testing, right? thank you, elise. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH 1/7] staging: greybus: Format block comments. 2016-10-12 13:55 ` Elise Lennion @ 2016-10-12 14:03 ` Julia Lawall 2016-10-12 14:40 ` Greg KH 1 sibling, 0 replies; 10+ messages in thread From: Julia Lawall @ 2016-10-12 14:03 UTC (permalink / raw) To: Elise Lennion; +Cc: Greg KH, hvaibhav.linux, johan, elder, outreachy-kernel On Wed, 12 Oct 2016, Elise Lennion wrote: > On Wed, Oct 12, 2016 at 03:24:01PM +0200, Greg KH wrote: > > > > Does not apply to my tree :( > > > > Can you refresh this whole series and resend it? Keep the acks that > > were sent for some of the patches, and fix up the subject: lines. > > > > Ok, I'll create new patches containing the changes without ack. Actually, Greg said to keep the acks on the patches that have been acked. julia > > This one that doesn't apply, should I just drop it? Your tree is local > so I can't see what is different, to adjust the changes, until you push > the changes to staging-testing, right? > > thank you, > > elise. > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161012135508.GC5158%40lennorien.com. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/7] staging: greybus: Format block comments. 2016-10-12 13:55 ` Elise Lennion 2016-10-12 14:03 ` [Outreachy kernel] " Julia Lawall @ 2016-10-12 14:40 ` Greg KH 2016-10-12 15:52 ` Elise Lennion 2016-10-12 17:21 ` Elise Lennion 1 sibling, 2 replies; 10+ messages in thread From: Greg KH @ 2016-10-12 14:40 UTC (permalink / raw) To: Elise Lennion; +Cc: hvaibhav.linux, johan, elder, outreachy-kernel On Wed, Oct 12, 2016 at 10:55:08AM -0300, Elise Lennion wrote: > On Wed, Oct 12, 2016 at 03:24:01PM +0200, Greg KH wrote: > > > > Does not apply to my tree :( > > > > Can you refresh this whole series and resend it? Keep the acks that > > were sent for some of the patches, and fix up the subject: lines. > > > > Ok, I'll create new patches containing the changes without ack. No, keep the acks, why delete them? > This one that doesn't apply, should I just drop it? Your tree is local > so I can't see what is different, to adjust the changes, until you push > the changes to staging-testing, right? My tree is pushed to staging-testing, so you should see this now. Is it not synced up somehow? thanks, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/7] staging: greybus: Format block comments. 2016-10-12 14:40 ` Greg KH @ 2016-10-12 15:52 ` Elise Lennion 2016-10-13 5:19 ` [Outreachy kernel] " Julia Lawall 2016-10-12 17:21 ` Elise Lennion 1 sibling, 1 reply; 10+ messages in thread From: Elise Lennion @ 2016-10-12 15:52 UTC (permalink / raw) To: Greg KH; +Cc: hvaibhav.linux, johan, elder, outreachy-kernel On Wed, Oct 12, 2016 at 04:40:15PM +0200, Greg KH wrote: > On Wed, Oct 12, 2016 at 10:55:08AM -0300, Elise Lennion wrote: > > On Wed, Oct 12, 2016 at 03:24:01PM +0200, Greg KH wrote: > > > > > > Does not apply to my tree :( > > > > > > Can you refresh this whole series and resend it? Keep the acks that > > > were sent for some of the patches, and fix up the subject: lines. > > > > > > > Ok, I'll create new patches containing the changes without ack. > > No, keep the acks, why delete them? > I think didn't explain myself well. I meant that I'd keep the acks and send the changes of the non-acks in new patches. The remaining commits, the ones that don't create conflicts and aren't acked yet, are all changes in greybus/camera.c. Is it ookay to create a new patchset with them? > > This one that doesn't apply, should I just drop it? Your tree is local > > so I can't see what is different, to adjust the changes, until you push > > the changes to staging-testing, right? > > My tree is pushed to staging-testing, so you should see this now. Is it > not synced up somehow? > Yes, I had a lot of trouble syncing the local git branch but now I can see the changes :) > thanks, > > greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH 1/7] staging: greybus: Format block comments. 2016-10-12 15:52 ` Elise Lennion @ 2016-10-13 5:19 ` Julia Lawall 2016-10-13 21:22 ` Elise Lennion 0 siblings, 1 reply; 10+ messages in thread From: Julia Lawall @ 2016-10-13 5:19 UTC (permalink / raw) To: Elise Lennion; +Cc: Greg KH, hvaibhav.linux, johan, elder, outreachy-kernel On Wed, 12 Oct 2016, Elise Lennion wrote: > On Wed, Oct 12, 2016 at 04:40:15PM +0200, Greg KH wrote: > > On Wed, Oct 12, 2016 at 10:55:08AM -0300, Elise Lennion wrote: > > > On Wed, Oct 12, 2016 at 03:24:01PM +0200, Greg KH wrote: > > > > > > > > Does not apply to my tree :( > > > > > > > > Can you refresh this whole series and resend it? Keep the acks that > > > > were sent for some of the patches, and fix up the subject: lines. > > > > > > > > > > Ok, I'll create new patches containing the changes without ack. > > > > No, keep the acks, why delete them? > > > > I think didn't explain myself well. I meant that I'd keep the acks and > send the changes of the non-acks in new patches. > > The remaining commits, the ones that don't create conflicts and aren't > acked yet, are all changes in greybus/camera.c. Is it ookay to create > a new patchset with them? I think you should just send the same series again. julia > > > > This one that doesn't apply, should I just drop it? Your tree is local > > > so I can't see what is different, to adjust the changes, until you push > > > the changes to staging-testing, right? > > > > My tree is pushed to staging-testing, so you should see this now. Is it > > not synced up somehow? > > > > Yes, I had a lot of trouble syncing the local git branch but now I can > see the changes :) > > > thanks, > > > > greg k-h > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161012155247.GA12782%40lennorien.com. > For more options, visit https://groups.google.com/d/optout. > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH 1/7] staging: greybus: Format block comments. 2016-10-13 5:19 ` [Outreachy kernel] " Julia Lawall @ 2016-10-13 21:22 ` Elise Lennion 0 siblings, 0 replies; 10+ messages in thread From: Elise Lennion @ 2016-10-13 21:22 UTC (permalink / raw) To: Julia Lawall; +Cc: gregkh, hvaibhav.linux, johan, elder, outreachy-kernel On Thu, Oct 13, 2016 at 07:19:45AM +0200, Julia Lawall wrote: > > > On Wed, 12 Oct 2016, Elise Lennion wrote: > > > On Wed, Oct 12, 2016 at 04:40:15PM +0200, Greg KH wrote: > > > On Wed, Oct 12, 2016 at 10:55:08AM -0300, Elise Lennion wrote: > > > > On Wed, Oct 12, 2016 at 03:24:01PM +0200, Greg KH wrote: > > > > > > > > > > Does not apply to my tree :( > > > > > > > > > > Can you refresh this whole series and resend it? Keep the acks that > > > > > were sent for some of the patches, and fix up the subject: lines. > > > > > > > > > > > > > Ok, I'll create new patches containing the changes without ack. > > > > > > No, keep the acks, why delete them? > > > > > > > I think didn't explain myself well. I meant that I'd keep the acks and > > send the changes of the non-acks in new patches. > > > > The remaining commits, the ones that don't create conflicts and aren't > > acked yet, are all changes in greybus/camera.c. Is it ookay to create > > a new patchset with them? > > I think you should just send the same series again. > > julia > Ok, I'll resend the remaining patches. thank you, elise ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/7] staging: greybus: Format block comments. 2016-10-12 14:40 ` Greg KH 2016-10-12 15:52 ` Elise Lennion @ 2016-10-12 17:21 ` Elise Lennion 1 sibling, 0 replies; 10+ messages in thread From: Elise Lennion @ 2016-10-12 17:21 UTC (permalink / raw) To: Greg KH; +Cc: hvaibhav.linux, johan, elder, outreachy-kernel New version of this patch: https://groups.google.com/forum/#!topic/outreachy-kernel/mVVbHvYAg5U ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/7] staging: greybus: Format block comments. 2016-10-12 13:24 ` Greg KH 2016-10-12 13:55 ` Elise Lennion @ 2016-10-12 17:33 ` Elise Lennion 1 sibling, 0 replies; 10+ messages in thread From: Elise Lennion @ 2016-10-12 17:33 UTC (permalink / raw) To: Greg KH; +Cc: hvaibhav.linux, johan, elder, outreachy-kernel Please ignore my last message. That's the new version of the patch: https://groups.google.com/forum/#!topic/outreachy-kernel/uulXIW-rOhY I'll make sure my future patches are more organized. ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-10-13 21:22 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-10-11 3:11 [PATCH 1/7] staging: greybus: Format block comments Elise Lennion 2016-10-12 13:24 ` Greg KH 2016-10-12 13:55 ` Elise Lennion 2016-10-12 14:03 ` [Outreachy kernel] " Julia Lawall 2016-10-12 14:40 ` Greg KH 2016-10-12 15:52 ` Elise Lennion 2016-10-13 5:19 ` [Outreachy kernel] " Julia Lawall 2016-10-13 21:22 ` Elise Lennion 2016-10-12 17:21 ` Elise Lennion 2016-10-12 17:33 ` Elise Lennion
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.