From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Jarkko Sakkinen
<jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
open list <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] char/tpm: Check return code of wait_for_tpm_stat
Date: Tue, 11 Oct 2016 11:13:13 -0600 [thread overview]
Message-ID: <20161011171313.GD6881@obsidianresearch.com> (raw)
In-Reply-To: <1476187261-29027-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On Tue, Oct 11, 2016 at 03:01:01PM +0300, Jarkko Sakkinen wrote:
> From: Peter Huewe <peterhuewe-Mmb7MZpHnFY@public.gmane.org>
>
> In some weird cases it might be possible that the TPM does not set
> STS.VALID within the given timeout time (or ever) but sets STS.EXPECT
> (STS=0x0C) In this case the driver gets stuck in the while loop of
> tpm_tis_send_data and loops endlessly.
Doesn't that exchange mean the TPM has lost synchronization with the
driver? Or maybe it crashed executing a command or something..
Please indicate what hardware is broken like this.. Or how did you get
it to do this?
Jason
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: tpmdd-devel@lists.sourceforge.net,
Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] char/tpm: Check return code of wait_for_tpm_stat
Date: Tue, 11 Oct 2016 11:13:13 -0600 [thread overview]
Message-ID: <20161011171313.GD6881@obsidianresearch.com> (raw)
In-Reply-To: <1476187261-29027-1-git-send-email-jarkko.sakkinen@linux.intel.com>
On Tue, Oct 11, 2016 at 03:01:01PM +0300, Jarkko Sakkinen wrote:
> From: Peter Huewe <peterhuewe@gmx.de>
>
> In some weird cases it might be possible that the TPM does not set
> STS.VALID within the given timeout time (or ever) but sets STS.EXPECT
> (STS=0x0C) In this case the driver gets stuck in the while loop of
> tpm_tis_send_data and loops endlessly.
Doesn't that exchange mean the TPM has lost synchronization with the
driver? Or maybe it crashed executing a command or something..
Please indicate what hardware is broken like this.. Or how did you get
it to do this?
Jason
next prev parent reply other threads:[~2016-10-11 17:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 12:01 [PATCH] char/tpm: Check return code of wait_for_tpm_stat Jarkko Sakkinen
2016-10-11 12:01 ` Jarkko Sakkinen
[not found] ` <1476187261-29027-1-git-send-email-jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2016-10-11 17:13 ` Jason Gunthorpe [this message]
2016-10-11 17:13 ` Jason Gunthorpe
[not found] ` <20161011171313.GD6881-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-11 18:01 ` Peter Huewe
2016-10-11 18:01 ` Peter Huewe
[not found] ` <9174B547-9CD1-4F1B-A2A7-38B9A6AA3B33-Mmb7MZpHnFY@public.gmane.org>
2016-10-12 12:16 ` Jarkko Sakkinen
2016-10-12 12:16 ` Jarkko Sakkinen
2016-10-21 15:35 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011171313.GD6881@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.