* [lustre-devel] [bug report] staging: lustre: create striped directory
@ 2016-10-11 11:37 Dan Carpenter
[not found] ` <D4225DB9.44EC%di.wang@intel.com>
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2016-10-11 11:37 UTC (permalink / raw)
To: lustre-devel
Hello wang di,
The patch 2de353860782: "staging: lustre: create striped directory"
from Aug 16, 2016, leads to the following static checker warning:
drivers/staging/lustre/lustre/llite/namei.c:294 ll_md_blocking_ast()
warn: 'master_inode' isn't an ERR_PTR
drivers/staging/lustre/lustre/llite/namei.c
287
288 hash = cl_fid_build_ino(&lli->lli_pfid,
289 ll_need_32bit_api(ll_i2sbi(inode)));
290
291 master_inode = ilookup5(inode->i_sb, hash,
292 ll_test_inode_by_fid,
293 (void *)&lli->lli_pfid);
294 if (master_inode && !IS_ERR(master_inode)) {
^^^^^^^^^^^^^^^^^^^^
ilookup5() never returns ERR_PTRs.
295 ll_invalidate_negative_children(master_inode);
296 iput(master_inode);
297 }
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* [lustre-devel] [bug report] staging: lustre: create striped directory
[not found] ` <D4225DB9.44EC%di.wang@intel.com>
@ 2016-10-12 9:17 ` Dan Carpenter
2016-10-13 22:38 ` James Simmons
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2016-10-12 9:17 UTC (permalink / raw)
To: lustre-devel
On Tue, Oct 11, 2016 at 04:14:11PM +0000, Wang, Di wrote:
> Hello,
>
> On 10/11/16, 4:37 AM, "Dan Carpenter" <dan.carpenter@oracle.com> wrote:
>
> >Hello wang di,
> >
> >The patch 2de353860782: "staging: lustre: create striped directory"
> >from Aug 16, 2016, leads to the following static checker warning:
> >
> > drivers/staging/lustre/lustre/llite/namei.c:294 ll_md_blocking_ast()
> > warn: 'master_inode' isn't an ERR_PTR
> >
> >drivers/staging/lustre/lustre/llite/namei.c
> > 287
> > 288 hash =
> >cl_fid_build_ino(&lli->lli_pfid,
> > 289
> >ll_need_32bit_api(ll_i2sbi(inode)));
> > 290
> > 291 master_inode =
> >ilookup5(inode->i_sb, hash,
> > 292
> >ll_test_inode_by_fid,
> > 293 (void
> >*)&lli->lli_pfid);
> > 294 if (master_inode &&
> >!IS_ERR(master_inode)) {
> >
> >^^^^^^^^^^^^^^^^^^^^
> >ilookup5() never returns ERR_PTRs.
>
> Yes, only master_inode != NULL should be enough here.
Please send a patch to remove the other check?
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* [lustre-devel] [bug report] staging: lustre: create striped directory
2016-10-12 9:17 ` Dan Carpenter
@ 2016-10-13 22:38 ` James Simmons
0 siblings, 0 replies; 3+ messages in thread
From: James Simmons @ 2016-10-13 22:38 UTC (permalink / raw)
To: lustre-devel
> On Tue, Oct 11, 2016 at 04:14:11PM +0000, Wang, Di wrote:
> > Hello,
> >
> > On 10/11/16, 4:37 AM, "Dan Carpenter" <dan.carpenter@oracle.com> wrote:
> >
> > >Hello wang di,
> > >
> > >The patch 2de353860782: "staging: lustre: create striped directory"
> > >from Aug 16, 2016, leads to the following static checker warning:
> > >
> > > drivers/staging/lustre/lustre/llite/namei.c:294 ll_md_blocking_ast()
> > > warn: 'master_inode' isn't an ERR_PTR
> > >
> > >drivers/staging/lustre/lustre/llite/namei.c
> > > 287
> > > 288 hash =
> > >cl_fid_build_ino(&lli->lli_pfid,
> > > 289
> > >ll_need_32bit_api(ll_i2sbi(inode)));
> > > 290
> > > 291 master_inode =
> > >ilookup5(inode->i_sb, hash,
> > > 292
> > >ll_test_inode_by_fid,
> > > 293 (void
> > >*)&lli->lli_pfid);
> > > 294 if (master_inode &&
> > >!IS_ERR(master_inode)) {
> > >
> > >^^^^^^^^^^^^^^^^^^^^
> > >ilookup5() never returns ERR_PTRs.
> >
> > Yes, only master_inode != NULL should be enough here.
>
> Please send a patch to remove the other check?
A patch is being reviewed and validated with our test harness.
Its coming :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-13 22:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-11 11:37 [lustre-devel] [bug report] staging: lustre: create striped directory Dan Carpenter
[not found] ` <D4225DB9.44EC%di.wang@intel.com>
2016-10-12 9:17 ` Dan Carpenter
2016-10-13 22:38 ` James Simmons
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.