From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v3] powerpc: Check whether TM is available before running other tests
Date: Wed, 12 Oct 2016 14:49:44 +0000 [thread overview]
Message-ID: <20161012144944.GD30525@potion> (raw)
In-Reply-To: <0eeb8d4a-a01f-6d9e-ec12-7b8eef6204b5@redhat.com>
2016-10-12 10:19+0200, Paolo Bonzini:
> On 12/10/2016 10:04, Thomas Huth wrote:
>> On 05.10.2016 09:25, Suraj Jitindar Singh wrote:
>>> On Tue, 2016-10-04 at 11:07 +0200, Thomas Huth wrote:
>>>> Transactional memory is currently only supported on KVM-HV, and
>>>> not yet on KVM-PR. So it's better to check the device tree first
>>>> and fail gracefully if it is not available.
>>>>
>>>> Reviewed-by: Laurent Vivier <lvivier@redhat.com>
>>>> Reviewed-by: Andrew Jones <drjones@redhat.com>
>>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> Thanks for sending a v3.
>>>
>>> Reviewed-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
>>>> ---
>>>> v3:
>>>> - Removed unnecessary check for "plen >= 26" in cpu_has_tm()
>>>>
>>>> v2:
>>>> - Reworked the check for the "ibm,pa-features" and added a comment
>>>> - Use a dedicated variable "has_tm" instead of "i" in main()
>>>>
>>>> powerpc/tm.c | 43 ++++++++++++++++++++++++++++++++++++++++++-
>>>> 1 file changed, 42 insertions(+), 1 deletion(-)
>>
>> Radim, Paolo,
>>
>> I think this patch is now ready to go ... could you please pick it up?
>> (or shall I send a pull request for it?)
>
> Pull requests are always welcome, at least by me. :)
Seconded. I think cooperation will be smoother when using pull
requests ... I didn't notice that the ball was on me this time.
Throwing it back for a pull request.
WARNING: multiple messages have this Message-ID (diff)
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v3] powerpc: Check whether TM is available before running other tests
Date: Wed, 12 Oct 2016 16:49:44 +0200 [thread overview]
Message-ID: <20161012144944.GD30525@potion> (raw)
In-Reply-To: <0eeb8d4a-a01f-6d9e-ec12-7b8eef6204b5@redhat.com>
2016-10-12 10:19+0200, Paolo Bonzini:
> On 12/10/2016 10:04, Thomas Huth wrote:
>> On 05.10.2016 09:25, Suraj Jitindar Singh wrote:
>>> On Tue, 2016-10-04 at 11:07 +0200, Thomas Huth wrote:
>>>> Transactional memory is currently only supported on KVM-HV, and
>>>> not yet on KVM-PR. So it's better to check the device tree first
>>>> and fail gracefully if it is not available.
>>>>
>>>> Reviewed-by: Laurent Vivier <lvivier@redhat.com>
>>>> Reviewed-by: Andrew Jones <drjones@redhat.com>
>>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> Thanks for sending a v3.
>>>
>>> Reviewed-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
>>>> ---
>>>> v3:
>>>> - Removed unnecessary check for "plen >= 26" in cpu_has_tm()
>>>>
>>>> v2:
>>>> - Reworked the check for the "ibm,pa-features" and added a comment
>>>> - Use a dedicated variable "has_tm" instead of "i" in main()
>>>>
>>>> powerpc/tm.c | 43 ++++++++++++++++++++++++++++++++++++++++++-
>>>> 1 file changed, 42 insertions(+), 1 deletion(-)
>>
>> Radim, Paolo,
>>
>> I think this patch is now ready to go ... could you please pick it up?
>> (or shall I send a pull request for it?)
>
> Pull requests are always welcome, at least by me. :)
Seconded. I think cooperation will be smoother when using pull
requests ... I didn't notice that the ball was on me this time.
Throwing it back for a pull request.
next prev parent reply other threads:[~2016-10-12 14:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 9:07 [kvm-unit-tests PATCH v3] powerpc: Check whether TM is available before running other tests Thomas Huth
2016-10-04 9:07 ` Thomas Huth
2016-10-04 9:45 ` Laurent Vivier
2016-10-04 9:45 ` Laurent Vivier
2016-10-05 7:25 ` Suraj Jitindar Singh
2016-10-05 7:25 ` Suraj Jitindar Singh
2016-10-12 8:04 ` Thomas Huth
2016-10-12 8:04 ` Thomas Huth
2016-10-12 8:19 ` Paolo Bonzini
2016-10-12 8:19 ` Paolo Bonzini
2016-10-12 14:49 ` Radim Krčmář [this message]
2016-10-12 14:49 ` Radim Krčmář
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012144944.GD30525@potion \
--to=rkrcmar@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.