[Qemu-devel] [PATCH v3 0/3] 9pfs: fix xattr related issues

[Qemu-devel] [PATCH v3 0/3] 9pfs: fix xattr related issues

[Li Qiang]

From: Li Qiang <liqiang6-s@360.cn>

The current xattr implementation in 9pfs has several issues.

-The 'copied_len' in V9fsXattr is used both for accounting bytes and to tag the xattr fid.
-The 'len/copied_len' field in V9fsXattr has a wrong type.
-The read/write dispatch function of xattr uses unsafe computations.

This patchset solves these issues.

Li Qiang (3):
  9pfs: add xattrwalk_fid field in V9fsXattr struct
  9pfs: convert 'len/copied_len' field in V9fsXattr to the type of
    uint64_t
  9pfs: fix integer overflow issue in xattr read/write

 hw/9pfs/9p.c | 39 ++++++++++++++++-----------------------
 hw/9pfs/9p.h |  5 +++--
 2 files changed, 19 insertions(+), 25 deletions(-)

-- 
1.8.3.1

Re: [Qemu-devel] [PATCH v3 0/3] 9pfs: fix xattr related issues

[Greg Kurz]

On Thu, 13 Oct 2016 03:09:40 -0700
Li Qiang <liq3ea@gmail.com> wrote:

> From: Li Qiang <liqiang6-s@360.cn>
> 
> The current xattr implementation in 9pfs has several issues.
> 
> -The 'copied_len' in V9fsXattr is used both for accounting bytes and to tag the xattr fid.
> -The 'len/copied_len' field in V9fsXattr has a wrong type.
> -The read/write dispatch function of xattr uses unsafe computations.
> 
> This patchset solves these issues.
> 
> Li Qiang (3):
>   9pfs: add xattrwalk_fid field in V9fsXattr struct
>   9pfs: convert 'len/copied_len' field in V9fsXattr to the type of
>     uint64_t
>   9pfs: fix integer overflow issue in xattr read/write
> 
>  hw/9pfs/9p.c | 39 ++++++++++++++++-----------------------
>  hw/9pfs/9p.h |  5 +++--
>  2 files changed, 19 insertions(+), 25 deletions(-)
> 

Weird... the patches appear in separate threads, which is perturbing.

The cover letter has this:

Message-ID: <57ff5d71.4a3c9d0a.90936.6097@mx.google.com>
X-Google-Original-Message-ID: <1476353383-4679-1-git-send-email-Qiang(liqiang6-s@360.cn)>

and patch 1/3 has that:

In-Reply-To: <1476353383-4679-1-git-send-email-Qiang(liqiang6-s@360.cn)>
References: <1476353383-4679-1-git-send-email-Qiang(liqiang6-s@360.cn)>

Is it a "feature" of gmail to rewrite Message-ID headers ? Can it be turned off ?

Cheers.

--
Greg

Re: [Qemu-devel] [PATCH v3 0/3] 9pfs: fix xattr related issues

[Li Qiang]

I'm not sure of this, I use

git format-patch -3 -s --subject-prefix="PATCH v3" --cover-letter

to generate this patchset first and then modify some text. Then

git send-email *.patch --to xx --to

Is there anything wrong?

On 2016-10-13 19:58 GMT+08:00 Greg Kurz <groug@kaod.org> wrote:

> On Thu, 13 Oct 2016 03:09:40 -0700
> Li Qiang <liq3ea@gmail.com> wrote:
>
> > From: Li Qiang <liqiang6-s@360.cn>
> >
> > The current xattr implementation in 9pfs has several issues.
> >
> > -The 'copied_len' in V9fsXattr is used both for accounting bytes and to
> tag the xattr fid.
> > -The 'len/copied_len' field in V9fsXattr has a wrong type.
> > -The read/write dispatch function of xattr uses unsafe computations.
> >
> > This patchset solves these issues.
> >
> > Li Qiang (3):
> >   9pfs: add xattrwalk_fid field in V9fsXattr struct
> >   9pfs: convert 'len/copied_len' field in V9fsXattr to the type of
> >     uint64_t
> >   9pfs: fix integer overflow issue in xattr read/write
> >
> >  hw/9pfs/9p.c | 39 ++++++++++++++++-----------------------
> >  hw/9pfs/9p.h |  5 +++--
> >  2 files changed, 19 insertions(+), 25 deletions(-)
> >
>
> Weird... the patches appear in separate threads, which is perturbing.
>
> The cover letter has this:
>
> Message-ID: <57ff5d71.4a3c9d0a.90936.6097@mx.google.com>
> X-Google-Original-Message-ID: <1476353383-4679-1-git-send-email-Qiang(
> liqiang6-s@360.cn)>
>
> and patch 1/3 has that:
>
> In-Reply-To: <1476353383-4679-1-git-send-email-Qiang(liqiang6-s@360.cn)>
> References: <1476353383-4679-1-git-send-email-Qiang(liqiang6-s@360.cn)>
>
> Is it a "feature" of gmail to rewrite Message-ID headers ? Can it be
> turned off ?
>
> Cheers.
>
> --
> Greg
>

Re: [Qemu-devel] [PATCH v3 0/3] 9pfs: fix xattr related issues

[Greg Kurz]

On Thu, 13 Oct 2016 20:10:17 +0800
Li Qiang <liq3ea@gmail.com> wrote:

> I'm not sure of this, I use
> 
> git format-patch -3 -s --subject-prefix="PATCH v3" --cover-letter
> 
> to generate this patchset first and then modify some text. Then
> 
> git send-email *.patch --to xx --to
> 
> Is there anything wrong?
> 

The git commands look ok ASAICT... the problem seems to be gmail rewriting
the MessageID header, which breaks the mail threading.

Either this is something you can control in your gmail account settings, either
there's a workaround for it, either you should move away from gmail.

FYI, there was a patchset with a gmail From address this morning, which
doesn't have the problem:

[PATCH v2 00/13] Refactor common part of xen backend and frontend

I'll review this patchset but please try to fix it for next time.

Cheers.

--
Greg

> On 2016-10-13 19:58 GMT+08:00 Greg Kurz <groug@kaod.org> wrote:
> 
> > On Thu, 13 Oct 2016 03:09:40 -0700
> > Li Qiang <liq3ea@gmail.com> wrote:
> >
> > > From: Li Qiang <liqiang6-s@360.cn>
> > >
> > > The current xattr implementation in 9pfs has several issues.
> > >
> > > -The 'copied_len' in V9fsXattr is used both for accounting bytes and to
> > tag the xattr fid.
> > > -The 'len/copied_len' field in V9fsXattr has a wrong type.
> > > -The read/write dispatch function of xattr uses unsafe computations.
> > >
> > > This patchset solves these issues.
> > >
> > > Li Qiang (3):
> > >   9pfs: add xattrwalk_fid field in V9fsXattr struct
> > >   9pfs: convert 'len/copied_len' field in V9fsXattr to the type of
> > >     uint64_t
> > >   9pfs: fix integer overflow issue in xattr read/write
> > >
> > >  hw/9pfs/9p.c | 39 ++++++++++++++++-----------------------
> > >  hw/9pfs/9p.h |  5 +++--
> > >  2 files changed, 19 insertions(+), 25 deletions(-)
> > >
> >
> > Weird... the patches appear in separate threads, which is perturbing.
> >
> > The cover letter has this:
> >
> > Message-ID: <57ff5d71.4a3c9d0a.90936.6097@mx.google.com>
> > X-Google-Original-Message-ID: <1476353383-4679-1-git-send-email-Qiang(
> > liqiang6-s@360.cn)>
> >
> > and patch 1/3 has that:
> >
> > In-Reply-To: <1476353383-4679-1-git-send-email-Qiang(liqiang6-s@360.cn)>
> > References: <1476353383-4679-1-git-send-email-Qiang(liqiang6-s@360.cn)>
> >
> > Is it a "feature" of gmail to rewrite Message-ID headers ? Can it be
> > turned off ?
> >
> > Cheers.
> >
> > --
> > Greg
> >

Re: [Qemu-devel] [PATCH v3 0/3] 9pfs: fix xattr related issues

[Li Qiang]

Hello Greg,

I have tried this patchset with my personal email, it seems no error occurs.

And several days ago, I have send patchset successfully.

Maybe it's an accident. It's amazing.

Thanks for your review.

Thanks.

2016-10-13 20:19 GMT+08:00 Greg Kurz <groug@kaod.org>:

> On Thu, 13 Oct 2016 20:10:17 +0800
> Li Qiang <liq3ea@gmail.com> wrote:
>
> > I'm not sure of this, I use
> >
> > git format-patch -3 -s --subject-prefix="PATCH v3" --cover-letter
> >
> > to generate this patchset first and then modify some text. Then
> >
> > git send-email *.patch --to xx --to
> >
> > Is there anything wrong?
> >
>
> The git commands look ok ASAICT... the problem seems to be gmail rewriting
> the MessageID header, which breaks the mail threading.
>
> Either this is something you can control in your gmail account settings,
> either
> there's a workaround for it, either you should move away from gmail.
>
> FYI, there was a patchset with a gmail From address this morning, which
> doesn't have the problem:
>
> [PATCH v2 00/13] Refactor common part of xen backend and frontend
>
> I'll review this patchset but please try to fix it for next time.
>
> Cheers.
>
> --
> Greg
>
> > On 2016-10-13 19:58 GMT+08:00 Greg Kurz <groug@kaod.org> wrote:
> >
> > > On Thu, 13 Oct 2016 03:09:40 -0700
> > > Li Qiang <liq3ea@gmail.com> wrote:
> > >
> > > > From: Li Qiang <liqiang6-s@360.cn>
> > > >
> > > > The current xattr implementation in 9pfs has several issues.
> > > >
> > > > -The 'copied_len' in V9fsXattr is used both for accounting bytes and
> to
> > > tag the xattr fid.
> > > > -The 'len/copied_len' field in V9fsXattr has a wrong type.
> > > > -The read/write dispatch function of xattr uses unsafe computations.
> > > >
> > > > This patchset solves these issues.
> > > >
> > > > Li Qiang (3):
> > > >   9pfs: add xattrwalk_fid field in V9fsXattr struct
> > > >   9pfs: convert 'len/copied_len' field in V9fsXattr to the type of
> > > >     uint64_t
> > > >   9pfs: fix integer overflow issue in xattr read/write
> > > >
> > > >  hw/9pfs/9p.c | 39 ++++++++++++++++-----------------------
> > > >  hw/9pfs/9p.h |  5 +++--
> > > >  2 files changed, 19 insertions(+), 25 deletions(-)
> > > >
> > >
> > > Weird... the patches appear in separate threads, which is perturbing.
> > >
> > > The cover letter has this:
> > >
> > > Message-ID: <57ff5d71.4a3c9d0a.90936.6097@mx.google.com>
> > > X-Google-Original-Message-ID: <1476353383-4679-1-git-send-email-Qiang(
> > > liqiang6-s@360.cn)>
> > >
> > > and patch 1/3 has that:
> > >
> > > In-Reply-To: <1476353383-4679-1-git-send-email-Qiang(liqiang6-s@360.cn
> )>
> > > References: <1476353383-4679-1-git-send-email-Qiang(liqiang6-s@360.cn)
> >
> > >
> > > Is it a "feature" of gmail to rewrite Message-ID headers ? Can it be
> > > turned off ?
> > >
> > > Cheers.
> > >
> > > --
> > > Greg
> > >
>
>