* [lustre-devel] linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?
@ 2016-10-17 7:33 David Binderman
2016-10-17 8:31 ` gregkh
0 siblings, 1 reply; 3+ messages in thread
From: David Binderman @ 2016-10-17 7:33 UTC (permalink / raw)
To: lustre-devel
Hello there,
linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style) Checking if unsigned variable 'cli.cl_avail_grant' is less than zero.
Source code is
?? if (cli->cl_avail_grant < 0) {
Suggest code rework.
Regards
David Binderman
^ permalink raw reply [flat|nested] 3+ messages in thread* [lustre-devel] linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?
2016-10-17 7:33 [lustre-devel] linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ? David Binderman
@ 2016-10-17 8:31 ` gregkh
0 siblings, 0 replies; 3+ messages in thread
From: gregkh at linuxfoundation.org @ 2016-10-17 8:31 UTC (permalink / raw)
To: David Binderman
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
jsimmons@infradead.org, lustre-devel@lists.lustre.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
On Mon, Oct 17, 2016 at 07:33:33AM +0000, David Binderman wrote:
> Hello there,
>
>
>
> linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style) Checking if unsigned variable 'cli.cl_avail_grant' is less than zero.
>
>
>
> Source code is
>
>
>
> ?? if (cli->cl_avail_grant < 0) {
>
>
>
> Suggest code rework.
Great! Please send a patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ?
@ 2016-10-17 8:31 ` gregkh
0 siblings, 0 replies; 3+ messages in thread
From: gregkh @ 2016-10-17 8:31 UTC (permalink / raw)
To: David Binderman
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
jsimmons@infradead.org, lustre-devel@lists.lustre.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
On Mon, Oct 17, 2016 at 07:33:33AM +0000, David Binderman wrote:
> Hello there,
>
>
>
> linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style) Checking if unsigned variable 'cli.cl_avail_grant' is less than zero.
>
>
>
> Source code is
>
>
>
> if (cli->cl_avail_grant < 0) {
>
>
>
> Suggest code rework.
Great! Please send a patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-17 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 7:33 [lustre-devel] linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always false test ? David Binderman
2016-10-17 8:31 ` gregkh at linuxfoundation.org
2016-10-17 8:31 ` gregkh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.