From: Mark Rutland <mark.rutland@arm.com>
To: Laura Abbott <labbott@redhat.com>
Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
David Brown <david.brown@linaro.org>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] Re: [PATCHv2 3/4] arm64: dump: Remove max_addr
Date: Mon, 17 Oct 2016 12:05:54 +0100 [thread overview]
Message-ID: <20161017110553.GD29095@leverpostej> (raw)
In-Reply-To: <1476311522-15381-4-git-send-email-labbott@redhat.com>
On Wed, Oct 12, 2016 at 03:32:01PM -0700, Laura Abbott wrote:
>
> max_addr was added as part of struct ptdump_info but has never actually
> been used. Remove it.
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Tested-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
> ---
> New for v2 of the series
> ---
> arch/arm64/include/asm/ptdump.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/ptdump.h b/arch/arm64/include/asm/ptdump.h
> index 7c35689..8fc0957 100644
> --- a/arch/arm64/include/asm/ptdump.h
> +++ b/arch/arm64/include/asm/ptdump.h
> @@ -30,7 +30,6 @@ struct ptdump_info {
> struct mm_struct *mm;
> const struct addr_marker *markers;
> unsigned long base_addr;
> - unsigned long max_addr;
> };
>
> void ptdump_walk_pgd(struct seq_file *s, struct ptdump_info *info);
> --
> 2.7.4
>
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 3/4] arm64: dump: Remove max_addr
Date: Mon, 17 Oct 2016 12:05:54 +0100 [thread overview]
Message-ID: <20161017110553.GD29095@leverpostej> (raw)
In-Reply-To: <1476311522-15381-4-git-send-email-labbott@redhat.com>
On Wed, Oct 12, 2016 at 03:32:01PM -0700, Laura Abbott wrote:
>
> max_addr was added as part of struct ptdump_info but has never actually
> been used. Remove it.
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Tested-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
> ---
> New for v2 of the series
> ---
> arch/arm64/include/asm/ptdump.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/ptdump.h b/arch/arm64/include/asm/ptdump.h
> index 7c35689..8fc0957 100644
> --- a/arch/arm64/include/asm/ptdump.h
> +++ b/arch/arm64/include/asm/ptdump.h
> @@ -30,7 +30,6 @@ struct ptdump_info {
> struct mm_struct *mm;
> const struct addr_marker *markers;
> unsigned long base_addr;
> - unsigned long max_addr;
> };
>
> void ptdump_walk_pgd(struct seq_file *s, struct ptdump_info *info);
> --
> 2.7.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Laura Abbott <labbott@redhat.com>
Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
David Brown <david.brown@linaro.org>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
kernel-hardening@lists.openwall.com
Subject: Re: [PATCHv2 3/4] arm64: dump: Remove max_addr
Date: Mon, 17 Oct 2016 12:05:54 +0100 [thread overview]
Message-ID: <20161017110553.GD29095@leverpostej> (raw)
In-Reply-To: <1476311522-15381-4-git-send-email-labbott@redhat.com>
On Wed, Oct 12, 2016 at 03:32:01PM -0700, Laura Abbott wrote:
>
> max_addr was added as part of struct ptdump_info but has never actually
> been used. Remove it.
>
> Signed-off-by: Laura Abbott <labbott@redhat.com>
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Tested-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
> ---
> New for v2 of the series
> ---
> arch/arm64/include/asm/ptdump.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/include/asm/ptdump.h b/arch/arm64/include/asm/ptdump.h
> index 7c35689..8fc0957 100644
> --- a/arch/arm64/include/asm/ptdump.h
> +++ b/arch/arm64/include/asm/ptdump.h
> @@ -30,7 +30,6 @@ struct ptdump_info {
> struct mm_struct *mm;
> const struct addr_marker *markers;
> unsigned long base_addr;
> - unsigned long max_addr;
> };
>
> void ptdump_walk_pgd(struct seq_file *s, struct ptdump_info *info);
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-10-17 11:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 22:31 [kernel-hardening] [PATCHv2 0/4] WX checking for arm64 Laura Abbott
2016-10-12 22:31 ` Laura Abbott
2016-10-12 22:31 ` Laura Abbott
2016-10-12 22:31 ` [kernel-hardening] [PATCHv2 1/4] arm64: dump: Make ptdump debugfs a separate option Laura Abbott
2016-10-12 22:31 ` Laura Abbott
2016-10-12 22:31 ` Laura Abbott
2016-10-12 22:45 ` [kernel-hardening] " Kees Cook
2016-10-12 22:45 ` Kees Cook
2016-10-12 22:45 ` Kees Cook
2016-10-12 22:57 ` [kernel-hardening] " Laura Abbott
2016-10-12 22:57 ` Laura Abbott
2016-10-12 22:57 ` Laura Abbott
2016-10-12 23:13 ` [kernel-hardening] " Kees Cook
2016-10-12 23:13 ` Kees Cook
2016-10-12 23:13 ` Kees Cook
2016-10-17 10:52 ` [kernel-hardening] " Mark Rutland
2016-10-17 10:52 ` Mark Rutland
2016-10-17 10:52 ` Mark Rutland
2016-10-17 22:16 ` [kernel-hardening] " Laura Abbott
2016-10-17 22:16 ` Laura Abbott
2016-10-17 22:16 ` Laura Abbott
2016-10-12 22:32 ` [kernel-hardening] [PATCHv2 2/4] arm64: dump: Make the page table dumping seq_file optional Laura Abbott
2016-10-12 22:32 ` Laura Abbott
2016-10-12 22:32 ` Laura Abbott
2016-10-17 11:02 ` [kernel-hardening] " Mark Rutland
2016-10-17 11:02 ` Mark Rutland
2016-10-17 11:02 ` Mark Rutland
2016-10-12 22:32 ` [kernel-hardening] [PATCHv2 3/4] arm64: dump: Remove max_addr Laura Abbott
2016-10-12 22:32 ` Laura Abbott
2016-10-12 22:32 ` Laura Abbott
2016-10-17 11:05 ` Mark Rutland [this message]
2016-10-17 11:05 ` Mark Rutland
2016-10-17 11:05 ` Mark Rutland
2016-10-12 22:32 ` [kernel-hardening] [PATCHv2 4/4] arm64: dump: Add checking for writable and exectuable pages Laura Abbott
2016-10-12 22:32 ` Laura Abbott
2016-10-12 22:32 ` Laura Abbott
2016-10-17 12:47 ` [kernel-hardening] " Mark Rutland
2016-10-17 12:47 ` Mark Rutland
2016-10-17 12:47 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017110553.GD29095@leverpostej \
--to=mark.rutland@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=david.brown@linaro.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=takahiro.akashi@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.