* [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions
@ 2016-10-19 17:17 Jean-Baptiste Abbadie
0 siblings, 0 replies; 8+ messages in thread
From: Jean-Baptiste Abbadie @ 2016-10-19 17:17 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media
Cc: Jean-Baptiste Abbadie
This is a series of minor patch to fix checkpatch.pl issues.
Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 58 +++++++++++++--------------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index fe637ce8f4e7..188d045d44ad 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2057,67 +2057,67 @@ property_signed_read(fm_rssi, int, "%d")
DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
static struct device_attribute attrs[] = {
- __ATTR(power_state, S_IRUGO | S_IWUSR, bcm2048_power_state_read,
+ __ATTR(power_state, 0644, bcm2048_power_state_read,
bcm2048_power_state_write),
- __ATTR(mute, S_IRUGO | S_IWUSR, bcm2048_mute_read,
+ __ATTR(mute, 0644, bcm2048_mute_read,
bcm2048_mute_write),
- __ATTR(audio_route, S_IRUGO | S_IWUSR, bcm2048_audio_route_read,
+ __ATTR(audio_route, 0644, bcm2048_audio_route_read,
bcm2048_audio_route_write),
- __ATTR(dac_output, S_IRUGO | S_IWUSR, bcm2048_dac_output_read,
+ __ATTR(dac_output, 0644, bcm2048_dac_output_read,
bcm2048_dac_output_write),
- __ATTR(fm_hi_lo_injection, S_IRUGO | S_IWUSR,
+ __ATTR(fm_hi_lo_injection, 0644,
bcm2048_fm_hi_lo_injection_read,
bcm2048_fm_hi_lo_injection_write),
- __ATTR(fm_frequency, S_IRUGO | S_IWUSR, bcm2048_fm_frequency_read,
+ __ATTR(fm_frequency, 0644, bcm2048_fm_frequency_read,
bcm2048_fm_frequency_write),
- __ATTR(fm_af_frequency, S_IRUGO | S_IWUSR,
+ __ATTR(fm_af_frequency, 0644,
bcm2048_fm_af_frequency_read,
bcm2048_fm_af_frequency_write),
- __ATTR(fm_deemphasis, S_IRUGO | S_IWUSR, bcm2048_fm_deemphasis_read,
+ __ATTR(fm_deemphasis, 0644, bcm2048_fm_deemphasis_read,
bcm2048_fm_deemphasis_write),
- __ATTR(fm_rds_mask, S_IRUGO | S_IWUSR, bcm2048_fm_rds_mask_read,
+ __ATTR(fm_rds_mask, 0644, bcm2048_fm_rds_mask_read,
bcm2048_fm_rds_mask_write),
- __ATTR(fm_best_tune_mode, S_IRUGO | S_IWUSR,
+ __ATTR(fm_best_tune_mode, 0644,
bcm2048_fm_best_tune_mode_read,
bcm2048_fm_best_tune_mode_write),
- __ATTR(fm_search_rssi_threshold, S_IRUGO | S_IWUSR,
+ __ATTR(fm_search_rssi_threshold, 0644,
bcm2048_fm_search_rssi_threshold_read,
bcm2048_fm_search_rssi_threshold_write),
- __ATTR(fm_search_mode_direction, S_IRUGO | S_IWUSR,
+ __ATTR(fm_search_mode_direction, 0644,
bcm2048_fm_search_mode_direction_read,
bcm2048_fm_search_mode_direction_write),
- __ATTR(fm_search_tune_mode, S_IRUGO | S_IWUSR,
+ __ATTR(fm_search_tune_mode, 0644,
bcm2048_fm_search_tune_mode_read,
bcm2048_fm_search_tune_mode_write),
- __ATTR(rds, S_IRUGO | S_IWUSR, bcm2048_rds_read,
+ __ATTR(rds, 0644, bcm2048_rds_read,
bcm2048_rds_write),
- __ATTR(rds_b_block_mask, S_IRUGO | S_IWUSR,
+ __ATTR(rds_b_block_mask, 0644,
bcm2048_rds_b_block_mask_read,
bcm2048_rds_b_block_mask_write),
- __ATTR(rds_b_block_match, S_IRUGO | S_IWUSR,
+ __ATTR(rds_b_block_match, 0644,
bcm2048_rds_b_block_match_read,
bcm2048_rds_b_block_match_write),
- __ATTR(rds_pi_mask, S_IRUGO | S_IWUSR, bcm2048_rds_pi_mask_read,
+ __ATTR(rds_pi_mask, 0644, bcm2048_rds_pi_mask_read,
bcm2048_rds_pi_mask_write),
- __ATTR(rds_pi_match, S_IRUGO | S_IWUSR, bcm2048_rds_pi_match_read,
+ __ATTR(rds_pi_match, 0644, bcm2048_rds_pi_match_read,
bcm2048_rds_pi_match_write),
- __ATTR(rds_wline, S_IRUGO | S_IWUSR, bcm2048_rds_wline_read,
+ __ATTR(rds_wline, 0644, bcm2048_rds_wline_read,
bcm2048_rds_wline_write),
- __ATTR(rds_pi, S_IRUGO, bcm2048_rds_pi_read, NULL),
- __ATTR(rds_rt, S_IRUGO, bcm2048_rds_rt_read, NULL),
- __ATTR(rds_ps, S_IRUGO, bcm2048_rds_ps_read, NULL),
- __ATTR(fm_rds_flags, S_IRUGO, bcm2048_fm_rds_flags_read, NULL),
- __ATTR(region_bottom_frequency, S_IRUGO,
+ __ATTR(rds_pi, 0444, bcm2048_rds_pi_read, NULL),
+ __ATTR(rds_rt, 0444, bcm2048_rds_rt_read, NULL),
+ __ATTR(rds_ps, 0444, bcm2048_rds_ps_read, NULL),
+ __ATTR(fm_rds_flags, 0444, bcm2048_fm_rds_flags_read, NULL),
+ __ATTR(region_bottom_frequency, 0444,
bcm2048_region_bottom_frequency_read, NULL),
- __ATTR(region_top_frequency, S_IRUGO,
+ __ATTR(region_top_frequency, 0444,
bcm2048_region_top_frequency_read, NULL),
- __ATTR(fm_carrier_error, S_IRUGO,
+ __ATTR(fm_carrier_error, 0444,
bcm2048_fm_carrier_error_read, NULL),
- __ATTR(fm_rssi, S_IRUGO,
+ __ATTR(fm_rssi, 0444,
bcm2048_fm_rssi_read, NULL),
- __ATTR(region, S_IRUGO | S_IWUSR, bcm2048_region_read,
+ __ATTR(region, 0644, bcm2048_region_read,
bcm2048_region_write),
- __ATTR(rds_data, S_IRUGO, bcm2048_rds_data_read, NULL),
+ __ATTR(rds_data, 0444, bcm2048_rds_data_read, NULL),
};
static int bcm2048_sysfs_unregister_properties(struct bcm2048_device *bdev,
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 0/3] media: radio-bcm2048: multiple small cleanups
@ 2016-10-19 20:47 Jean-Baptiste Abbadie
2016-10-19 20:47 ` [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions Jean-Baptiste Abbadie
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Jean-Baptiste Abbadie @ 2016-10-19 20:47 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media
Cc: Jean-Baptiste Abbadie
Hello,
This is a series of minor patches to fix checkpatch.pl issues.
Regards,
Jean-Baptiste
Jean-Baptiste Abbadie (3):
Staging: media: radio-bcm2048: Fix symbolic permissions
Staging: media: radio-bcm2048: Fix indentation
Staging: media: radio-bcm2048: Remove FSF address from GPL notice
drivers/staging/media/bcm2048/radio-bcm2048.c | 66 +++++++++++++--------------
1 file changed, 31 insertions(+), 35 deletions(-)
--
2.10.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions
2016-10-19 20:47 [PATCH 0/3] media: radio-bcm2048: multiple small cleanups Jean-Baptiste Abbadie
@ 2016-10-19 20:47 ` Jean-Baptiste Abbadie
2016-10-19 21:06 ` Mauro Carvalho Chehab
2016-10-19 20:47 ` [PATCH 2/3] Staging: media: radio-bcm2048: Fix indentation Jean-Baptiste Abbadie
2016-10-19 20:47 ` [PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice Jean-Baptiste Abbadie
2 siblings, 1 reply; 8+ messages in thread
From: Jean-Baptiste Abbadie @ 2016-10-19 20:47 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media
Cc: Jean-Baptiste Abbadie
This replaces the S_* style permissions by numbers for the __ATTR macros
Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 58 +++++++++++++--------------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index fe637ce8f4e7..188d045d44ad 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2057,67 +2057,67 @@ property_signed_read(fm_rssi, int, "%d")
DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
static struct device_attribute attrs[] = {
- __ATTR(power_state, S_IRUGO | S_IWUSR, bcm2048_power_state_read,
+ __ATTR(power_state, 0644, bcm2048_power_state_read,
bcm2048_power_state_write),
- __ATTR(mute, S_IRUGO | S_IWUSR, bcm2048_mute_read,
+ __ATTR(mute, 0644, bcm2048_mute_read,
bcm2048_mute_write),
- __ATTR(audio_route, S_IRUGO | S_IWUSR, bcm2048_audio_route_read,
+ __ATTR(audio_route, 0644, bcm2048_audio_route_read,
bcm2048_audio_route_write),
- __ATTR(dac_output, S_IRUGO | S_IWUSR, bcm2048_dac_output_read,
+ __ATTR(dac_output, 0644, bcm2048_dac_output_read,
bcm2048_dac_output_write),
- __ATTR(fm_hi_lo_injection, S_IRUGO | S_IWUSR,
+ __ATTR(fm_hi_lo_injection, 0644,
bcm2048_fm_hi_lo_injection_read,
bcm2048_fm_hi_lo_injection_write),
- __ATTR(fm_frequency, S_IRUGO | S_IWUSR, bcm2048_fm_frequency_read,
+ __ATTR(fm_frequency, 0644, bcm2048_fm_frequency_read,
bcm2048_fm_frequency_write),
- __ATTR(fm_af_frequency, S_IRUGO | S_IWUSR,
+ __ATTR(fm_af_frequency, 0644,
bcm2048_fm_af_frequency_read,
bcm2048_fm_af_frequency_write),
- __ATTR(fm_deemphasis, S_IRUGO | S_IWUSR, bcm2048_fm_deemphasis_read,
+ __ATTR(fm_deemphasis, 0644, bcm2048_fm_deemphasis_read,
bcm2048_fm_deemphasis_write),
- __ATTR(fm_rds_mask, S_IRUGO | S_IWUSR, bcm2048_fm_rds_mask_read,
+ __ATTR(fm_rds_mask, 0644, bcm2048_fm_rds_mask_read,
bcm2048_fm_rds_mask_write),
- __ATTR(fm_best_tune_mode, S_IRUGO | S_IWUSR,
+ __ATTR(fm_best_tune_mode, 0644,
bcm2048_fm_best_tune_mode_read,
bcm2048_fm_best_tune_mode_write),
- __ATTR(fm_search_rssi_threshold, S_IRUGO | S_IWUSR,
+ __ATTR(fm_search_rssi_threshold, 0644,
bcm2048_fm_search_rssi_threshold_read,
bcm2048_fm_search_rssi_threshold_write),
- __ATTR(fm_search_mode_direction, S_IRUGO | S_IWUSR,
+ __ATTR(fm_search_mode_direction, 0644,
bcm2048_fm_search_mode_direction_read,
bcm2048_fm_search_mode_direction_write),
- __ATTR(fm_search_tune_mode, S_IRUGO | S_IWUSR,
+ __ATTR(fm_search_tune_mode, 0644,
bcm2048_fm_search_tune_mode_read,
bcm2048_fm_search_tune_mode_write),
- __ATTR(rds, S_IRUGO | S_IWUSR, bcm2048_rds_read,
+ __ATTR(rds, 0644, bcm2048_rds_read,
bcm2048_rds_write),
- __ATTR(rds_b_block_mask, S_IRUGO | S_IWUSR,
+ __ATTR(rds_b_block_mask, 0644,
bcm2048_rds_b_block_mask_read,
bcm2048_rds_b_block_mask_write),
- __ATTR(rds_b_block_match, S_IRUGO | S_IWUSR,
+ __ATTR(rds_b_block_match, 0644,
bcm2048_rds_b_block_match_read,
bcm2048_rds_b_block_match_write),
- __ATTR(rds_pi_mask, S_IRUGO | S_IWUSR, bcm2048_rds_pi_mask_read,
+ __ATTR(rds_pi_mask, 0644, bcm2048_rds_pi_mask_read,
bcm2048_rds_pi_mask_write),
- __ATTR(rds_pi_match, S_IRUGO | S_IWUSR, bcm2048_rds_pi_match_read,
+ __ATTR(rds_pi_match, 0644, bcm2048_rds_pi_match_read,
bcm2048_rds_pi_match_write),
- __ATTR(rds_wline, S_IRUGO | S_IWUSR, bcm2048_rds_wline_read,
+ __ATTR(rds_wline, 0644, bcm2048_rds_wline_read,
bcm2048_rds_wline_write),
- __ATTR(rds_pi, S_IRUGO, bcm2048_rds_pi_read, NULL),
- __ATTR(rds_rt, S_IRUGO, bcm2048_rds_rt_read, NULL),
- __ATTR(rds_ps, S_IRUGO, bcm2048_rds_ps_read, NULL),
- __ATTR(fm_rds_flags, S_IRUGO, bcm2048_fm_rds_flags_read, NULL),
- __ATTR(region_bottom_frequency, S_IRUGO,
+ __ATTR(rds_pi, 0444, bcm2048_rds_pi_read, NULL),
+ __ATTR(rds_rt, 0444, bcm2048_rds_rt_read, NULL),
+ __ATTR(rds_ps, 0444, bcm2048_rds_ps_read, NULL),
+ __ATTR(fm_rds_flags, 0444, bcm2048_fm_rds_flags_read, NULL),
+ __ATTR(region_bottom_frequency, 0444,
bcm2048_region_bottom_frequency_read, NULL),
- __ATTR(region_top_frequency, S_IRUGO,
+ __ATTR(region_top_frequency, 0444,
bcm2048_region_top_frequency_read, NULL),
- __ATTR(fm_carrier_error, S_IRUGO,
+ __ATTR(fm_carrier_error, 0444,
bcm2048_fm_carrier_error_read, NULL),
- __ATTR(fm_rssi, S_IRUGO,
+ __ATTR(fm_rssi, 0444,
bcm2048_fm_rssi_read, NULL),
- __ATTR(region, S_IRUGO | S_IWUSR, bcm2048_region_read,
+ __ATTR(region, 0644, bcm2048_region_read,
bcm2048_region_write),
- __ATTR(rds_data, S_IRUGO, bcm2048_rds_data_read, NULL),
+ __ATTR(rds_data, 0444, bcm2048_rds_data_read, NULL),
};
static int bcm2048_sysfs_unregister_properties(struct bcm2048_device *bdev,
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] Staging: media: radio-bcm2048: Fix indentation
2016-10-19 20:47 [PATCH 0/3] media: radio-bcm2048: multiple small cleanups Jean-Baptiste Abbadie
2016-10-19 20:47 ` [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions Jean-Baptiste Abbadie
@ 2016-10-19 20:47 ` Jean-Baptiste Abbadie
2016-10-19 21:09 ` Mauro Carvalho Chehab
2016-10-19 20:47 ` [PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice Jean-Baptiste Abbadie
2 siblings, 1 reply; 8+ messages in thread
From: Jean-Baptiste Abbadie @ 2016-10-19 20:47 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media
Cc: Jean-Baptiste Abbadie
Align multiple lines statement with parentheses
Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 188d045d44ad..f66bea631e8e 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -997,7 +997,7 @@ static int bcm2048_set_fm_search_tune_mode(struct bcm2048_device *bdev,
timeout = BCM2048_AUTO_SEARCH_TIMEOUT;
if (!wait_for_completion_timeout(&bdev->compl,
- msecs_to_jiffies(timeout)))
+ msecs_to_jiffies(timeout)))
dev_err(&bdev->client->dev, "IRQ timeout.\n");
if (value)
@@ -2202,7 +2202,7 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf,
}
/* interruptible_sleep_on(&bdev->read_queue); */
if (wait_event_interruptible(bdev->read_queue,
- bdev->rds_data_available) < 0) {
+ bdev->rds_data_available) < 0) {
retval = -EINTR;
goto done;
}
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice
2016-10-19 20:47 [PATCH 0/3] media: radio-bcm2048: multiple small cleanups Jean-Baptiste Abbadie
2016-10-19 20:47 ` [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions Jean-Baptiste Abbadie
2016-10-19 20:47 ` [PATCH 2/3] Staging: media: radio-bcm2048: Fix indentation Jean-Baptiste Abbadie
@ 2016-10-19 20:47 ` Jean-Baptiste Abbadie
2016-10-19 21:08 ` Mauro Carvalho Chehab
2 siblings, 1 reply; 8+ messages in thread
From: Jean-Baptiste Abbadie @ 2016-10-19 20:47 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media
Cc: Jean-Baptiste Abbadie
Removes the superfluous statement about writing to the FSF in the GPL
notice
Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index f66bea631e8e..607dd5285149 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -17,10 +17,6 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
- * 02110-1301 USA
*/
/*
--
2.10.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions
2016-10-19 20:47 ` [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions Jean-Baptiste Abbadie
@ 2016-10-19 21:06 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 8+ messages in thread
From: Mauro Carvalho Chehab @ 2016-10-19 21:06 UTC (permalink / raw)
To: Jean-Baptiste Abbadie
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
Hans Verkuil
Em Wed, 19 Oct 2016 22:47:12 +0200
Jean-Baptiste Abbadie <jb@abbadie.fr> escreveu:
You should run get_maintainers.pl and check whomever submitted the driver,
in order to get review. In particular, this driver looks to be
submitted by Hans, although I guess he didn't authored:
commit 899127b67df098e6d878f27be05dc91401cc6685
Author: Hans Verkuil <hans.verkuil@cisco.com>
Date: Mon Nov 4 08:34:42 2013 -0300
[media] This adds support for the BCM2048 radio module found in Nokia N900
Add suport for Nokia N900 radio. This driver is far from being ready
to be added at the main tree, as it creates its own sysfs interface,
and violates lots of Coding Style rules, doing even evil things like
returning from a function inside a macro.
So, it is being added at staging with the condition that it will be
soon be fixed.
> This replaces the S_* style permissions by numbers for the __ATTR macros
I really prefer to see permissions like 0644, instead of those weird
S_* macros, as I can understand right away what is permitted.
>
> Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 58 +++++++++++++--------------
> 1 file changed, 29 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index fe637ce8f4e7..188d045d44ad 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2057,67 +2057,67 @@ property_signed_read(fm_rssi, int, "%d")
> DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
>
> static struct device_attribute attrs[] = {
> - __ATTR(power_state, S_IRUGO | S_IWUSR, bcm2048_power_state_read,
> + __ATTR(power_state, 0644, bcm2048_power_state_read,
> bcm2048_power_state_write),
> - __ATTR(mute, S_IRUGO | S_IWUSR, bcm2048_mute_read,
> + __ATTR(mute, 0644, bcm2048_mute_read,
> bcm2048_mute_write),
> - __ATTR(audio_route, S_IRUGO | S_IWUSR, bcm2048_audio_route_read,
> + __ATTR(audio_route, 0644, bcm2048_audio_route_read,
> bcm2048_audio_route_write),
> - __ATTR(dac_output, S_IRUGO | S_IWUSR, bcm2048_dac_output_read,
> + __ATTR(dac_output, 0644, bcm2048_dac_output_read,
> bcm2048_dac_output_write),
> - __ATTR(fm_hi_lo_injection, S_IRUGO | S_IWUSR,
> + __ATTR(fm_hi_lo_injection, 0644,
> bcm2048_fm_hi_lo_injection_read,
> bcm2048_fm_hi_lo_injection_write),
> - __ATTR(fm_frequency, S_IRUGO | S_IWUSR, bcm2048_fm_frequency_read,
> + __ATTR(fm_frequency, 0644, bcm2048_fm_frequency_read,
> bcm2048_fm_frequency_write),
> - __ATTR(fm_af_frequency, S_IRUGO | S_IWUSR,
> + __ATTR(fm_af_frequency, 0644,
> bcm2048_fm_af_frequency_read,
> bcm2048_fm_af_frequency_write),
> - __ATTR(fm_deemphasis, S_IRUGO | S_IWUSR, bcm2048_fm_deemphasis_read,
> + __ATTR(fm_deemphasis, 0644, bcm2048_fm_deemphasis_read,
> bcm2048_fm_deemphasis_write),
> - __ATTR(fm_rds_mask, S_IRUGO | S_IWUSR, bcm2048_fm_rds_mask_read,
> + __ATTR(fm_rds_mask, 0644, bcm2048_fm_rds_mask_read,
> bcm2048_fm_rds_mask_write),
> - __ATTR(fm_best_tune_mode, S_IRUGO | S_IWUSR,
> + __ATTR(fm_best_tune_mode, 0644,
> bcm2048_fm_best_tune_mode_read,
> bcm2048_fm_best_tune_mode_write),
> - __ATTR(fm_search_rssi_threshold, S_IRUGO | S_IWUSR,
> + __ATTR(fm_search_rssi_threshold, 0644,
> bcm2048_fm_search_rssi_threshold_read,
> bcm2048_fm_search_rssi_threshold_write),
> - __ATTR(fm_search_mode_direction, S_IRUGO | S_IWUSR,
> + __ATTR(fm_search_mode_direction, 0644,
> bcm2048_fm_search_mode_direction_read,
> bcm2048_fm_search_mode_direction_write),
> - __ATTR(fm_search_tune_mode, S_IRUGO | S_IWUSR,
> + __ATTR(fm_search_tune_mode, 0644,
> bcm2048_fm_search_tune_mode_read,
> bcm2048_fm_search_tune_mode_write),
> - __ATTR(rds, S_IRUGO | S_IWUSR, bcm2048_rds_read,
> + __ATTR(rds, 0644, bcm2048_rds_read,
> bcm2048_rds_write),
> - __ATTR(rds_b_block_mask, S_IRUGO | S_IWUSR,
> + __ATTR(rds_b_block_mask, 0644,
> bcm2048_rds_b_block_mask_read,
> bcm2048_rds_b_block_mask_write),
> - __ATTR(rds_b_block_match, S_IRUGO | S_IWUSR,
> + __ATTR(rds_b_block_match, 0644,
> bcm2048_rds_b_block_match_read,
> bcm2048_rds_b_block_match_write),
> - __ATTR(rds_pi_mask, S_IRUGO | S_IWUSR, bcm2048_rds_pi_mask_read,
> + __ATTR(rds_pi_mask, 0644, bcm2048_rds_pi_mask_read,
> bcm2048_rds_pi_mask_write),
> - __ATTR(rds_pi_match, S_IRUGO | S_IWUSR, bcm2048_rds_pi_match_read,
> + __ATTR(rds_pi_match, 0644, bcm2048_rds_pi_match_read,
> bcm2048_rds_pi_match_write),
> - __ATTR(rds_wline, S_IRUGO | S_IWUSR, bcm2048_rds_wline_read,
> + __ATTR(rds_wline, 0644, bcm2048_rds_wline_read,
> bcm2048_rds_wline_write),
> - __ATTR(rds_pi, S_IRUGO, bcm2048_rds_pi_read, NULL),
> - __ATTR(rds_rt, S_IRUGO, bcm2048_rds_rt_read, NULL),
> - __ATTR(rds_ps, S_IRUGO, bcm2048_rds_ps_read, NULL),
> - __ATTR(fm_rds_flags, S_IRUGO, bcm2048_fm_rds_flags_read, NULL),
> - __ATTR(region_bottom_frequency, S_IRUGO,
> + __ATTR(rds_pi, 0444, bcm2048_rds_pi_read, NULL),
> + __ATTR(rds_rt, 0444, bcm2048_rds_rt_read, NULL),
> + __ATTR(rds_ps, 0444, bcm2048_rds_ps_read, NULL),
> + __ATTR(fm_rds_flags, 0444, bcm2048_fm_rds_flags_read, NULL),
> + __ATTR(region_bottom_frequency, 0444,
> bcm2048_region_bottom_frequency_read, NULL),
> - __ATTR(region_top_frequency, S_IRUGO,
> + __ATTR(region_top_frequency, 0444,
> bcm2048_region_top_frequency_read, NULL),
> - __ATTR(fm_carrier_error, S_IRUGO,
> + __ATTR(fm_carrier_error, 0444,
> bcm2048_fm_carrier_error_read, NULL),
> - __ATTR(fm_rssi, S_IRUGO,
> + __ATTR(fm_rssi, 0444,
> bcm2048_fm_rssi_read, NULL),
> - __ATTR(region, S_IRUGO | S_IWUSR, bcm2048_region_read,
> + __ATTR(region, 0644, bcm2048_region_read,
> bcm2048_region_write),
> - __ATTR(rds_data, S_IRUGO, bcm2048_rds_data_read, NULL),
> + __ATTR(rds_data, 0444, bcm2048_rds_data_read, NULL),
> };
>
> static int bcm2048_sysfs_unregister_properties(struct bcm2048_device *bdev,
Thanks,
Mauro
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice
2016-10-19 20:47 ` [PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice Jean-Baptiste Abbadie
@ 2016-10-19 21:08 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 8+ messages in thread
From: Mauro Carvalho Chehab @ 2016-10-19 21:08 UTC (permalink / raw)
To: Jean-Baptiste Abbadie
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media
Em Wed, 19 Oct 2016 22:47:14 +0200
Jean-Baptiste Abbadie <jb@abbadie.fr> escreveu:
> Removes the superfluous statement about writing to the FSF in the GPL
> notice
Looks OK to me. Greg, do you want to pick it on your tree or do you
prefer if I pick myself?
If you prefer to pick it:
Acked-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
>
> Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index f66bea631e8e..607dd5285149 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -17,10 +17,6 @@
> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> * General Public License for more details.
> *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
> - * 02110-1301 USA
> */
>
> /*
Thanks,
Mauro
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] Staging: media: radio-bcm2048: Fix indentation
2016-10-19 20:47 ` [PATCH 2/3] Staging: media: radio-bcm2048: Fix indentation Jean-Baptiste Abbadie
@ 2016-10-19 21:09 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 8+ messages in thread
From: Mauro Carvalho Chehab @ 2016-10-19 21:09 UTC (permalink / raw)
To: Jean-Baptiste Abbadie
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media
Em Wed, 19 Oct 2016 22:47:13 +0200
Jean-Baptiste Abbadie <jb@abbadie.fr> escreveu:
> Align multiple lines statement with parentheses
Looks OK to me. Greg, do you want to pick it on your tree or do you
prefer if I pick myself?
If you prefer to pick it:
Acked-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
>
> Signed-off-by: Jean-Baptiste Abbadie <jb@abbadie.fr>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 188d045d44ad..f66bea631e8e 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -997,7 +997,7 @@ static int bcm2048_set_fm_search_tune_mode(struct bcm2048_device *bdev,
> timeout = BCM2048_AUTO_SEARCH_TIMEOUT;
>
> if (!wait_for_completion_timeout(&bdev->compl,
> - msecs_to_jiffies(timeout)))
> + msecs_to_jiffies(timeout)))
> dev_err(&bdev->client->dev, "IRQ timeout.\n");
>
> if (value)
> @@ -2202,7 +2202,7 @@ static ssize_t bcm2048_fops_read(struct file *file, char __user *buf,
> }
> /* interruptible_sleep_on(&bdev->read_queue); */
> if (wait_event_interruptible(bdev->read_queue,
> - bdev->rds_data_available) < 0) {
> + bdev->rds_data_available) < 0) {
> retval = -EINTR;
> goto done;
> }
Thanks,
Mauro
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-10-19 21:09 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-19 20:47 [PATCH 0/3] media: radio-bcm2048: multiple small cleanups Jean-Baptiste Abbadie
2016-10-19 20:47 ` [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions Jean-Baptiste Abbadie
2016-10-19 21:06 ` Mauro Carvalho Chehab
2016-10-19 20:47 ` [PATCH 2/3] Staging: media: radio-bcm2048: Fix indentation Jean-Baptiste Abbadie
2016-10-19 21:09 ` Mauro Carvalho Chehab
2016-10-19 20:47 ` [PATCH 3/3] Staging: media: radio-bcm2048: Remove FSF address from GPL notice Jean-Baptiste Abbadie
2016-10-19 21:08 ` Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2016-10-19 17:17 [PATCH 1/3] Staging: media: radio-bcm2048: Fix symbolic permissions Jean-Baptiste Abbadie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.