All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/5] Cavium ThunderX uncore PMU support
Date: Thu, 20 Oct 2016 11:44:18 +0100	[thread overview]
Message-ID: <20161020104417.GD10234@leverpostej> (raw)
In-Reply-To: <20161020103707.GB3175@twins.programming.kicks-ass.net>

On Thu, Oct 20, 2016 at 12:37:07PM +0200, Peter Zijlstra wrote:
> On Thu, Oct 20, 2016 at 11:30:36AM +0200, Jan Glauber wrote:
> > Note:
> > I'm using perf_sw_context in difference to perf_invalid_context
> > (see WARN_ON in perf_pmu_register). Reason is that with perf_invalid_context
> > add() is never called and the counter results are shown as "unsupported" by
> > perf. With perf_sw_context everything works as expected.
> 
> What?! All the uncore PMUs use perf_invalid_context. What doesn't work
> for you?

I think there's general confusion over the use of invalid context.
Perhaps we could clear that up with:

#define perf_uncore_context	perf_invalid_context

and

s/perf_hw_context/perf_cpu_hw_context/

Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jan Glauber <jglauber@cavium.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/5] Cavium ThunderX uncore PMU support
Date: Thu, 20 Oct 2016 11:44:18 +0100	[thread overview]
Message-ID: <20161020104417.GD10234@leverpostej> (raw)
In-Reply-To: <20161020103707.GB3175@twins.programming.kicks-ass.net>

On Thu, Oct 20, 2016 at 12:37:07PM +0200, Peter Zijlstra wrote:
> On Thu, Oct 20, 2016 at 11:30:36AM +0200, Jan Glauber wrote:
> > Note:
> > I'm using perf_sw_context in difference to perf_invalid_context
> > (see WARN_ON in perf_pmu_register). Reason is that with perf_invalid_context
> > add() is never called and the counter results are shown as "unsupported" by
> > perf. With perf_sw_context everything works as expected.
> 
> What?! All the uncore PMUs use perf_invalid_context. What doesn't work
> for you?

I think there's general confusion over the use of invalid context.
Perhaps we could clear that up with:

#define perf_uncore_context	perf_invalid_context

and

s/perf_hw_context/perf_cpu_hw_context/

Mark.

  reply	other threads:[~2016-10-20 10:44 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-20  9:30 [PATCH v3 0/5] Cavium ThunderX uncore PMU support Jan Glauber
2016-10-20  9:30 ` Jan Glauber
2016-10-20  9:30 ` [PATCH v3 1/5] arm64: perf: Basic uncore counter support for Cavium ThunderX SOC Jan Glauber
2016-10-20  9:30   ` Jan Glauber
2016-10-20  9:30 ` [PATCH v3 2/5] arm64: perf: Cavium ThunderX L2C TAD uncore support Jan Glauber
2016-10-20  9:30   ` Jan Glauber
2016-10-20  9:30 ` [PATCH v3 3/5] arm64: perf: Cavium ThunderX L2C CBC " Jan Glauber
2016-10-20  9:30   ` Jan Glauber
2016-10-20  9:30 ` [PATCH v3 4/5] arm64: perf: Cavium ThunderX LMC " Jan Glauber
2016-10-20  9:30   ` Jan Glauber
2016-10-20  9:30 ` [PATCH v3 5/5] arm64: perf: Cavium ThunderX OCX TLK " Jan Glauber
2016-10-20  9:30   ` Jan Glauber
2016-10-20 10:37 ` [PATCH v3 0/5] Cavium ThunderX uncore PMU support Peter Zijlstra
2016-10-20 10:37   ` Peter Zijlstra
2016-10-20 10:44   ` Mark Rutland [this message]
2016-10-20 10:44     ` Mark Rutland
2016-10-20 10:55     ` Peter Zijlstra
2016-10-20 10:55       ` Peter Zijlstra
2016-10-20 11:01       ` Mark Rutland
2016-10-20 11:01         ` Mark Rutland
2016-10-20 11:02   ` Jan Glauber
2016-10-20 11:02     ` Jan Glauber
2016-10-20 11:23   ` Jan Glauber
2016-10-20 11:23     ` Jan Glauber
2016-10-20 11:30     ` Peter Zijlstra
2016-10-20 11:30       ` Peter Zijlstra
2016-10-28 15:17     ` Will Deacon
2016-10-28 15:17       ` Will Deacon
2016-10-28 15:36       ` Jan Glauber
2016-10-28 15:36         ` Jan Glauber
2016-10-28 15:42         ` Mark Rutland
2016-10-28 15:42           ` Mark Rutland
2016-10-20 10:41 ` Mark Rutland
2016-10-20 10:41   ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161020104417.GD10234@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.