From: Lee Jones <lee.jones@linaro.org>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: linux-iio@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Vignesh R <vigneshr@ti.com>, "Andrew F . Davis" <afd@ti.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Sekhar Nori <nsekhar@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: [PATCH 1/4] mfd: ti_am335x_tscadc: store physical address
Date: Wed, 26 Oct 2016 13:17:30 +0100 [thread overview]
Message-ID: <20161026121730.GS8574@dell> (raw)
In-Reply-To: <f271b805-82c2-a45e-0de9-39edafd34d2e@ti.com>
On Fri, 30 Sep 2016, Mugunthan V N wrote:
> On Wednesday 28 September 2016 01:10 AM, Lee Jones wrote:
> > On Wed, 21 Sep 2016, Mugunthan V N wrote:
> >
> >> store the physical address of the device in its priv to use it
> >> for DMA addressing in the client drivers.
> >>
> >> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> >> ---
> >> drivers/mfd/ti_am335x_tscadc.c | 1 +
> >> include/linux/mfd/ti_am335x_tscadc.h | 1 +
> >> 2 files changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
> >> index c8f027b..0f3fab4 100644
> >> --- a/drivers/mfd/ti_am335x_tscadc.c
> >> +++ b/drivers/mfd/ti_am335x_tscadc.c
> >> @@ -183,6 +183,7 @@ static int ti_tscadc_probe(struct platform_device *pdev)
> >> tscadc->irq = err;
> >>
> >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >> + tscadc->tscadc_phys_base = res->start;
> >
> > This is unusual. Can't you use a virt_to_phys() variant instead?
> >
>
> I tried using virt_to_phys(), but its not working for me.
> Also saw many drivers uses like this to get physical address
> ("git grep -n " res->start;" drivers/*").
Very well:
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
Let me know how you wish this set to be handled.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
Vignesh R <vigneshr@ti.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Sekhar Nori <nsekhar@ti.com>,
Russell King <linux@armlinux.org.uk>,
"Andrew F . Davis" <afd@ti.com>, Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Hartmut Knaack <knaack.h@gmx.de>,
linux-omap@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 1/4] mfd: ti_am335x_tscadc: store physical address
Date: Wed, 26 Oct 2016 13:17:30 +0100 [thread overview]
Message-ID: <20161026121730.GS8574@dell> (raw)
In-Reply-To: <f271b805-82c2-a45e-0de9-39edafd34d2e@ti.com>
On Fri, 30 Sep 2016, Mugunthan V N wrote:
> On Wednesday 28 September 2016 01:10 AM, Lee Jones wrote:
> > On Wed, 21 Sep 2016, Mugunthan V N wrote:
> >
> >> store the physical address of the device in its priv to use it
> >> for DMA addressing in the client drivers.
> >>
> >> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> >> ---
> >> drivers/mfd/ti_am335x_tscadc.c | 1 +
> >> include/linux/mfd/ti_am335x_tscadc.h | 1 +
> >> 2 files changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
> >> index c8f027b..0f3fab4 100644
> >> --- a/drivers/mfd/ti_am335x_tscadc.c
> >> +++ b/drivers/mfd/ti_am335x_tscadc.c
> >> @@ -183,6 +183,7 @@ static int ti_tscadc_probe(struct platform_device *pdev)
> >> tscadc->irq = err;
> >>
> >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >> + tscadc->tscadc_phys_base = res->start;
> >
> > This is unusual. Can't you use a virt_to_phys() variant instead?
> >
>
> I tried using virt_to_phys(), but its not working for me.
> Also saw many drivers uses like this to get physical address
> ("git grep -n " res->start;" drivers/*").
Very well:
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
Let me know how you wish this set to be handled.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] mfd: ti_am335x_tscadc: store physical address
Date: Wed, 26 Oct 2016 13:17:30 +0100 [thread overview]
Message-ID: <20161026121730.GS8574@dell> (raw)
In-Reply-To: <f271b805-82c2-a45e-0de9-39edafd34d2e@ti.com>
On Fri, 30 Sep 2016, Mugunthan V N wrote:
> On Wednesday 28 September 2016 01:10 AM, Lee Jones wrote:
> > On Wed, 21 Sep 2016, Mugunthan V N wrote:
> >
> >> store the physical address of the device in its priv to use it
> >> for DMA addressing in the client drivers.
> >>
> >> Signed-off-by: Mugunthan V N <mugunthanvnm@ti.com>
> >> ---
> >> drivers/mfd/ti_am335x_tscadc.c | 1 +
> >> include/linux/mfd/ti_am335x_tscadc.h | 1 +
> >> 2 files changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c
> >> index c8f027b..0f3fab4 100644
> >> --- a/drivers/mfd/ti_am335x_tscadc.c
> >> +++ b/drivers/mfd/ti_am335x_tscadc.c
> >> @@ -183,6 +183,7 @@ static int ti_tscadc_probe(struct platform_device *pdev)
> >> tscadc->irq = err;
> >>
> >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> >> + tscadc->tscadc_phys_base = res->start;
> >
> > This is unusual. Can't you use a virt_to_phys() variant instead?
> >
>
> I tried using virt_to_phys(), but its not working for me.
> Also saw many drivers uses like this to get physical address
> ("git grep -n " res->start;" drivers/*").
Very well:
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
Let me know how you wish this set to be handled.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-10-26 12:23 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 16:11 [PATCH 0/4] Add DMA support for ti_am335x_adc driver Mugunthan V N
2016-09-21 16:11 ` Mugunthan V N
2016-09-21 16:11 ` Mugunthan V N
2016-09-21 16:11 ` [PATCH 1/4] mfd: ti_am335x_tscadc: store physical address Mugunthan V N
2016-09-21 16:11 ` Mugunthan V N
2016-09-21 16:11 ` Mugunthan V N
2016-09-27 19:40 ` Lee Jones
2016-09-27 19:40 ` Lee Jones
2016-09-27 19:40 ` Lee Jones
2016-09-30 8:43 ` Mugunthan V N
2016-09-30 8:43 ` Mugunthan V N
2016-09-30 8:43 ` Mugunthan V N
2016-10-26 12:17 ` Lee Jones [this message]
2016-10-26 12:17 ` Lee Jones
2016-10-26 12:17 ` Lee Jones
2016-10-30 17:05 ` Jonathan Cameron
2016-10-30 17:05 ` Jonathan Cameron
2016-10-31 8:16 ` Lee Jones
2016-10-31 8:16 ` Lee Jones
2016-10-31 8:16 ` Lee Jones
2016-11-05 17:45 ` Jonathan Cameron
2016-11-05 17:45 ` Jonathan Cameron
2016-11-05 17:45 ` Jonathan Cameron
2016-09-21 16:11 ` [PATCH 2/4] drivers: iio: ti_am335x_adc: add dma support Mugunthan V N
2016-09-21 16:11 ` Mugunthan V N
2016-09-21 16:11 ` Mugunthan V N
2016-09-21 17:44 ` Peter Meerwald-Stadler
2016-09-21 17:44 ` Peter Meerwald-Stadler
2016-09-22 10:37 ` Mugunthan V N
2016-09-22 10:37 ` Mugunthan V N
2016-09-22 6:18 ` Vignesh R
2016-09-22 6:18 ` Vignesh R
2016-09-22 6:18 ` Vignesh R
2016-09-22 10:45 ` Mugunthan V N
2016-09-22 10:45 ` Mugunthan V N
2016-09-22 10:45 ` Mugunthan V N
2016-09-22 11:16 ` Peter Ujfalusi
2016-09-22 11:16 ` Peter Ujfalusi
2016-09-22 11:16 ` Peter Ujfalusi
2016-09-22 7:20 ` Peter Ujfalusi
2016-09-22 7:20 ` Peter Ujfalusi
2016-09-22 7:20 ` Peter Ujfalusi
2016-09-22 10:56 ` Mugunthan V N
2016-09-22 10:56 ` Mugunthan V N
2016-09-22 10:56 ` Mugunthan V N
2016-09-21 16:11 ` [PATCH 3/4] ARM: dts: am33xx: add DMA properties for tscadc Mugunthan V N
2016-09-21 16:11 ` Mugunthan V N
2016-09-21 16:11 ` Mugunthan V N
2016-09-21 16:11 ` [PATCH 4/4] ARM: dts: am4372: " Mugunthan V N
2016-09-21 16:11 ` Mugunthan V N
2016-09-21 16:11 ` Mugunthan V N
2016-09-25 9:41 ` [PATCH 0/4] Add DMA support for ti_am335x_adc driver Jonathan Cameron
2016-09-25 9:41 ` Jonathan Cameron
2016-09-25 9:41 ` Jonathan Cameron
2016-09-29 13:01 ` Mugunthan V N
2016-09-29 13:01 ` Mugunthan V N
2016-09-29 13:01 ` Mugunthan V N
2016-09-30 3:37 ` John Syne
2016-09-30 3:37 ` John Syne
2016-09-30 3:37 ` John Syne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026121730.GS8574@dell \
--to=lee.jones@linaro.org \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mugunthanvnm@ti.com \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.