* [meta-raspberrypi][PATCH] u-boot: Fix appending to RDEPENDS
@ 2016-11-01 13:46 Jonathan Liu
2016-11-02 8:28 ` Paul Barker
2016-11-12 18:48 ` Andrei Gherzan
0 siblings, 2 replies; 4+ messages in thread
From: Jonathan Liu @ 2016-11-01 13:46 UTC (permalink / raw)
To: yocto
The += operator should not be used in combination with overrides as it
will clear any existing values in the variable.
Example:
FOO = "bar"
FOO_rpi += "baz"
The above example would result in FOO being equal to " baz" instead of
"bar baz".
The bbappend is changed to use a wildcard instead of a specific version
to simplify updating U-Boot.
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
recipes-bsp/u-boot/u-boot_%.bbappend | 1 +
recipes-bsp/u-boot/u-boot_2016.03.bbappend | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
create mode 100644 recipes-bsp/u-boot/u-boot_%.bbappend
delete mode 100644 recipes-bsp/u-boot/u-boot_2016.03.bbappend
diff --git a/recipes-bsp/u-boot/u-boot_%.bbappend b/recipes-bsp/u-boot/u-boot_%.bbappend
new file mode 100644
index 0000000..3781666
--- /dev/null
+++ b/recipes-bsp/u-boot/u-boot_%.bbappend
@@ -0,0 +1 @@
+RDEPENDS_${PN}_append_rpi = " rpi-u-boot-scr"
diff --git a/recipes-bsp/u-boot/u-boot_2016.03.bbappend b/recipes-bsp/u-boot/u-boot_2016.03.bbappend
deleted file mode 100644
index 35dfc37..0000000
--- a/recipes-bsp/u-boot/u-boot_2016.03.bbappend
+++ /dev/null
@@ -1 +0,0 @@
-RDEPENDS_${PN}_rpi += "rpi-u-boot-scr"
--
2.10.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [meta-raspberrypi][PATCH] u-boot: Fix appending to RDEPENDS
2016-11-01 13:46 [meta-raspberrypi][PATCH] u-boot: Fix appending to RDEPENDS Jonathan Liu
@ 2016-11-02 8:28 ` Paul Barker
2016-11-03 5:58 ` Khem Raj
2016-11-12 18:48 ` Andrei Gherzan
1 sibling, 1 reply; 4+ messages in thread
From: Paul Barker @ 2016-11-02 8:28 UTC (permalink / raw)
To: Jonathan Liu; +Cc: yocto
On Wed, 2 Nov 2016 00:46:47 +1100
Jonathan Liu <net147@gmail.com> wrote:
> The += operator should not be used in combination with overrides as it
> will clear any existing values in the variable.
>
> Example:
> FOO = "bar"
> FOO_rpi += "baz"
>
> The above example would result in FOO being equal to " baz" instead of
> "bar baz".
>
> The bbappend is changed to use a wildcard instead of a specific
> version to simplify updating U-Boot.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
> recipes-bsp/u-boot/u-boot_%.bbappend | 1 +
> recipes-bsp/u-boot/u-boot_2016.03.bbappend | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
> create mode 100644 recipes-bsp/u-boot/u-boot_%.bbappend
> delete mode 100644 recipes-bsp/u-boot/u-boot_2016.03.bbappend
>
> diff --git a/recipes-bsp/u-boot/u-boot_%.bbappend
> b/recipes-bsp/u-boot/u-boot_%.bbappend new file mode 100644
> index 0000000..3781666
> --- /dev/null
> +++ b/recipes-bsp/u-boot/u-boot_%.bbappend
> @@ -0,0 +1 @@
> +RDEPENDS_${PN}_append_rpi = " rpi-u-boot-scr"
> diff --git a/recipes-bsp/u-boot/u-boot_2016.03.bbappend
> b/recipes-bsp/u-boot/u-boot_2016.03.bbappend deleted file mode 100644
> index 35dfc37..0000000
> --- a/recipes-bsp/u-boot/u-boot_2016.03.bbappend
> +++ /dev/null
> @@ -1 +0,0 @@
> -RDEPENDS_${PN}_rpi += "rpi-u-boot-scr"
Looks good. Thanks for picking this up!
Paul
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [meta-raspberrypi][PATCH] u-boot: Fix appending to RDEPENDS
2016-11-02 8:28 ` Paul Barker
@ 2016-11-03 5:58 ` Khem Raj
0 siblings, 0 replies; 4+ messages in thread
From: Khem Raj @ 2016-11-03 5:58 UTC (permalink / raw)
To: Paul Barker; +Cc: yocto
[-- Attachment #1: Type: text/plain, Size: 1559 bytes --]
> On Nov 2, 2016, at 1:28 AM, Paul Barker <paul@paulbarker.me.uk> wrote:
>
> On Wed, 2 Nov 2016 00:46:47 +1100
> Jonathan Liu <net147@gmail.com> wrote:
>
>> The += operator should not be used in combination with overrides as it
>> will clear any existing values in the variable.
>>
>> Example:
>> FOO = "bar"
>> FOO_rpi += "baz"
>>
>> The above example would result in FOO being equal to " baz" instead of
>> "bar baz".
>>
>> The bbappend is changed to use a wildcard instead of a specific
>> version to simplify updating U-Boot.
>>
>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>> ---
>> recipes-bsp/u-boot/u-boot_%.bbappend | 1 +
>> recipes-bsp/u-boot/u-boot_2016.03.bbappend | 1 -
>> 2 files changed, 1 insertion(+), 1 deletion(-)
>> create mode 100644 recipes-bsp/u-boot/u-boot_%.bbappend
>> delete mode 100644 recipes-bsp/u-boot/u-boot_2016.03.bbappend
>>
>> diff --git a/recipes-bsp/u-boot/u-boot_%.bbappend
>> b/recipes-bsp/u-boot/u-boot_%.bbappend new file mode 100644
>> index 0000000..3781666
>> --- /dev/null
>> +++ b/recipes-bsp/u-boot/u-boot_%.bbappend
>> @@ -0,0 +1 @@
>> +RDEPENDS_${PN}_append_rpi = " rpi-u-boot-scr"
>> diff --git a/recipes-bsp/u-boot/u-boot_2016.03.bbappend
>> b/recipes-bsp/u-boot/u-boot_2016.03.bbappend deleted file mode 100644
>> index 35dfc37..0000000
>> --- a/recipes-bsp/u-boot/u-boot_2016.03.bbappend
>> +++ /dev/null
>> @@ -1 +0,0 @@
>> -RDEPENDS_${PN}_rpi += "rpi-u-boot-scr"
>
> Looks good. Thanks for picking this up!
I have staged it for testing
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-raspberrypi][PATCH] u-boot: Fix appending to RDEPENDS
2016-11-01 13:46 [meta-raspberrypi][PATCH] u-boot: Fix appending to RDEPENDS Jonathan Liu
2016-11-02 8:28 ` Paul Barker
@ 2016-11-12 18:48 ` Andrei Gherzan
1 sibling, 0 replies; 4+ messages in thread
From: Andrei Gherzan @ 2016-11-12 18:48 UTC (permalink / raw)
To: Jonathan Liu; +Cc: yocto
[-- Attachment #1: Type: text/plain, Size: 1566 bytes --]
On Wed, Nov 02, 2016 at 12:46:47AM +1100, Jonathan Liu wrote:
> The += operator should not be used in combination with overrides as it
> will clear any existing values in the variable.
>
> Example:
> FOO = "bar"
> FOO_rpi += "baz"
>
> The above example would result in FOO being equal to " baz" instead of
> "bar baz".
>
> The bbappend is changed to use a wildcard instead of a specific version
> to simplify updating U-Boot.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
> recipes-bsp/u-boot/u-boot_%.bbappend | 1 +
> recipes-bsp/u-boot/u-boot_2016.03.bbappend | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
> create mode 100644 recipes-bsp/u-boot/u-boot_%.bbappend
> delete mode 100644 recipes-bsp/u-boot/u-boot_2016.03.bbappend
>
> diff --git a/recipes-bsp/u-boot/u-boot_%.bbappend b/recipes-bsp/u-boot/u-boot_%.bbappend
> new file mode 100644
> index 0000000..3781666
> --- /dev/null
> +++ b/recipes-bsp/u-boot/u-boot_%.bbappend
> @@ -0,0 +1 @@
> +RDEPENDS_${PN}_append_rpi = " rpi-u-boot-scr"
> diff --git a/recipes-bsp/u-boot/u-boot_2016.03.bbappend b/recipes-bsp/u-boot/u-boot_2016.03.bbappend
> deleted file mode 100644
> index 35dfc37..0000000
> --- a/recipes-bsp/u-boot/u-boot_2016.03.bbappend
> +++ /dev/null
> @@ -1 +0,0 @@
> -RDEPENDS_${PN}_rpi += "rpi-u-boot-scr"
> --
> 2.10.1
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
Merged to master. Thanks.
--
Andrei Gherzan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 817 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-12 18:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-01 13:46 [meta-raspberrypi][PATCH] u-boot: Fix appending to RDEPENDS Jonathan Liu
2016-11-02 8:28 ` Paul Barker
2016-11-03 5:58 ` Khem Raj
2016-11-12 18:48 ` Andrei Gherzan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.