[Qemu-devel] build failures in master

[Qemu-devel] build failures in master

[Olaf Hering]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

Not sure if there are automated build tests to catch such mistakes,
these errors appeared after qemu-20161028T142950.fd209e4:

[  337s] ../hw/xen/xen_pvdev.o: In function `xen_pv_printf':
[  337s] /home/abuild/rpmbuild/BUILD/qemu-20161101T165305.4eb28ab/hw/xen/xen_pvdev.c:220: undefined reference to `qemu_log_vprintf'

[  220s] ui/gtk.c: In function 'gd_text_key_down':
[  220s] ui/gtk.c:1073: error: 'GDK_KEY_Delete' undeclared (first use in this function)

Olaf

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

Re: [Qemu-devel] build failures in master

[Thomas Huth]

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

On 02.11.2016 08:03, Olaf Hering wrote:
> Not sure if there are automated build tests to catch such mistakes,
> these errors appeared after qemu-20161028T142950.fd209e4:
> 
> [  337s] ../hw/xen/xen_pvdev.o: In function `xen_pv_printf':
> [  337s] /home/abuild/rpmbuild/BUILD/qemu-20161101T165305.4eb28ab/hw/xen/xen_pvdev.c:220: undefined reference to `qemu_log_vprintf'

Does it work if you add an explicit #include "qemu/log.h" at the
beginning of that file (after osdep.h)?

> [  220s] ui/gtk.c: In function 'gd_text_key_down':
> [  220s] ui/gtk.c:1073: error: 'GDK_KEY_Delete' undeclared (first use in this function)

That one is strange ... it should get defined by <gdk/gdkkeysyms.h>
which we include from include/ui/gtk.h (and that file is included in
ui/gtk.c), so I fail to see how that could not be defined on your
system. Which version of GTK are you using?

 Thomas



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [Qemu-devel] build failures in master

[Thomas Huth]

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

On 02.11.2016 09:14, Thomas Huth wrote:
> On 02.11.2016 08:03, Olaf Hering wrote:
>> Not sure if there are automated build tests to catch such mistakes,
>> these errors appeared after qemu-20161028T142950.fd209e4:
>>
>> [  337s] ../hw/xen/xen_pvdev.o: In function `xen_pv_printf':
>> [  337s] /home/abuild/rpmbuild/BUILD/qemu-20161101T165305.4eb28ab/hw/xen/xen_pvdev.c:220: undefined reference to `qemu_log_vprintf'
> 
> Does it work if you add an explicit #include "qemu/log.h" at the
> beginning of that file (after osdep.h)?
> 
>> [  220s] ui/gtk.c: In function 'gd_text_key_down':
>> [  220s] ui/gtk.c:1073: error: 'GDK_KEY_Delete' undeclared (first use in this function)
> 
> That one is strange ... it should get defined by <gdk/gdkkeysyms.h>
> which we include from include/ui/gtk.h (and that file is included in
> ui/gtk.c), so I fail to see how that could not be defined on your
> system. Which version of GTK are you using?

OK, looks like the name changed with gtk version 2.22:

https://git.gnome.org/browse/gtk+/commit/gdk/gdkkeysyms.h?id=913cdf3be750a1e74c09b20edf55a57f9a919fcc

I'll try to come up with a patch for this issue (since we still seem to
support gtk 2.18 in QEMU) ...

 Thomas



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [Qemu-devel] build failures in master

[Gerd Hoffmann]

On Mi, 2016-11-02 at 09:26 +0100, Thomas Huth wrote:
> On 02.11.2016 09:14, Thomas Huth wrote:
> > On 02.11.2016 08:03, Olaf Hering wrote:
> >> Not sure if there are automated build tests to catch such mistakes,
> >> these errors appeared after qemu-20161028T142950.fd209e4:
> >>
> >> [  337s] ../hw/xen/xen_pvdev.o: In function `xen_pv_printf':
> >> [  337s] /home/abuild/rpmbuild/BUILD/qemu-20161101T165305.4eb28ab/hw/xen/xen_pvdev.c:220: undefined reference to `qemu_log_vprintf'
> > 
> > Does it work if you add an explicit #include "qemu/log.h" at the
> > beginning of that file (after osdep.h)?
> > 
> >> [  220s] ui/gtk.c: In function 'gd_text_key_down':
> >> [  220s] ui/gtk.c:1073: error: 'GDK_KEY_Delete' undeclared (first use in this function)
> > 
> > That one is strange ... it should get defined by <gdk/gdkkeysyms.h>
> > which we include from include/ui/gtk.h (and that file is included in
> > ui/gtk.c), so I fail to see how that could not be defined on your
> > system. Which version of GTK are you using?
> 
> OK, looks like the name changed with gtk version 2.22:
> 
> https://git.gnome.org/browse/gtk+/commit/gdk/gdkkeysyms.h?id=913cdf3be750a1e74c09b20edf55a57f9a919fcc
> 
> I'll try to come up with a patch for this issue (since we still seem to
> support gtk 2.18 in QEMU) ...

Ah, right, that one.  Top of gtk.c file already has a bunch of #defines
for that where we can simply add the delete key.  And as you've tracked
down it's changed in 2.22 + newer if would be nice to change the #ifdef
to use GTK_CHECK_VERSION so we record this fact in the source file.

thanks,
  Gerd

Re: [Qemu-devel] build failures in master

[Olaf Hering]

[-- Attachment #1: Type: text/plain, Size: 246 bytes --]

On Wed, Nov 02, Thomas Huth wrote:

> Does it work if you add an explicit #include "qemu/log.h" at the
> beginning of that file (after osdep.h)?

I will try that.

> system. Which version of GTK are you using?

2.18.9 as included in SLE11.

Olaf

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

Re: [Qemu-devel] build failures in master

[Olaf Hering]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

On Wed, Nov 02, Olaf Hering wrote:

> On Wed, Nov 02, Thomas Huth wrote:
> > Does it work if you add an explicit #include "qemu/log.h" at the
> > beginning of that file (after osdep.h)?
> I will try that.

Yes, that helps. Thanks.

Olaf

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

Re: [Qemu-devel] build failures in master

[Gerd Hoffmann]

On Mi, 2016-11-02 at 08:03 +0100, Olaf Hering wrote:
> Not sure if there are automated build tests to catch such mistakes,

I do test builds with both gtk2 and gtk3 before pull req goes out.

> [  220s] ui/gtk.c: In function 'gd_text_key_down':
> [  220s] ui/gtk.c:1073: error: 'GDK_KEY_Delete' undeclared (first use in this function)

Huh?  Which gtk version is this?

cheers,
  Gerd