From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v2 01/10] ARC: timer: rtc: implement read loop in "C" vs. inline asm
Date: Thu, 3 Nov 2016 23:35:23 +0100 [thread overview]
Message-ID: <20161103223523.GB15759@mai> (raw)
In-Reply-To: <952c1d98-2827-5127-2440-edab342e6b77@synopsys.com>
On Thu, Nov 03, 2016@03:23:09PM -0700, Vineet Gupta wrote:
> On 11/03/2016 02:52 PM, Daniel Lezcano wrote:
> > On Thu, Nov 03, 2016@02:31:32PM -0700, Vineet Gupta wrote:
> >> The current code doesn't even compile ....
> >
> > Give a better description in the log, especially if this patch is supposed to
> > go to stable@
>
> OK.
[ ... ]
> > Is the condition correct ? If I refer to your previous answer, the bit will be
> > set for status if the counter wrapped up. So in this case, we won't exit the
> > loop until we wrap up, no ?
>
> No thats not what I meant. Bit being set there means things are fine (no interrupt
> taken, no increment of high after low was readetc). All I changed here was use of
> 0x8000_0000 to the macro. BBIT0 in assembler means branch if bit was clear.
Fair enough. So the logic is inverted 'status' == 0 means 'not fine'.
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Noam Camus <noamca@mellanox.com>,
tglx@linutronix.de, linux-snps-arc@lists.infradead.org,
linux-kernel@vger.kernel.org, Alexey.Brodkin@synopsys.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2 01/10] ARC: timer: rtc: implement read loop in "C" vs. inline asm
Date: Thu, 3 Nov 2016 23:35:23 +0100 [thread overview]
Message-ID: <20161103223523.GB15759@mai> (raw)
In-Reply-To: <952c1d98-2827-5127-2440-edab342e6b77@synopsys.com>
On Thu, Nov 03, 2016 at 03:23:09PM -0700, Vineet Gupta wrote:
> On 11/03/2016 02:52 PM, Daniel Lezcano wrote:
> > On Thu, Nov 03, 2016 at 02:31:32PM -0700, Vineet Gupta wrote:
> >> The current code doesn't even compile ....
> >
> > Give a better description in the log, especially if this patch is supposed to
> > go to stable@
>
> OK.
[ ... ]
> > Is the condition correct ? If I refer to your previous answer, the bit will be
> > set for status if the counter wrapped up. So in this case, we won't exit the
> > loop until we wrap up, no ?
>
> No thats not what I meant. Bit being set there means things are fine (no interrupt
> taken, no increment of high after low was readetc). All I changed here was use of
> 0x8000_0000 to the macro. BBIT0 in assembler means branch if bit was clear.
Fair enough. So the logic is inverted 'status' == 0 means 'not fine'.
next prev parent reply other threads:[~2016-11-03 22:35 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 21:31 [PATCH v2 00/10] Move ARC timer code into drivers/clocksource/ Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 01/10] ARC: timer: rtc: implement read loop in "C" vs. inline asm Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:52 ` Daniel Lezcano
2016-11-03 21:52 ` Daniel Lezcano
2016-11-03 22:23 ` Vineet Gupta
2016-11-03 22:23 ` Vineet Gupta
2016-11-03 22:35 ` Daniel Lezcano [this message]
2016-11-03 22:35 ` Daniel Lezcano
2016-11-03 22:44 ` Vineet Gupta
2016-11-03 22:44 ` Vineet Gupta
2016-11-03 22:46 ` Daniel Lezcano
2016-11-03 22:46 ` Daniel Lezcano
2016-11-04 17:58 ` Alexey Brodkin
2016-11-04 17:58 ` Alexey Brodkin
2016-11-03 21:31 ` [PATCH v2 02/10] ARC: timer: gfrc, rtc: deuglify big endian code Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:55 ` Daniel Lezcano
2016-11-03 21:55 ` Daniel Lezcano
2016-11-03 22:15 ` Vineet Gupta
2016-11-03 22:15 ` Vineet Gupta
2016-11-04 18:11 ` Alexey Brodkin
2016-11-04 18:11 ` Alexey Brodkin
2016-11-03 21:31 ` [PATCH v2 03/10] ARC: timer: gfrc, rtc: Read BCR to detect whether hardware exists Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 04/10] ARC: timer: gfrc: boot print alongside other timers Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 05/10] ARC: time: move time_init() out of the driver Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 06/10] ARC: timer: Build gfrc, rtc under same option (64-bit timers) Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 22:13 ` Daniel Lezcano
2016-11-03 22:13 ` Daniel Lezcano
2016-11-03 21:31 ` [PATCH v2 07/10] ARC: breakout aux handling into a separate header Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 08/10] ARC: move mcip.h into include/soc and adjust the includes Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 09/10] ARC: breakout timer include code into separate header Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 10/10] clocksource: import ARC timer driver Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 22:38 ` Daniel Lezcano
2016-11-03 22:38 ` Daniel Lezcano
2016-11-03 22:50 ` Vineet Gupta
2016-11-03 22:50 ` Vineet Gupta
2016-11-03 23:01 ` Daniel Lezcano
2016-11-03 23:01 ` Daniel Lezcano
2016-11-03 23:06 ` Vineet Gupta
2016-11-03 23:06 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103223523.GB15759@mai \
--to=daniel.lezcano@linaro.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.