From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v2 01/10] ARC: timer: rtc: implement read loop in "C" vs. inline asm
Date: Thu, 3 Nov 2016 23:46:50 +0100 [thread overview]
Message-ID: <20161103224650.GE15759@mai> (raw)
In-Reply-To: <4ca3d740-dd75-fb4b-1967-aa3a605af62d@synopsys.com>
On Thu, Nov 03, 2016@03:44:24PM -0700, Vineet Gupta wrote:
> On 11/03/2016 03:35 PM, Daniel Lezcano wrote:
> > On Thu, Nov 03, 2016@03:23:09PM -0700, Vineet Gupta wrote:
> >> On 11/03/2016 02:52 PM, Daniel Lezcano wrote:
> >>> On Thu, Nov 03, 2016@02:31:32PM -0700, Vineet Gupta wrote:
> >>>> The current code doesn't even compile ....
> >>>
> >>> Give a better description in the log, especially if this patch is supposed to
> >>> go to stable@
> >>
> >> OK.
> >
> > [ ... ]
>
> Here's what I added
>
> ---->
> ARC: timer: rtc: implement read loop in "C" vs. inline asm
>
> The current code doesn't even compile as somehow the inline assembly
> can't see the register names defined as ARC_RTC_*
> I'm pretty sure It worked when I first got it merged, but the tools were
> definitely different then.
>
> So better to write this in "C" anyways.
Acked-by: Daniel Lezcano <daniel.lezcano at linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: Noam Camus <noamca@mellanox.com>,
tglx@linutronix.de, linux-snps-arc@lists.infradead.org,
linux-kernel@vger.kernel.org, Alexey.Brodkin@synopsys.com,
stable@vger.kernel.org
Subject: Re: [PATCH v2 01/10] ARC: timer: rtc: implement read loop in "C" vs. inline asm
Date: Thu, 3 Nov 2016 23:46:50 +0100 [thread overview]
Message-ID: <20161103224650.GE15759@mai> (raw)
In-Reply-To: <4ca3d740-dd75-fb4b-1967-aa3a605af62d@synopsys.com>
On Thu, Nov 03, 2016 at 03:44:24PM -0700, Vineet Gupta wrote:
> On 11/03/2016 03:35 PM, Daniel Lezcano wrote:
> > On Thu, Nov 03, 2016 at 03:23:09PM -0700, Vineet Gupta wrote:
> >> On 11/03/2016 02:52 PM, Daniel Lezcano wrote:
> >>> On Thu, Nov 03, 2016 at 02:31:32PM -0700, Vineet Gupta wrote:
> >>>> The current code doesn't even compile ....
> >>>
> >>> Give a better description in the log, especially if this patch is supposed to
> >>> go to stable@
> >>
> >> OK.
> >
> > [ ... ]
>
> Here's what I added
>
> ---->
> ARC: timer: rtc: implement read loop in "C" vs. inline asm
>
> The current code doesn't even compile as somehow the inline assembly
> can't see the register names defined as ARC_RTC_*
> I'm pretty sure It worked when I first got it merged, but the tools were
> definitely different then.
>
> So better to write this in "C" anyways.
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
next prev parent reply other threads:[~2016-11-03 22:46 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 21:31 [PATCH v2 00/10] Move ARC timer code into drivers/clocksource/ Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 01/10] ARC: timer: rtc: implement read loop in "C" vs. inline asm Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:52 ` Daniel Lezcano
2016-11-03 21:52 ` Daniel Lezcano
2016-11-03 22:23 ` Vineet Gupta
2016-11-03 22:23 ` Vineet Gupta
2016-11-03 22:35 ` Daniel Lezcano
2016-11-03 22:35 ` Daniel Lezcano
2016-11-03 22:44 ` Vineet Gupta
2016-11-03 22:44 ` Vineet Gupta
2016-11-03 22:46 ` Daniel Lezcano [this message]
2016-11-03 22:46 ` Daniel Lezcano
2016-11-04 17:58 ` Alexey Brodkin
2016-11-04 17:58 ` Alexey Brodkin
2016-11-03 21:31 ` [PATCH v2 02/10] ARC: timer: gfrc, rtc: deuglify big endian code Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:55 ` Daniel Lezcano
2016-11-03 21:55 ` Daniel Lezcano
2016-11-03 22:15 ` Vineet Gupta
2016-11-03 22:15 ` Vineet Gupta
2016-11-04 18:11 ` Alexey Brodkin
2016-11-04 18:11 ` Alexey Brodkin
2016-11-03 21:31 ` [PATCH v2 03/10] ARC: timer: gfrc, rtc: Read BCR to detect whether hardware exists Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 04/10] ARC: timer: gfrc: boot print alongside other timers Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 05/10] ARC: time: move time_init() out of the driver Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 06/10] ARC: timer: Build gfrc, rtc under same option (64-bit timers) Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 22:13 ` Daniel Lezcano
2016-11-03 22:13 ` Daniel Lezcano
2016-11-03 21:31 ` [PATCH v2 07/10] ARC: breakout aux handling into a separate header Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 08/10] ARC: move mcip.h into include/soc and adjust the includes Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 09/10] ARC: breakout timer include code into separate header Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 21:31 ` [PATCH v2 10/10] clocksource: import ARC timer driver Vineet Gupta
2016-11-03 21:31 ` Vineet Gupta
2016-11-03 22:38 ` Daniel Lezcano
2016-11-03 22:38 ` Daniel Lezcano
2016-11-03 22:50 ` Vineet Gupta
2016-11-03 22:50 ` Vineet Gupta
2016-11-03 23:01 ` Daniel Lezcano
2016-11-03 23:01 ` Daniel Lezcano
2016-11-03 23:06 ` Vineet Gupta
2016-11-03 23:06 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103224650.GE15759@mai \
--to=daniel.lezcano@linaro.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.