From: Eric Engestrom <eric@engestrom.ch>
To: "Christian König" <christian.koenig@amd.com>
Cc: dri-devel@lists.freedesktop.org,
"Wei Yongjun" <yongjun_wei@trendmicro.com.cn>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Flora Cui" <Flora.Cui@amd.com>,
"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
"Tom St Denis" <tom.stdenis@amd.com>,
"Thomas Hellstrom" <thellstrom@vmware.com>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Xinliang Liu" <z.liuxinliang@hisilicon.com>,
"VMware Graphics" <linux-graphics-maintainer@vmware.com>,
"Vitaly Prosyak" <vitaly.prosyak@amd.com>,
"Alexandre Demers" <alexandre.f.demers@gmail.com>,
intel-gfx@lists.freedesktop.org,
"Emily Deng" <Emily.Deng@amd.com>,
"Ken Wang" <Qingqing.Wang@amd.com>,
"Junwei Zhang" <Jerry.Zhang@amd.com>,
"Michel Dänzer" <michel.daenzer@amd.com>,
linux-kernel@vger.kernel.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Colin Ian King" <colin.king@canonical.com>
Subject: Re: [PATCH] drm: move allocation out of drm_get_format_name()
Date: Sat, 5 Nov 2016 16:38:44 +0000 [thread overview]
Message-ID: <20161105163844.GA29546@engestrom.ch> (raw)
In-Reply-To: <cc7acbea-a721-22b4-67d3-22198decced6@amd.com>
On Saturday, 2016-11-05 13:11:36 +0100, Christian König wrote:
> Am 05.11.2016 um 02:33 schrieb Eric Engestrom:
> > +typedef char drm_format_name_buf[32];
>
> Please don't use a typedef for this, just define the maximum size of
> characters the function might write somewhere.
>
> See the kernel coding style as well:
> > In general, a pointer, or a struct that has elements that can reasonably
> > be directly accessed should **never** be a typedef.
>
I would normally agree as I tend to hate typedefs ($DAYJOB {ab,mis}uses
them way too much), and your way was what I wrote at first, but Rob Clark's
typedef idea makes it much harder for someone to allocate a buffer of
the wrong size, which IMO is good thing here.
I can rewrite the typedef out if you think it's better.
Cheers,
Eric
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Engestrom <eric@engestrom.ch>
To: "Christian König" <christian.koenig@amd.com>
Cc: linux-kernel@vger.kernel.org,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Xinliang Liu" <z.liuxinliang@hisilicon.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"VMware Graphics" <linux-graphics-maintainer@vmware.com>,
"Sinclair Yeh" <syeh@vmware.com>,
"Thomas Hellstrom" <thellstrom@vmware.com>,
"Tom St Denis" <tom.stdenis@amd.com>,
"Michel Dänzer" <michel.daenzer@amd.com>,
"Gustavo Padovan" <gustavo.padovan@collabora.co.uk>,
"Emily Deng" <Emily.Deng@amd.com>,
"Chunming Zhou" <David1.Zhou@amd.com>,
"Flora Cui" <Flora.Cui@amd.com>,
"Vitaly Prosyak" <vitaly.prosyak@amd.com>,
"Ken Wang" <Qingqing.Wang@amd.com>,
"Colin Ian King" <colin.king@canonical.com>,
"Alexandre Demers" <alexandre.f.demers@gmail.com>,
"Junwei Zhang" <Jerry.Zhang@amd.com>,
"Xinwei Kong" <kong.kongxinwei@hisilicon.com>,
"Chris Wilson" <chris@chris-wilson.co.uk>,
"Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>,
"Wei Yongjun" <yongjun_wei@trendmicro.com.cn>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm: move allocation out of drm_get_format_name()
Date: Sat, 5 Nov 2016 16:38:44 +0000 [thread overview]
Message-ID: <20161105163844.GA29546@engestrom.ch> (raw)
In-Reply-To: <cc7acbea-a721-22b4-67d3-22198decced6@amd.com>
On Saturday, 2016-11-05 13:11:36 +0100, Christian König wrote:
> Am 05.11.2016 um 02:33 schrieb Eric Engestrom:
> > +typedef char drm_format_name_buf[32];
>
> Please don't use a typedef for this, just define the maximum size of
> characters the function might write somewhere.
>
> See the kernel coding style as well:
> > In general, a pointer, or a struct that has elements that can reasonably
> > be directly accessed should **never** be a typedef.
>
I would normally agree as I tend to hate typedefs ($DAYJOB {ab,mis}uses
them way too much), and your way was what I wrote at first, but Rob Clark's
typedef idea makes it much harder for someone to allocate a buffer of
the wrong size, which IMO is good thing here.
I can rewrite the typedef out if you think it's better.
Cheers,
Eric
next prev parent reply other threads:[~2016-11-05 16:38 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 15:32 [PATCH] drm: make drm_get_format_name atomic/irq safe again Rob Clark
2016-11-04 15:45 ` Rob Clark
2016-11-04 16:27 ` Ville Syrjälä
2016-11-04 17:12 ` Rob Clark
2016-11-04 17:32 ` Eric Engestrom
2016-11-04 17:33 ` [PATCH variant 1] " Eric Engestrom
2016-11-04 17:33 ` Eric Engestrom
2016-11-04 17:50 ` [PATCH] " Rob Clark
2016-11-04 18:13 ` Ville Syrjälä
2016-11-05 1:23 ` Eric Engestrom
2016-11-05 1:33 ` [PATCH] drm: move allocation out of drm_get_format_name() Eric Engestrom
2016-11-05 1:33 ` Eric Engestrom
2016-11-05 6:56 ` Thomas Hellstrom
2016-11-05 6:56 ` Thomas Hellstrom
2016-11-05 12:11 ` Christian König
2016-11-05 12:11 ` Christian König
2016-11-05 16:38 ` Eric Engestrom [this message]
2016-11-05 16:38 ` Eric Engestrom
2016-11-05 16:49 ` Rob Clark
2016-11-05 16:49 ` Rob Clark
2016-11-06 9:47 ` Christian König
2016-11-06 9:47 ` Christian König
2016-11-06 13:03 ` Rob Clark
2016-11-06 13:03 ` Rob Clark
2016-11-07 0:47 ` Eric Engestrom
2016-11-07 0:47 ` Eric Engestrom
2016-11-07 0:48 ` [PATCH v2] " Eric Engestrom
2016-11-07 0:48 ` Eric Engestrom
2016-11-07 7:46 ` Christian König
2016-11-07 7:46 ` Christian König
2016-11-07 8:10 ` Jani Nikula
2016-11-07 8:10 ` Jani Nikula
2016-11-07 17:12 ` Eric Engestrom
2016-11-07 17:12 ` Eric Engestrom
2016-11-07 17:38 ` Jani Nikula
2016-11-07 17:38 ` Jani Nikula
2016-11-08 10:15 ` [Intel-gfx] " Daniel Vetter
2016-11-08 10:15 ` Daniel Vetter
2016-11-09 0:17 ` [PATCH v3] " Eric Engestrom
2016-11-09 0:17 ` Eric Engestrom
2016-11-09 1:09 ` [Intel-gfx] " Daniel Vetter
2016-11-09 1:09 ` Daniel Vetter
2016-11-09 1:13 ` Daniel Vetter
2016-11-09 1:13 ` [Intel-gfx] " Daniel Vetter
2016-11-09 11:42 ` Eric Engestrom
2016-11-09 11:42 ` [Intel-gfx] " Eric Engestrom
2016-11-09 13:13 ` Daniel Vetter
2016-11-09 13:13 ` Daniel Vetter
2016-11-09 16:59 ` Eric Engestrom
2016-11-09 16:59 ` [Intel-gfx] " Eric Engestrom
2016-11-10 10:03 ` Laurent Pinchart
2016-11-10 10:03 ` [Intel-gfx] " Laurent Pinchart
2016-11-10 10:30 ` Jani Nikula
2016-11-10 10:30 ` Jani Nikula
2016-11-10 10:59 ` Laurent Pinchart
2016-11-10 10:59 ` Laurent Pinchart
2016-11-10 11:03 ` Jani Nikula
2016-11-10 11:03 ` Jani Nikula
2016-11-11 9:26 ` Daniel Vetter
2016-11-11 9:26 ` Daniel Vetter
2016-11-12 1:12 ` [PATCH v4] " Eric Engestrom
2016-11-12 1:12 ` Eric Engestrom
2016-11-07 14:45 ` [PATCH v2] " Rob Clark
2016-11-07 14:45 ` Rob Clark
2016-11-07 18:12 ` Sinclair Yeh
2016-11-07 18:12 ` Sinclair Yeh
2016-11-05 1:52 ` [PATCH] drm: make drm_get_format_name atomic/irq safe again Rob Clark
2016-11-05 2:15 ` ✓ Fi.CI.BAT: success for drm: move allocation out of drm_get_format_name() Patchwork
2016-11-07 1:15 ` ✗ Fi.CI.BAT: warning for drm: move allocation out of drm_get_format_name() (rev2) Patchwork
2016-11-07 8:18 ` Saarinen, Jani
2016-11-09 0:31 ` ✗ Fi.CI.BAT: failure for drm: move allocation out of drm_get_format_name() (rev3) Patchwork
2016-11-12 1:45 ` ✓ Fi.CI.BAT: success for drm: move allocation out of drm_get_format_name() (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161105163844.GA29546@engestrom.ch \
--to=eric@engestrom.ch \
--cc=Emily.Deng@amd.com \
--cc=Flora.Cui@amd.com \
--cc=Jerry.Zhang@amd.com \
--cc=Qingqing.Wang@amd.com \
--cc=alexander.deucher@amd.com \
--cc=alexandre.f.demers@gmail.com \
--cc=christian.koenig@amd.com \
--cc=colin.king@canonical.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michel.daenzer@amd.com \
--cc=thellstrom@vmware.com \
--cc=tom.stdenis@amd.com \
--cc=vitaly.prosyak@amd.com \
--cc=yongjun_wei@trendmicro.com.cn \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.