Re: [Qemu-devel] [PATCH v2] scripts: qmp: Introduce vcpu pinning helper script

[Peter Xu <peterx@redhat.com>]

On Thu, Nov 03, 2016 at 04:01:08PM +0100, Maxime Coquelin wrote:
> Hi Peter,
> 
> On 10/04/2016 01:22 PM, Maxime Coquelin wrote:
> >This python script calls 'query-cpus' QMP command to retrieve
> >vCPUs thread IDs.
> >Thread IDs are then used by taskset to pin vCPUs to physical
> >CPUs passed in command line.
> >
> >In case more vCPUs are present than the number of CPUs assigned
> >in command line, multiple vCPUs get pinned to physical CPUs.
> >
> >If multiple vCPUs share a same thread ID (e.g. with TCG), the
> >thread ID is pinned a single time.
> >
> >Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> >---
> >Changes since RFC:
> >==================
> > - If vCPUs share a same TID, don't pin them multiple times (peterx)
> >
> > scripts/qmp/qmp-vcpu-pin | 45 +++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 45 insertions(+)
> > create mode 100755 scripts/qmp/qmp-vcpu-pin
> 
> I added your proposed change not to pin same TID multiple time,
> does it look good to you?

Though I am still not familiar with the python and QMP stuffs, but yes
this looks good to me, so:

Reviewed-by: Peter Xu <peterx@redhat.com>

Sorry for the late response.

-- peterx