[Qemu-devel] [PATCH v2] scripts: qmp: Introduce vcpu pinning helper script

[Qemu-devel] [PATCH v2] scripts: qmp: Introduce vcpu pinning helper script

[Maxime Coquelin]

This python script calls 'query-cpus' QMP command to retrieve
vCPUs thread IDs.
Thread IDs are then used by taskset to pin vCPUs to physical
CPUs passed in command line.

In case more vCPUs are present than the number of CPUs assigned
in command line, multiple vCPUs get pinned to physical CPUs.

If multiple vCPUs share a same thread ID (e.g. with TCG), the
thread ID is pinned a single time.

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
Changes since RFC:
==================
 - If vCPUs share a same TID, don't pin them multiple times (peterx)

 scripts/qmp/qmp-vcpu-pin | 45 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100755 scripts/qmp/qmp-vcpu-pin

diff --git a/scripts/qmp/qmp-vcpu-pin b/scripts/qmp/qmp-vcpu-pin
new file mode 100755
index 0000000..9eefe6e
--- /dev/null
+++ b/scripts/qmp/qmp-vcpu-pin
@@ -0,0 +1,45 @@
+#!/usr/bin/python
+# QEMU vCPU pinning tool
+#
+# Copyright (C) 2016 Red Hat Inc.
+#
+# Authors:
+#  Maxime Coquelin <maxime.coquelin@redhat.com>
+#
+# This work is licensed under the terms of the GNU GPL, version 2.  See
+# the COPYING file in the top-level directory
+import argparse
+import json
+import os
+
+from subprocess import call
+from qmp import QEMUMonitorProtocol
+
+pinned = []
+
+parser = argparse.ArgumentParser(description='Pin QEMU vCPUs to physical CPUs')
+parser.add_argument('-s', '--server', type=str, required=True,
+                    help='QMP server path or address:port')
+parser.add_argument('cpu', type=int, nargs='+',
+                    help='Physical CPUs IDs')
+args = parser.parse_args()
+
+devnull = open(os.devnull, 'w')
+
+srv = QEMUMonitorProtocol(args.server)
+srv.connect()
+
+for vcpu in srv.command('query-cpus'):
+    vcpuid = vcpu['CPU']
+    tid = vcpu['thread_id']
+    if tid in pinned:
+        print 'vCPU{}\'s tid {} already pinned, skipping'.format(vcpuid, tid)
+        continue
+
+    cpuid = args.cpu[vcpuid % len(args.cpu)]
+    print 'Pin vCPU {} (tid {}) to physical CPU {}'.format(vcpuid, tid, cpuid)
+    try:
+        call(['taskset', '-pc', str(cpuid), str(tid)], stdout=devnull)
+        pinned.append(tid)
+    except OSError:
+        print 'Failed to pin vCPU{} to CPU{}'.format(vcpuid, cpuid)
-- 
2.7.4

Re: [Qemu-devel] [PATCH v2] scripts: qmp: Introduce vcpu pinning helper script

[Maxime Coquelin]

Hi Peter,

On 10/04/2016 01:22 PM, Maxime Coquelin wrote:
> This python script calls 'query-cpus' QMP command to retrieve
> vCPUs thread IDs.
> Thread IDs are then used by taskset to pin vCPUs to physical
> CPUs passed in command line.
>
> In case more vCPUs are present than the number of CPUs assigned
> in command line, multiple vCPUs get pinned to physical CPUs.
>
> If multiple vCPUs share a same thread ID (e.g. with TCG), the
> thread ID is pinned a single time.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> Changes since RFC:
> ==================
>  - If vCPUs share a same TID, don't pin them multiple times (peterx)
>
>  scripts/qmp/qmp-vcpu-pin | 45 +++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100755 scripts/qmp/qmp-vcpu-pin

I added your proposed change not to pin same TID multiple time,
does it look good to you?

Thanks,
Maxime

Re: [Qemu-devel] [PATCH v2] scripts: qmp: Introduce vcpu pinning helper script

[Peter Xu]

On Thu, Nov 03, 2016 at 04:01:08PM +0100, Maxime Coquelin wrote:
> Hi Peter,
> 
> On 10/04/2016 01:22 PM, Maxime Coquelin wrote:
> >This python script calls 'query-cpus' QMP command to retrieve
> >vCPUs thread IDs.
> >Thread IDs are then used by taskset to pin vCPUs to physical
> >CPUs passed in command line.
> >
> >In case more vCPUs are present than the number of CPUs assigned
> >in command line, multiple vCPUs get pinned to physical CPUs.
> >
> >If multiple vCPUs share a same thread ID (e.g. with TCG), the
> >thread ID is pinned a single time.
> >
> >Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> >---
> >Changes since RFC:
> >==================
> > - If vCPUs share a same TID, don't pin them multiple times (peterx)
> >
> > scripts/qmp/qmp-vcpu-pin | 45 +++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 45 insertions(+)
> > create mode 100755 scripts/qmp/qmp-vcpu-pin
> 
> I added your proposed change not to pin same TID multiple time,
> does it look good to you?

Though I am still not familiar with the python and QMP stuffs, but yes
this looks good to me, so:

Reviewed-by: Peter Xu <peterx@redhat.com>

Sorry for the late response.

-- peterx