From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/7] sunxi: Enable UBI and NAND support
Date: Mon, 14 Nov 2016 15:12:37 +0100 [thread overview]
Message-ID: <20161114141237.pbvskuy76zbyv2iz@lukather> (raw)
In-Reply-To: <49cb76e1-cd3c-c912-8acf-74e98377f199@redhat.com>
On Mon, Nov 14, 2016 at 12:18:06PM +0100, Hans de Goede wrote:
> > #ifdef CONFIG_SPL_SPI_SUNXI
> > @@ -143,7 +157,14 @@
> > #define CONFIG_GENERIC_MMC
> > #define CONFIG_MMC_SUNXI
> > #define CONFIG_MMC_SUNXI_SLOT 0
> > -#define CONFIG_ENV_IS_IN_MMC
> > +#endif
> > +
> > +#if defined(CONFIG_ENV_IS_IN_NAND)
> > +#define CONFIG_ENV_OFFSET 0xc00000
> > +#define CONFIG_ENV_SIZE 0x400000
> > +#elif defined(CONFIG_ENV_IS_IN_MMC)
> > +#define CONFIG_ENV_OFFSET (544 << 10) /* (8 + 24 + 512) KiB */
> > +#define CONFIG_ENV_SIZE (128 << 10) /* 128 KiB */
> > #define CONFIG_SYS_MMC_ENV_DEV 0 /* first detected MMC controller */
> > #endif
Oh, and this part is broken. It relies on the fact that all board
define ENV_IS_IN_MMC (which they should), while obviously they
don't. I'm not exactly sure about what the proper fix would be.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20161114/84fe1854/attachment.sig>
next prev parent reply other threads:[~2016-11-14 14:12 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 16:21 [U-Boot] [PATCH 0/7] sunxi: Add support for the CHIP Pro Maxime Ripard
2016-11-08 16:21 ` [U-Boot] [PATCH 1/7] sunxi: Sync GR8 DTS and AXP209 with the kernel Maxime Ripard
2016-11-14 11:15 ` Hans de Goede
2016-11-08 16:21 ` [U-Boot] [PATCH 2/7] mtd: nand: add support for the TC58NVG2S0H chip Maxime Ripard
2016-11-14 11:15 ` Hans de Goede
2016-11-15 5:04 ` Scott Wood
2016-11-08 16:21 ` [U-Boot] [PATCH 3/7] sunxi: Enable UBI and NAND support Maxime Ripard
2016-11-08 16:27 ` Boris Brezillon
2016-11-08 16:27 ` Boris Brezillon
2016-11-09 14:32 ` Maxime Ripard
2016-11-09 14:57 ` Boris Brezillon
2016-11-14 11:18 ` Hans de Goede
2016-11-14 14:09 ` Maxime Ripard
2016-11-14 14:12 ` Hans de Goede
2016-11-14 14:12 ` Maxime Ripard [this message]
2016-11-14 14:21 ` Hans de Goede
2016-11-14 17:03 ` Tom Rini
2016-11-17 22:27 ` Maxime Ripard
2016-11-08 16:21 ` [U-Boot] [PATCH 4/7] tools: sunxi: Add spl image builder Maxime Ripard
2016-11-08 16:29 ` Boris Brezillon
2016-11-08 20:45 ` Maxime Ripard
2016-11-11 16:20 ` Tom Rini
2016-11-14 15:20 ` Maxime Ripard
2016-11-14 15:25 ` Tom Rini
2016-11-14 18:58 ` Maxime Ripard
2016-11-14 18:59 ` Tom Rini
2016-11-14 11:18 ` Hans de Goede
2016-11-14 11:29 ` Hans de Goede
2016-11-14 13:53 ` Maxime Ripard
2016-11-14 14:01 ` Hans de Goede
2016-11-08 16:21 ` [U-Boot] [PATCH 5/7] nand: sunxi: Add options for the SPL NAND configuration Maxime Ripard
2016-11-08 16:31 ` Boris Brezillon
2016-11-14 11:19 ` Hans de Goede
2016-11-15 5:07 ` Scott Wood
2016-11-08 16:21 ` [U-Boot] [PATCH 6/7] scripts: sunxi: Build an raw SPL image Maxime Ripard
2016-11-08 16:33 ` Boris Brezillon
2016-11-14 11:19 ` Hans de Goede
2016-11-14 11:30 ` Hans de Goede
2016-11-08 16:21 ` [U-Boot] [PATCH 7/7] sunxi: Add support for the CHIP Pro Maxime Ripard
2016-11-14 11:20 ` Hans de Goede
2016-11-09 7:47 ` [U-Boot] [PATCH 0/7] " Heiko Schocher
2016-11-09 14:44 ` Maxime Ripard
2016-11-10 11:57 ` Heiko Schocher
2016-11-11 16:24 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114141237.pbvskuy76zbyv2iz@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.